[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3049 Cool. FYI, the long term goal is to make controller services the exclusive source of configurations for configurations. That's because a single `MongoClient` is really a connection pool and is--according to Mongo Inc.--thread-safe and intended to be used across an entire app. That should help Mongo users tighten up on how many connections they have open from NiFi, especially a cluster (since each node has N number of MongoClients where N = # of mongo processors). ---
[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray
Github user snagacarl commented on the issue: https://github.com/apache/nifi/pull/3049 Yes, I did test the changes in 1.8 and I noticed that change to how the MongoDBLookupService uses a MongoDBControllerService. Thanks for the heads up! ---
[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3049 @snagacarl since this was for the Mongo lookup service, wanted to make sure that you're aware that in 1.8 there will be a slight breaking change. The "configuration" controller service and the lookup service are now cleanly separated so that the lookup service can be cheerfully ignorant of connection details like the URL, SSL and authentication details. That way plugging in a new cluster or something will be faster and easier for Mongo users. ---
[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3049 I'll try to review tonight. Been pretty sick. Thanks for the updates @snagacarl ---
[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/3049 This looks great to me, I thought there was a specific use case for this, if so, it might be good to have a unit or integration text that showed that case. ---
[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray
Github user snagacarl commented on the issue: https://github.com/apache/nifi/pull/3049 Now that the checks have passed, I believe this PR is G2G as far as comments so far are concerned. ---
[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray
Github user snagacarl commented on the issue: https://github.com/apache/nifi/pull/3049 I rebased onto master, FYI. ---
