[GitHub] nifi issue #362: NIFI-1769: added support for SSE-KMS and signature s3v4 aut...
Github user miquillo commented on the issue: https://github.com/apache/nifi/pull/362 @jvwing OUCH! that's painfull to see it's exactly similar to what we've build.. :( I reviewed the code and it seems that it is more mature than our solution and VERY similar :) I'll leave my comments there. I can see if can fix/remove the code we've committed concerning the putkinesis, so this PR will only contain fixes for SSE-KMS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #362: NIFI-1769: added support for SSE-KMS and signature s3v4 aut...
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/362 @miquillo, I'll take another look at the SSE change, but I would like to keep this PR focused on just SSE. We'll need additional tickets and PRs for additional changes. Also, you might take a look at NiFi 1540 / PR #239, an existing effort underway for Kinesis Streams. I'm not sure how your approach compares, but input and feedback would certainly be appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #362: NIFI-1769: added support for SSE-KMS and signature s3v4 aut...
Github user miquillo commented on the issue: https://github.com/apache/nifi/pull/362 @jvwing So it has been a bit silent here, but we continued last week and now we've merged the current master branch into this project. This is where I realized you've implemented the S3v4 (along with v2) already in master, so I've removed our implementation from this branch. The KMS feature is still in, merged with your implementation of S3V4 [using SetSignerOverride() ]. Furthermore we've included a new processor! It's the Kinesis Streams processor, basically the streaming version of firehose. Hope you like it :) Will check Jira and update accordingly. I was unable to built the current master succesfully b/o failing tests in other packages, but it should be working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
