[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 Github is taking a long time to replicate but here is a link to the commit in apache (I pushed it, I swear, lol): https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=4a4d60e6af5014342039f751c7b058079d643f7b --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 +1 Visually verified code and comments were addressed. Did a contrib check build and on a 3 node secure cluster ran through each ticket and did many different iterations of various paths of logic. Thanks Matt @mcgilman, I will merge it in. I will be creating a ticket for the controller service/process group Id because there is another problem with that panel (without W permissions the process group details don't show up). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 As part of NIFI-1800, when viewing the config for a process group it should have the UUID at the top. This way at the very least I can tell which controller services belong to this ProcessGroup without trying to remember the exact UUID (no tab in that panel shows that information). Also it may be best to have the name in that column instead of UUID. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 Similar logic is possible when going from the sub group to root group. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 NIFI-2235 offending logic path: copy processor in root PG go into PG I do not have modify access Context menu does not have paste, palette menu allows it to be clicked after i click paste (and get no access) it correctly refreshes to show no ability to paste --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 I don't think NIFI-2235 was addressed. I am still able to reproduce --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/698 Good catch. Will update PR shortly. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 One thing I did notice is when I have selected just GenerateFF I can move it (UI properly moves relationship too) but if I have GenerateFF and connection selected it fails (message "Must be authorized to modify every component selected."). I believe this is because it is checking if I have permission to move the connection which in turn checks if I have permission to modify the destination (which I don't). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/698 Yeah, I'm unable to replicate. The first message you mentioned sounds like the request was attempted like it was prior to the fix. Maybe your browser had some old JS cached. The "Must be authorized..." message is a client side check that I added to address NIFI-2242. Let me know if you still seeing any weirdness. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 Actually I think that was another bug relating to inconsistent cluster state. I just retried and got a pop-up saying "Must be authorized to modify every component selected." --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/698 NIFI-2242 was when there are multiple components selected with mixed permissions so I think this may be a slightly different case but I'd be happy to address as part of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #698: Updating the UI to reflect the access policies being enforc...
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/698 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
