[GitHub] nifi issue #725: Addressing issues surrounding Template uploading

2016-07-27 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/725
  
+1

Visually verified code and did a contrib check build. In both standalone 
and 3 node secure cluster, I tested all 5 situations and various other checks 
relating to templates. Thanks @mcgilman, I will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #725: Addressing issues surrounding Template uploading

2016-07-27 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/725
  
Good catch and great suggestion. I've updated the PR accordingly. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #725: Addressing issues surrounding Template uploading

2016-07-27 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/725
  
Empty name template checking appears to only occur as a server side check. 
This would be a simple client side check to add and would be a nice UX addition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #725: Addressing issues surrounding Template uploading

2016-07-27 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/725
  
3 node secure cluster testing NIFI-2223, I see "conflict" and not "A 
template named 'XYZ' already exists."

![screen shot 2016-07-27 at 2 17 59 
pm](https://cloud.githubusercontent.com/assets/11302527/17187001/75c83fdc-5405-11e6-8649-98c4dfac5b69.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---