[GitHub] nifi issue #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-10 Thread olegz
Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/727
  
Aside from minor stylistic things (didn't comment on them), I am +1. 
Verified new tests, all pass. Test coverage on the overall module is high.
Merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-08 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/727
  
Closing the PR and cancelling the current patch as there are issues with 
complex types, will reopen once fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-03 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/727
  
I see a few comments about PutHiveStreaming, that is part of a previous 
commit that is being handled under #706, it's just in here in order to inherit 
the downgrade of Hive. Only the last commit needs to be reviewed, I will 
address the other comments in the other PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/727
  
Reviewing



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---