[GitHub] nifi issue #757: Ensuring all component specific policies are removed when t...

2016-08-03 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/757
  
+1

Visually verified code and did a contrib check build. In a 3 node secure 
cluster tried adding and modifying policies for every component and then 
deleting each. Saw policies removed as components were deleted as expected. 
Thanks @mcgilman, I will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #757: Ensuring all component specific policies are removed when t...

2016-08-03 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/757
  
@mcgilman I don't think the UI button to delete the CS/RT works properly. 
When I tried to use it when I had "write" but not "view" I saw a 405.

![screen shot 2016-08-03 at 4 17 16 
pm](https://cloud.githubusercontent.com/assets/11302527/17380576/c5e9329c-5995-11e6-818e-6956e28c7cee.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #757: Ensuring all component specific policies are removed when t...

2016-08-03 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/757
  
Another good catch. I've updated the PR accordingly. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #757: Ensuring all component specific policies are removed when t...

2016-08-03 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/757
  
Sorry for not noticing this earlier but it appears that encapsulated 
components (processors, controller services, etc.) inside a process group that 
gets deleted do not have their associated policies deleted too.

Also I believe there is a small oversight with the UI in regards to CS and 
RT, when you have "write" but not "view" the button for deleting a CS or RT 
does not appear. Probably a super simple fix if you wanted to add it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #757: Ensuring all component specific policies are removed when t...

2016-08-03 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/757
  
Reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---