[GitHub] nifi issue #793: NIFI-2494 Remove extraneous text that shows on banner line
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/793 @mcgilman, I restored the text and added the class to the div tag. My canvas is still fixed and the title is back on the Controller Settings page. Thanks for catching that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #793: NIFI-2494 Remove extraneous text that shows on banner line
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/793 Working on it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #793: NIFI-2494 Remove extraneous text that shows on banner line
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/793 @jskora Thanks for the PR. I just tried it out and was able to replicate the issue. However, with your proposed change, the heading text on the Controller Settings dialog is missing. This is accessed through the global menu and selecting 'Controller Settings'. I think the underlying issue is that the default visibility is not being set on the settings dialog [1]. By adding `class="hidden"` to the settings div, I believe the issue is resolved. Would you mind trying that locally and if you agree update the PR? Thanks again! [1] https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/settings-content.jsp#L18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #793: NIFI-2494 Remove extraneous text that shows on banner line
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/793 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
