[GitHub] nifi issue #982: NIFI-2251 - Initial commit for client side provenance linea...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/982 Thanks @mcgilman! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #982: NIFI-2251 - Initial commit for client side provenance linea...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/982 Thanks @YolandaMDavis! This looks good. I've verified the changes in all of our supported browsers. Just a heads up, I've made a couple minor changes to some spacing/formatting to be more consistent with existing code. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #982: NIFI-2251 - Initial commit for client side provenance linea...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/982 @mcgilman made the changes to support Edge and switched to font awesome icon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #982: NIFI-2251 - Initial commit for client side provenance linea...
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/982 @mcgilman thanks for reviewing. I can take a look at the svg rendered and retest. Also I'll update the icon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #982: NIFI-2251 - Initial commit for client side provenance linea...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/982 @YolandaMDavis Thanks for the PR! A couple comments... - I ran into an issue running on Edge. The svg that is downloaded appears to contain an additional xmlns attribute in the svg tag. With the duplicate attribute, it is causing problems opening the saved svg. Once I manually removed the extra attribute the svg opens successfully. - Also, can we update the Download icon? Using the download icon from FontAwesome [1] should be good. The existing download icon can be removed. [1] http://fontawesome.io/icon/download/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #982: NIFI-2251 - Initial commit for client side provenance linea...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/982 Will Review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
