[GitHub] nifi pull request #1891: NIFI-4008: Allow 0 or more records within a message...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1891 ---
[GitHub] nifi pull request #1891: NIFI-4008: Allow 0 or more records within a message...
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1891#discussion_r124994470
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-0-10-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumerLease.java
---
@@ -418,82 +419,106 @@ private void writeDemarcatedData(final
ProcessSession session, final List> records, final TopicPartition
topicPartition) {
+private void writeRecordData(final ProcessSession session, final
List> messages, final TopicPartition
topicPartition) {
// In order to obtain a RecordReader from the RecordReaderFactory,
we need to give it a FlowFile.
// We don't want to create a new FlowFile for each record that we
receive, so we will just create
// a "temporary flowfile" that will be removed in the finally
block below and use that to pass to
// the createRecordReader method.
final FlowFile tempFlowFile = session.create();
RecordSetWriter writer = null;
+final BiConsumer, Exception>
handleParseFailure = (consumerRecord, e) -> {
--- End diff --
I reviewed and merged #1906 . I will update this PR again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1891: NIFI-4008: Allow 0 or more records within a message...
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1891#discussion_r124803429
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-0-10-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumerLease.java
---
@@ -418,82 +419,106 @@ private void writeDemarcatedData(final
ProcessSession session, final List> records, final TopicPartition
topicPartition) {
+private void writeRecordData(final ProcessSession session, final
List> messages, final TopicPartition
topicPartition) {
// In order to obtain a RecordReader from the RecordReaderFactory,
we need to give it a FlowFile.
// We don't want to create a new FlowFile for each record that we
receive, so we will just create
// a "temporary flowfile" that will be removed in the finally
block below and use that to pass to
// the createRecordReader method.
final FlowFile tempFlowFile = session.create();
RecordSetWriter writer = null;
+final BiConsumer, Exception>
handleParseFailure = (consumerRecord, e) -> {
--- End diff --
Unfortunately, I think this PR very much conflicts with NIFI-4046/PR 1906,
which I just pushed another commit to, in order to address your feedback.
Either PR could be merged first and then the other updated. We both refactored
this piece of code to make it re-usable. However, with the new refactoring for
4046, I think I prefer the method there, of having a separate method instead of
a lambda because we end up passing in an optional message. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1891: NIFI-4008: Allow 0 or more records within a message...
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1891 NIFI-4008: Allow 0 or more records within a message. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijokarumawak/nifi nifi-4008 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1891.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1891 commit 1cc0abb80f3df2a9352729d5ecc8ca63e2afdf1d Author: Koji Kawamura Date: 2017-06-05T12:40:53Z NIFI-4008: Allow 0 or more records within a message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
