[GitHub] nifi pull request #1976: NIFI-1613: Make use of column type correctly at Con...

[ijokarumawak]

Github user ijokarumawak closed the pull request at:

https://github.com/apache/nifi/pull/1976


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1976: NIFI-1613: Make use of column type correctly at Con...

[ijokarumawak]

Github user ijokarumawak commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1976#discussion_r126833370
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -467,6 +467,7 @@
 
src/test/resources/TestUpdateRecord/output/person-with-firstname.json
 
src/test/resources/TestUpdateRecord/output/person-with-firstname-lastname.json
 
src/test/resources/TestUpdateRecord/output/person-with-capital-lastname.json
+
src/test/resources/TestUpdateRecord/output/person-with-bool.json
--- End diff --

Thanks @mattyb149 , fixed this and confirmed RAT check passed locally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1976: NIFI-1613: Make use of column type correctly at Con...

[mattyb149]

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1976#discussion_r126673168
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -467,6 +467,7 @@
 
src/test/resources/TestUpdateRecord/output/person-with-firstname.json
 
src/test/resources/TestUpdateRecord/output/person-with-firstname-lastname.json
 
src/test/resources/TestUpdateRecord/output/person-with-capital-lastname.json
+
src/test/resources/TestUpdateRecord/output/person-with-bool.json
--- End diff --

This should be in the TestConvertJSONToSQL section rather than 
TestUpdateRecord, it causes a RAT failure


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1976: NIFI-1613: Make use of column type correctly at Con...

[ijokarumawak]

GitHub user ijokarumawak opened a pull request:

https://github.com/apache/nifi/pull/1976

NIFI-1613: Make use of column type correctly at ConvertJSONToSQL

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijokarumawak/nifi nifi-1613

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1976.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1976


commit 07ed78cd130c632f63e1357d2407f946e6f5f45a
Author: Toivo Adams 
Date:   2016-03-20T19:13:15Z

NIFI-1613 Initial version, try to improve conversion for different SQL 
types. New test and refactored existing test to reuse DBCP service.

nifi-1613 Adding numeric and Date/time types conversion and test.

commit 81e8391e3bc8e26413c0f1e38a41bc01b88159e1
Author: Koji Kawamura 
Date:   2017-07-05T05:49:32Z

NIFI-1613: ConvertJSONToSQL truncates numeric value wrongly.

- Changed boolean value conversion to use Boolean.valueOf.
- Updated comments in source code to reflect current situation more clearly.
- Updated tests those have been added since the original commits were made.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---