[GitHub] nifi pull request #2094: NIFI-4198 *ElasticsearchHttp processors do not expo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2094


---

[GitHub] nifi pull request #2094: NIFI-4198 *ElasticsearchHttp processors do not expo...

[arunma]

Github user arunma commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2094#discussion_r176272506
  
--- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchHttpProcessor.java
 ---
@@ -97,6 +116,27 @@
 
 private final AtomicReference 
okHttpClientAtomicReference = new AtomicReference<>();
 
+private static final List propertyDescriptors;
+
+static {
+final List properties = new ArrayList<>();
+properties.add(ES_URL);
--- End diff --

Thanks @mattyb149 - contrib_checks and testcases passes after rebasing the 
latest from master. Appreciate if you could have a quick look again, please.


---

[GitHub] nifi pull request #2094: NIFI-4198 *ElasticsearchHttp processors do not expo...

[mattyb149]

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2094#discussion_r176243205
  
--- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchHttpProcessor.java
 ---
@@ -97,6 +116,27 @@
 
 private final AtomicReference 
okHttpClientAtomicReference = new AtomicReference<>();
 
+private static final List propertyDescriptors;
+
+static {
+final List properties = new ArrayList<>();
+properties.add(ES_URL);
--- End diff --

I like them in the abstract class, but I believe they are also being added 
in some of the inherited processors IIRC. Also do you mind rebasing your PR 
against the latest master? There appear to be some merge conflicts. Please and 
thanks!


---

[GitHub] nifi pull request #2094: NIFI-4198 *ElasticsearchHttp processors do not expo...

[arunma]

Github user arunma commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2094#discussion_r176242220
  
--- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchHttpProcessor.java
 ---
@@ -97,6 +116,27 @@
 
 private final AtomicReference 
okHttpClientAtomicReference = new AtomicReference<>();
 
+private static final List propertyDescriptors;
+
+static {
+final List properties = new ArrayList<>();
+properties.add(ES_URL);
--- End diff --

Thanks @mattyb149 - I was not sure about what stand to make too.  I added 
them in the Abstract as a matter of convenience and to avoid duplication . 
Please let me know if you have any strong reservations, in which case, I'll go 
ahead and add it to all the inherited processors. 


---

[GitHub] nifi pull request #2094: NIFI-4198 *ElasticsearchHttp processors do not expo...

[mattyb149]

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2094#discussion_r149124819
  
--- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchHttpProcessor.java
 ---
@@ -97,6 +116,27 @@
 
 private final AtomicReference 
okHttpClientAtomicReference = new AtomicReference<>();
 
+private static final List propertyDescriptors;
+
+static {
+final List properties = new ArrayList<>();
+properties.add(ES_URL);
--- End diff --

Won't some of these be added twice, once by this abstract class and once by 
the individual processor? I like the idea of adding all common ones here, but I 
think they need to be removed from Fetch/PutESHttp


---

[GitHub] nifi pull request #2094: NIFI-4198 *ElasticsearchHttp processors do not expo...

[arunma]

GitHub user arunma opened a pull request:

https://github.com/apache/nifi/pull/2094

NIFI-4198 *ElasticsearchHttp processors do not expose Proxy settings

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arunma/nifi NIFI-4198_ES_Squashed

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2094


commit e4dd50eb1c9ac587c2a78d0dbccee6596e28067f
Author: Arun Manivannan 
Date:   2017-08-16T17:30:05Z

NIFI-4198 *ElasticsearchHttp processors do not expose Proxy settings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---