[GitHub] nifi pull request #2363: NIFI-4726: Avoid concurrency issues in JoltTransfor...

2018-01-09 Thread mgaido91 
Github user mgaido91 closed the pull request at:

https://github.com/apache/nifi/pull/2363


---

[GitHub] nifi pull request #2363: NIFI-4726: Avoid concurrency issues in JoltTransfor...

2018-01-08 Thread joewitt 
Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2363#discussion_r160315696
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JsonUtilsPool.java
 ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard.util;
+
+import com.bazaarvoice.jolt.JsonUtil;
+import com.bazaarvoice.jolt.JsonUtilImpl;
+import org.apache.commons.pool.PoolableObjectFactory;
+import org.apache.commons.pool.impl.GenericObjectPool;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class JsonUtilsPool {
+private final static Logger LOG = 
LoggerFactory.getLogger(JsonUtilsPool.class);
+static private GenericObjectPool pool;
--- End diff --

dont believe we would want a static pool instance.  We can just make the 
pool a member of the processor.


---

[GitHub] nifi pull request #2363: NIFI-4726: Avoid concurrency issues in JoltTransfor...

2017-12-29 Thread mgaido91 
GitHub user mgaido91 opened a pull request:

https://github.com/apache/nifi/pull/2363

NIFI-4726: Avoid concurrency issues in JoltTransformJSON

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? NA 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly? NA
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly? NA
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties? NA

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered? NA

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgaido91/nifi NIFI-4726

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2363


commit 5f938708b797f4894005ab16300585792d6f1da0
Author: mark91 
Date:   2017-12-28T16:14:32Z

NIFI-4726: Avoid concurrency issues in JoltTransformJSON




---