[GitHub] nifi pull request #2435: NIFI-4818: Fix transit URL parsing at Hive2JDBC and...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2435 ---
[GitHub] nifi pull request #2435: NIFI-4818: Fix transit URL parsing at Hive2JDBC and...
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2435#discussion_r164017503
--- Diff:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/NiFiAtlasHook.java
---
@@ -255,7 +255,11 @@ public void commitMessages() {
}
return new Tuple<>(refQualifiedName,
typedQualifiedNameToRef.get(toTypedQualifiedName(typeName, refQualifiedName)));
}).filter(Objects::nonNull).filter(tuple -> tuple.getValue() !=
null)
-.collect(Collectors.toMap(Tuple::getKey, Tuple::getValue));
+// If duplication happens, use new value.
+.collect(Collectors.toMap(Tuple::getKey, Tuple::getValue,
(oldValue, newValue) -> {
+logger.warn("Duplicated qualified name was found, use
the new one. oldValue={}, newValue={}", new Object[]{oldValue, newValue});
+return newValue;
+}));
--- End diff --
While I was testing, I got the following exception:
```
2018-01-25 05:06:41,430 ERROR [Timer-Driven Process Thread-1]
o.a.n.a.reporting.ReportLineageToAtlas
ReportLineageToAtlas[id=057986ae-0161-1000-d0b0-1b890a17f5aa] Error running
task ReportLineageToAtlas[id=057986ae-0161-1000-d0b0-1b890a17f5aa] due to
java.lang.IllegalStateException: Duplicate key {Id='(type: fs_path, id:
69be7a40-4ff8-4c4e-b714-2d394c14398d)', traits=[], values={}} NiFiAtlasHook.258
```
The exception means, an existing nifi_flow_path entity has more than one
entries having pointing to the same entity having identical qualified name,
from its inputs or outputs attribute. This happened because I was using the old
test environment which has data created before Atlas integration implemented
de-duplication logic. However, it would be more protective to handle such
duplication in case if this occurs for some other reason.
---
[GitHub] nifi pull request #2435: NIFI-4818: Fix transit URL parsing at Hive2JDBC and...
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/2435 NIFI-4818: Fix transit URL parsing at Hive2JDBC and KafkaTopic for Re⦠â¦portLineageToAtlas - Hive2JDBC: Handle connection parameters and multiple host entries correctly - KafkaTopic: Handle multiple host entries correctly - Avoid potential "IllegalStateException: Duplicate key" exception when NiFiAtlasHook analyzes existing NiFiFlowPath input/output entries Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijokarumawak/nifi nifi-4818 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2435.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2435 commit 91ee885398128e796918a6fc6b98bdf442c5ebf1 Author: Koji Kawamura Date: 2018-01-25T04:57:01Z NIFI-4818: Fix transit URL parsing at Hive2JDBC and KafkaTopic for ReportLineageToAtlas - Hive2JDBC: Handle connection parameters and multiple host entries correctly - KafkaTopic: Handle multiple host entries correctly - Avoid potential "IllegalStateException: Duplicate key" exception when NiFiAtlasHook analyzes existing NiFiFlowPath input/output entries ---
