[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3089 ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226055225 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank +|== + +NOTE: The ports marked with an asterisk (*) have property values that are blank by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. --- End diff -- Yup, will make _none_ in the tables. ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226053244 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank --- End diff -- As discussed in other comment threads, changing blank to _none_. ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226053061 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank +|== + +NOTE: The ports marked with an asterisk (*) have property values that are blank by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. + +=== Embedded Zookeeper +The following table lists the default ports used by an <> and the corresponding property in the _zookeeper.properties_ file. + +[options="header,footer"] +|== +| Function | Property | Default Value +|Zookeeper Client Port | `clientPort` | `2181` +|Zookeeper Server Quorum and Leader Election Ports | `server.1` | `localhost:2888:3888` --- End diff -- Thanks, will make this change also. ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226051004 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank +|== + +NOTE: The ports marked with an asterisk (*) have property values that are blank by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. + +=== Embedded Zookeeper +The following table lists the default ports used by an <> and the corresponding property in the _zookeeper.properties_ file. + +[options="header,footer"] +|== +| Function | Property | Default Value +|Zookeeper Client Port | `clientPort` | `2181` +|Zookeeper Server Quorum and Leader Election Ports | `server.1` | `localhost:2888:3888` --- End diff -- This looks good, with `blank` being changed to _`none`_. ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226048817 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank +|== + +NOTE: The ports marked with an asterisk (*) have property values that are blank by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. --- End diff -- `empty` is probably not correct here. It could imply an empty string, which would not be the case for a property set like `nifi.web.http.port.forwarding=` as it is by default in nifi.properties. `blank` is probably the better option to use in the descriptions, but maybe _`null`_ or _`none`_ in the port lists? ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226045546 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank +|== + +NOTE: The ports marked with an asterisk (*) have property values that are blank by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. + +=== Embedded Zookeeper +The following table lists the default ports used by an <> and the corresponding property in the _zookeeper.properties_ file. + +[options="header,footer"] +|== +| Function | Property | Default Value +|Zookeeper Client Port | `clientPort` | `2181` +|Zookeeper Server Quorum and Leader Election Ports | `server.1` | `localhost:2888:3888` --- End diff -- I see your point. We could change the table and following note to this: | Function | Property | Default Value |Zookeeper Client Port | `clientPort` | `2181` |Zookeeper Server Quorum and Leader Election Ports | `server.1` | blank NOTE: Commented examples for the Zookeeper server ports are included in the _zookeeper.properties_ file in the form server.N=nifi-nodeN-hostname:2888:3888. ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226042799 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank +|== + +NOTE: The ports marked with an asterisk (*) have property values that are blank by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. --- End diff -- Similar to comment above about "blank", but happy to make this change since it reads better. ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226042448 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank --- End diff -- I was thinking about that also, but figured "blank" would be OK since we reference this throughout the Admin Guide (e.g. "The default value is blank"). ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226036575 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank +|== + +NOTE: The ports marked with an asterisk (*) have property values that are blank by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. + +=== Embedded Zookeeper +The following table lists the default ports used by an <> and the corresponding property in the _zookeeper.properties_ file. + +[options="header,footer"] +|== +| Function | Property | Default Value +|Zookeeper Client Port | `clientPort` | `2181` +|Zookeeper Server Quorum and Leader Election Ports | `server.1` | `localhost:2888:3888` --- End diff -- In zookeeper.properties, the default values are commented: ```properties # server.1=nifi-node1-hostname:2888:3888 # server.2=nifi-node2-hostname:2888:3888 # server.3=nifi-node3-hostname:2888:3888 ``` Technically this means that the default values for `server.1` to `server.N` are empty. The note below references that examples are commented out, which is good, but I think the port list should indicate that the `server.N` properties are empty by default. ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226037655 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank +|== + +NOTE: The ports marked with an asterisk (*) have property values that are blank by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. --- End diff -- ```suggestion NOTE: The ports marked with an asterisk (*) have property values that are empty by default in _nifi.properties_. The values shown in the table are the default values for these ports when <> is used to generate _nifi.properties_ for a secured NiFi instance. The default Certificate Authority Port used by TLS Toolkit is `8443`. ``` ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226037414 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories are created: See the <> section of this guide for more information about configuring NiFi repositories and configuration files. +== Port Configuration + +=== NiFi +The following table lists the default ports used by NiFi and the corresponding property in the _nifi.properties_ file. + +[options="header,footer"] +|== +| Function| Property | Default Value +|HTTP Port| `nifi.web.http.port` | `8080` +|HTTPS Port* | `nifi.web.https.port` | `9443` +|Remote Input Socket Port*| `nifi.remote.input.socket.port` | `10443` +|Cluster Node Protocol Port* | `nifi.cluster.node.protocol.port` | `11443` +|Cluster Node Load Balancing Port | `nifi.cluster.node.load.balance.port` | `6342` +|Web HTTP Forwarding Port | `nifi.web.http.port.forwarding` | blank --- End diff -- Can we represent no default value here other than "blank"? ---
[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...
GitHub user andrewmlim opened a pull request: https://github.com/apache/nifi/pull/3089 NIFI-5653 Added default NiFi and Embedded Zookeeper port tables to Ad⦠â¦min Guide Also added a new referenced tag/anchor for TLS Generation Toolkit section and removed an unnecessary NOTE. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrewmlim/nifi NIFI-5653 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3089.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3089 commit 56281924149503e84117dc377d94490f953c99f2 Author: Andrew Lim Date: 2018-10-17T17:43:39Z NIFI-5653 Added default NiFi and Embedded Zookeeper port tables to Admin Guide ---
