[GitHub] nifi pull request #620: [NIFI-2147] Fix Warning/Invalid roll-over text

[scottyaslan]

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/620#discussion_r70257739
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js
 ---
@@ -1328,9 +1328,9 @@
 var tooltip = 
nf.Common.formatPropertyTooltip(propertyDescriptor, propertyHistory);
 
 if (nf.Common.isDefinedAndNotNull(tooltip)) {
-infoIcon.qtip($.extend({
-content: tooltip,
-}, nf.Common.config.tooltipConfig));
+infoIcon.qtip($.extend(nf.Common.config.tooltipConfig, 
{
--- End diff --

Ok, nice catch @mcgilman... I have updated all the modified $.extend to 
create a new object `{}`, extend it with any nf.Common.config.tooltip*, and 
then extend that with any additional objects to achieve the desired object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #620: [NIFI-2147] Fix Warning/Invalid roll-over text

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/620#discussion_r70240401
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js
 ---
@@ -1328,9 +1328,9 @@
 var tooltip = 
nf.Common.formatPropertyTooltip(propertyDescriptor, propertyHistory);
 
 if (nf.Common.isDefinedAndNotNull(tooltip)) {
-infoIcon.qtip($.extend({
-content: tooltip,
-}, nf.Common.config.tooltipConfig));
+infoIcon.qtip($.extend(nf.Common.config.tooltipConfig, 
{
--- End diff --

@scottyaslan - If you checkout the description of $.extend [1] it shows the 
first argument is the target meaning that is what object that is being 
modified/updated. I don't we want to be modifying the tooltip configuration 
template like we are here as it will affect all subsequent $.extend calls. 

This applies to all of modified $.extend lines in this PR.

[1] https://api.jquery.com/jquery.extend/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---