Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]

[via GitHub]

mcgilman merged PR #8714:
URL: https://github.com/apache/nifi/pull/8714


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]

[via GitHub]

scottyaslan commented on PR #8714:
URL: https://github.com/apache/nifi/pull/8714#issuecomment-2087872530

   @mcgilman Thanks for the review. I have rebased with latest main. Please 
merge once CI is green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]

[via GitHub]

scottyaslan commented on code in PR #8714:
URL: https://github.com/apache/nifi/pull/8714#discussion_r1585182484


##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -354,8 +353,9 @@
 }
 
 .property-editor {
-background-color: $nifi-theme-surface-palette-darker;
-box-shadow: 0 2px 5px rgba(0, 0, 0, 0.25);
+background-color: var(--mat-menu-container-color);
+box-shadow: 0 3px 6px rgba(0, 0, 0, 0.25);
+border-radius: 4px;

Review Comment:
   Good catch. I have updated it to be positioned like the other resized 
handles:
   
   ![Screenshot 2024-04-30 at 12 38 29 
PM](https://github.com/apache/nifi/assets/6797571/ce62ade5-721c-4599-a582-49af20cd4aff)
   
   ![Screenshot 2024-04-30 at 12 37 55 
PM](https://github.com/apache/nifi/assets/6797571/78563995-a128-4d3d-9b88-3906141fd79f)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]

[via GitHub]

scottyaslan commented on code in PR #8714:
URL: https://github.com/apache/nifi/pull/8714#discussion_r1585182484


##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -354,8 +353,9 @@
 }
 
 .property-editor {
-background-color: $nifi-theme-surface-palette-darker;
-box-shadow: 0 2px 5px rgba(0, 0, 0, 0.25);
+background-color: var(--mat-menu-container-color);
+box-shadow: 0 3px 6px rgba(0, 0, 0, 0.25);
+border-radius: 4px;

Review Comment:
   Good catch. I have updated it to be positioned like the other resized 
handles:
   ![Screenshot 2024-04-30 at 12 37 55 
PM](https://github.com/apache/nifi/assets/6797571/78563995-a128-4d3d-9b88-3906141fd79f)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]

[via GitHub]

mcgilman commented on code in PR #8714:
URL: https://github.com/apache/nifi/pull/8714#discussion_r1584783617


##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -354,8 +353,9 @@
 }
 
 .property-editor {
-background-color: $nifi-theme-surface-palette-darker;
-box-shadow: 0 2px 5px rgba(0, 0, 0, 0.25);
+background-color: var(--mat-menu-container-color);
+box-shadow: 0 3px 6px rgba(0, 0, 0, 0.25);
+border-radius: 4px;

Review Comment:
   The resize handle is rendered on top of the bottom right corner. We may want 
to consider updates there now that the modal uses a larger border radius.
   
   ![Screenshot 2024-04-30 at 8 58 54 
AM](https://github.com/apache/nifi/assets/123395/4c8fd1a2-c0e7-415a-8bc6-5b33f443a97d)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]

[via GitHub]

mcgilman commented on PR #8714:
URL: https://github.com/apache/nifi/pull/8714#issuecomment-2085249099

   Will review...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org