Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2024-01-02 Thread via GitHub 


arpadboda closed pull request #1709: MINIFICPP-2274 Ship Markdown docs in 
binary packages
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2023-12-14 Thread via GitHub 


szaszm commented on code in PR #1709:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1426440875


##
CMakeLists.txt:
##
@@ -422,8 +422,12 @@ if(WIN32)
 
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}/conf/")
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
-file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
+#file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")

Review Comment:
   removed the line in 
[13090d3](https://github.com/apache/nifi-minifi-cpp/pull/1709/commits/13090d370c39c1713add87d037cb388b3d8b4307)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2023-12-13 Thread via GitHub 


szaszm commented on code in PR #1709:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1426258158


##
CMakeLists.txt:
##
@@ -422,8 +422,12 @@ if(WIN32)
 
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}/conf/")
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
-file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
+#file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")

Review Comment:
   I guess the thinking behind this was that if this is ever changed, the 
README needs special handling. But I can certainly just remove the line, I 
don't really have a strong argument against it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2023-12-13 Thread via GitHub 


martinzink commented on code in PR #1709:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1425873524


##
CMakeLists.txt:
##
@@ -422,8 +422,12 @@ if(WIN32)
 
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}/conf/")
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
-file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
+#file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")

Review Comment:
   Why the comment, should we just remove this line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2023-12-13 Thread via GitHub 


szaszm opened a new pull request, #1709:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709

   
https://apachenifi.slack.com/archives/CDF1VC1UZ/p1702055532245309?thread_ts=1702050961.615049=CDF1VC1UZ
   
   ---
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [x] Does your PR title start with MINIFICPP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] If applicable, have you updated the LICENSE file?
   - [x] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI 
results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org