Re: [PR] MINIFICPP-2324 Make start after install optional [nifi-minifi-cpp]

2024-04-11 Thread via GitHub


szaszm closed pull request #1754: MINIFICPP-2324 Make start after install 
optional
URL: https://github.com/apache/nifi-minifi-cpp/pull/1754


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] MINIFICPP-2324 Make start after install optional [nifi-minifi-cpp]

2024-04-08 Thread via GitHub


fgerlits opened a new pull request, #1754:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1754

   In the Windows installer (msi), add a new checkbox, enabled by default, to 
control whether the service will be started at the end of the installation. To 
disable auto-start from the command line, use the `AUTOSTART=""` property in 
the `msiexec.exe` command.
   
   https://issues.apache.org/jira/browse/MINIFICPP-2324
   
   ---
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [x] Does your PR title start with MINIFICPP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI 
results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org