Re: [PR] MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined [nifi-minifi-cpp]
szaszm closed pull request #1774: MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined URL: https://github.com/apache/nifi-minifi-cpp/pull/1774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined [nifi-minifi-cpp]
lordgamez commented on code in PR #1774: URL: https://github.com/apache/nifi-minifi-cpp/pull/1774#discussion_r1585105439 ## CMakeLists.txt: ## @@ -25,6 +25,10 @@ cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted conten project(nifi-minifi-cpp VERSION 0.99.0) set(PROJECT_NAME "nifi-minifi-cpp") +if (NOT CMAKE_BUILD_TYPE) +set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Built type" FORCE) Review Comment: Fixed in d820cad82ffc9c44fbe2a34d1ad6ad6d8a9b013d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined [nifi-minifi-cpp]
szaszm commented on code in PR #1774: URL: https://github.com/apache/nifi-minifi-cpp/pull/1774#discussion_r1585102353 ## CMakeLists.txt: ## @@ -25,6 +25,10 @@ cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted conten project(nifi-minifi-cpp VERSION 0.99.0) set(PROJECT_NAME "nifi-minifi-cpp") +if (NOT CMAKE_BUILD_TYPE) +set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Built type" FORCE) Review Comment: ```suggestion set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Build type" FORCE) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined [nifi-minifi-cpp]
lordgamez opened a new pull request, #1774: URL: https://github.com/apache/nifi-minifi-cpp/pull/1774 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
