[PR] NIFI-12420: Add Sawmill transformation processors [nifi]
mattyb149 opened a new pull request, #8071: URL: https://github.com/apache/nifi/pull/8071 # Summary [NIFI-12420](https://issues.apache.org/jira/browse/NIFI-12420) This PR offers the SawmillTransformJSON and SawmillTransformRecord processors, using the Sawmill library to transform input. Couple of questions for the reviewer(s): - The NAR is 9.3 MB, should this be a profile disabled by default? - The SawmillTransformJSON processor is faster for JSON input/output, but is it useful enough to include? - There is a Guava override to eliminate vulnerabilities, seems to work fine but would like to confirm? # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
EndzeitBegins commented on PR #8071: URL: https://github.com/apache/nifi/pull/8071#issuecomment-1830387906 If I remember correctly, there have been issues with the size of the default distribution of NiFi in the past. As the Sawmill nar seems to include a fair amount of dependencies, I advocate for a separate nar, not included in the default distribution, in case the processors should be merged into the codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
joewitt commented on PR #8071: URL: https://github.com/apache/nifi/pull/8071#issuecomment-1866715722 I'd avoid adding to default build for now. I also think the dependencies need further review from a L&N point of view. The L&N is updated but seems pretty light compared to the deps involved here. Are we sure we checked? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
exceptionfactory commented on PR #8071: URL: https://github.com/apache/nifi/pull/8071#issuecomment-1866753429 As mentioned earlier, I'm hesitant on bringing in this component and bundle, even optionally, given the number of outdated dependencies. These findings still show up in reviews, even if not included in standard convenience binaries. It may be possible to address the old dependencies through overrides, but that is something that should be evaluated first, before going forward. If we can override old dependencies, then it seems like we would be in a better place to consider bringing this into the repository as an optional module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
mattyb149 commented on PR #8071: URL: https://github.com/apache/nifi/pull/8071#issuecomment-1896626703 Closing this as it isn't a good fit as a NiFi processor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12420: Add Sawmill transformation processors [nifi]
mattyb149 closed pull request #8071: NIFI-12420: Add Sawmill transformation processors URL: https://github.com/apache/nifi/pull/8071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
