Re: [PR] NIFI-13139 ensure nifi-py4j-nar is included in test assembly [nifi]

2024-05-06 Thread via GitHub 


asfgit closed pull request #8747: NIFI-13139 ensure nifi-py4j-nar is included 
in test assembly
URL: https://github.com/apache/nifi/pull/8747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] NIFI-13139 ensure nifi-py4j-nar is included in test assembly [nifi]

2024-05-05 Thread via GitHub 


joewitt commented on PR #8747:
URL: https://github.com/apache/nifi/pull/8747#issuecomment-2094954148

   Also fixed nifi-py4j-integration-tests which needed logback libs after the 
logback dependency in nifi-py4j-bridge was added.  Also set one of the tests to 
disabled so it can be run manually.  It expects a virtual env it seems.  
Verified the python processor in that test runs fine in a real nifi.
   
   Can we enable the nifi-py4j-integration-tests in the ci builds?
   
   anyway this commit as-is is ready to go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] NIFI-13139 ensure nifi-py4j-nar is included in test assembly [nifi]

2024-05-04 Thread via GitHub 


joewitt opened a new pull request, #8747:
URL: https://github.com/apache/nifi/pull/8747

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-13139](https://issues.apache.org/jira/browse/NIFI-13139)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### UI Contributions
   
   - [ ] NiFi is modernizing its UI. Any contributions that update the [current 
UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui)
 also need to be implemented in the [new 
UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi).
  
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org