Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
briansolo1985 closed pull request #: NIFI-13309 Lookup compatible bundles even if previous flow was empty URL: https://github.com/apache/nifi/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
briansolo1985 commented on PR #: URL: https://github.com/apache/nifi/pull/#issuecomment-2137473601 Thanks for submitting the change and incorporating the suggestions. +1 from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
ferencerdei commented on code in PR #:
URL: https://github.com/apache/nifi/pull/#discussion_r1618793587
##
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##
@@ -257,6 +257,10 @@ private void mapCompatibleBundles(final DataFlow
proposedFlow, final ExtensionMa
final Set missingComponentIds =
proposedFlow.getMissingComponents();
final VersionedDataflow dataflow = proposedFlow.getVersionedDataflow();
+if (dataflow == null) {
Review Comment:
changed it to use the recommended method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
simonbence commented on code in PR #:
URL: https://github.com/apache/nifi/pull/#discussion_r1618732933
##
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##
@@ -257,6 +257,10 @@ private void mapCompatibleBundles(final DataFlow
proposedFlow, final ExtensionMa
final Set missingComponentIds =
proposedFlow.getMissingComponents();
final VersionedDataflow dataflow = proposedFlow.getVersionedDataflow();
+if (dataflow == null) {
Review Comment:
I propose the usage of the `isFlowEmpty`method here, which covers more
possible variations for an empty `dataFlow`. I tested it via standard NiFi and
it worked properly during initial startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
ferencerdei opened a new pull request, #: URL: https://github.com/apache/nifi/pull/ # Summary [NIFI-13309](https://issues.apache.org/jira/browse/NIFI-13309) This change modifies the VersionedFlowSyncronizer to call mapCompatibleBundles even if the original flow was empty. An additional null check was added to the proposed dataFlow instead to prevent exception during NiFi startup. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
