[jira] [Commented] (MINIFICPP-217) Fix issues in BinFiles as a result of merge

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188350#comment-16188350
 ] 

ASF GitHub Bot commented on MINIFICPP-217:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/140


> Fix issues in BinFiles as a result of merge 
> 
>
> Key: MINIFICPP-217
> URL: https://issues.apache.org/jira/browse/MINIFICPP-217
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
> Fix For: 0.3.0
>
>
> Fix issues in BinFiles as a result of merge 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-217) Fix issues in BinFiles as a result of merge

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188348#comment-16188348
 ] 

ASF GitHub Bot commented on MINIFICPP-217:
--

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/140
  
Looks good here, thanks for fixing and will get this merged in.


> Fix issues in BinFiles as a result of merge 
> 
>
> Key: MINIFICPP-217
> URL: https://issues.apache.org/jira/browse/MINIFICPP-217
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>
> Fix issues in BinFiles as a result of merge 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-217) Fix issues in BinFiles as a result of merge

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188340#comment-16188340
 ] 

ASF GitHub Bot commented on MINIFICPP-217:
--

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/140
  
will review.  definitely forgot to rebase before doing that last one and 
missed it prior. 


> Fix issues in BinFiles as a result of merge 
> 
>
> Key: MINIFICPP-217
> URL: https://issues.apache.org/jira/browse/MINIFICPP-217
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>
> Fix issues in BinFiles as a result of merge 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-217) Fix issues in BinFiles as a result of merge

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188334#comment-16188334
 ] 

ASF GitHub Bot commented on MINIFICPP-217:
--

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/140

MINIFICPP-217: Resolve compilation failures within Bin files and merg…

…e files test

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-217

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit dbc103deb41b6236b44a0931f8c32549cafc9076
Author: Marc Parisi 
Date:   2017-10-02T15:36:52Z

MINIFICPP-217: Resolve compilation failures within Bin files and merge 
files test




> Fix issues in BinFiles as a result of merge 
> 
>
> Key: MINIFICPP-217
> URL: https://issues.apache.org/jira/browse/MINIFICPP-217
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>
> Fix issues in BinFiles as a result of merge 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)