[jira] [Commented] (MINIFICPP-331) Implement string replacement functions in Expression Language
[ https://issues.apache.org/jira/browse/MINIFICPP-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327449#comment-16327449 ] ASF GitHub Bot commented on MINIFICPP-331: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/226 > Implement string replacement functions in Expression Language > - > > Key: MINIFICPP-331 > URL: https://issues.apache.org/jira/browse/MINIFICPP-331 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Implement these in EL: > replace > replaceFirst > replaceAll > replaceNull > replaceEmpty -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-331) Implement string replacement functions in Expression Language
[ https://issues.apache.org/jira/browse/MINIFICPP-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327430#comment-16327430 ] ASF GitHub Bot commented on MINIFICPP-331: -- Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/226 @achristianson Seems good. It looks like the failing build succeeded. Thanks > Implement string replacement functions in Expression Language > - > > Key: MINIFICPP-331 > URL: https://issues.apache.org/jira/browse/MINIFICPP-331 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Implement these in EL: > replace > replaceFirst > replaceAll > replaceNull > replaceEmpty -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-331) Implement string replacement functions in Expression Language
[ https://issues.apache.org/jira/browse/MINIFICPP-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327359#comment-16327359 ] ASF GitHub Bot commented on MINIFICPP-331: -- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/226 Put in blacklist of GCC < 4.9.0 for EL regex functions. Will add this limitation/caveat to the minificpp EL docs (to be added with MINIFICPP-366). > Implement string replacement functions in Expression Language > - > > Key: MINIFICPP-331 > URL: https://issues.apache.org/jira/browse/MINIFICPP-331 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Implement these in EL: > replace > replaceFirst > replaceAll > replaceNull > replaceEmpty -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-331) Implement string replacement functions in Expression Language
[ https://issues.apache.org/jira/browse/MINIFICPP-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327360#comment-16327360 ] ASF GitHub Bot commented on MINIFICPP-331: -- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/226 @phrocker ready for re-review. > Implement string replacement functions in Expression Language > - > > Key: MINIFICPP-331 > URL: https://issues.apache.org/jira/browse/MINIFICPP-331 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Implement these in EL: > replace > replaceFirst > replaceAll > replaceNull > replaceEmpty -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-331) Implement string replacement functions in Expression Language
[ https://issues.apache.org/jira/browse/MINIFICPP-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308392#comment-16308392 ] ASF GitHub Bot commented on MINIFICPP-331: -- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/226 Looks like the 4.8.5 version doesn't have complete support for that level of regex. I'm assuming we don't want to add BOOST, either, so we may not be able to support certain regex types on old GCC. > Implement string replacement functions in Expression Language > - > > Key: MINIFICPP-331 > URL: https://issues.apache.org/jira/browse/MINIFICPP-331 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > Implement these in EL: > replace > replaceFirst > replaceAll > replaceNull > replaceEmpty -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MINIFICPP-331) Implement string replacement functions in Expression Language
[ https://issues.apache.org/jira/browse/MINIFICPP-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300356#comment-16300356 ] ASF GitHub Bot commented on MINIFICPP-331: -- GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/226 MINIFICPP-331 Implemented string replacement functions Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-331 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/226.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #226 commit 1cfa0181c7a1ad4f26fb06cc554e76b57c91039c Author: Andy I. Christianson Date: 2017-12-21T17:46:36Z MINIFICPP-331 Implemented string replacement functions > Implement string replacement functions in Expression Language > - > > Key: MINIFICPP-331 > URL: https://issues.apache.org/jira/browse/MINIFICPP-331 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson > > Implement these in EL: > replace > replaceFirst > replaceAll > replaceNull > replaceEmpty -- This message was sent by Atlassian JIRA (v6.4.14#64029)
