[jira] [Commented] (MINIFICPP-392) DockerBuild should copy dirs based on a black list vs a white list to avoid missing copied directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466425#comment-16466425
 ] 

ASF GitHub Bot commented on MINIFICPP-392:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/320


> DockerBuild should copy dirs based on a black list vs a white list to avoid 
> missing copied directories
> --
>
> Key: MINIFICPP-392
> URL: https://issues.apache.org/jira/browse/MINIFICPP-392
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: marco polo
>Assignee: Andrew Christianson
>Priority: Minor
> Fix For: 0.5.0
>
>
> See Convo from [https://github.com/apache/nifi-minifi-cpp/pull/253] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-392) DockerBuild should copy dirs based on a black list vs a white list to avoid missing copied directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464156#comment-16464156
 ] 

ASF GitHub Bot commented on MINIFICPP-392:
--

GitHub user achristianson opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/320

MINIFICPP-392 Switched to black list for copying src tree to avoid mi…

…ssing newly-added dirs

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [x] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-392

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #320


commit e5132fac9b1b471db7d35dc3823d245ad0abc8e4
Author: Andrew I. Christianson 
Date:   2018-05-04T17:17:18Z

MINIFICPP-392 Switched to black list for copying src tree to avoid missing 
newly-added dirs




> DockerBuild should copy dirs based on a black list vs a white list to avoid 
> missing copied directories
> --
>
> Key: MINIFICPP-392
> URL: https://issues.apache.org/jira/browse/MINIFICPP-392
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: marco polo
>Assignee: Andrew Christianson
>Priority: Minor
> Fix For: 0.5.0
>
>
> See Convo from [https://github.com/apache/nifi-minifi-cpp/pull/253] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-392) DockerBuild should copy dirs based on a black list vs a white list to avoid missing copied directories

[marco polo (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349097#comment-16349097
 ] 

marco polo commented on MINIFICPP-392:
--

We can move the version if there isn't time for 0.5.0 since the priority is 
pretty low on this one. 

> DockerBuild should copy dirs based on a black list vs a white list to avoid 
> missing copied directories
> --
>
> Key: MINIFICPP-392
> URL: https://issues.apache.org/jira/browse/MINIFICPP-392
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: marco polo
>Assignee: Andrew Christianson
>Priority: Minor
> Fix For: 0.5.0
>
>
> See Convo from [https://github.com/apache/nifi-minifi-cpp/pull/253] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)