[jira] [Commented] (MINIFICPP-456) Docker build currently broken for master

2018-04-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MINIFICPP-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444991#comment-16444991
 ] 

ASF GitHub Bot commented on MINIFICPP-456:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/303


> Docker build currently broken for master
> 
>
> Key: MINIFICPP-456
> URL: https://issues.apache.org/jira/browse/MINIFICPP-456
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Affects Versions: 0.5.0
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.5.0
>
>
> The docker build is currently not working against master (commit: 
> ea6bc178cf63d7436f44fd3f814e7a1c1422ec18, applied 11 April)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-456) Docker build currently broken for master

2018-04-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MINIFICPP-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444815#comment-16444815
 ] 

ASF GitHub Bot commented on MINIFICPP-456:
--

GitHub user apiri opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/303

MINIFICPP-456 Including signal.h to resolve build issues for 
SecureSocketGetTCPTest

MINIFICPP-456 Including signal.h to resolve build issues for 
SecureSocketGetTCPTest in Alpine environments.

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apiri/nifi-minifi-cpp MINIFICPP-456

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #303


commit fde705c565f4f421b52ba07779ea69dfc5f8b952
Author: Aldrin Piri 
Date:   2018-04-19T21:16:01Z

MINIFICPP-456 Including signal.h to resolve build issues for 
SecureSocketGetTCPTest in Alpine environments.




> Docker build currently broken for master
> 
>
> Key: MINIFICPP-456
> URL: https://issues.apache.org/jira/browse/MINIFICPP-456
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Affects Versions: 0.5.0
>Reporter: Aldrin Piri
>Priority: Major
> Fix For: 0.5.0
>
>
> The docker build is currently not working against master (commit: 
> ea6bc178cf63d7436f44fd3f814e7a1c1422ec18, applied 11 April)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)