[
https://issues.apache.org/jira/browse/MINIFICPP-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463057#comment-16463057
]
ASF GitHub Bot commented on MINIFICPP-481:
--
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/319
MINIFICPP-481: Update agent to exit gracefully with an invalid *repo dir
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-481
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/319.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #319
commit 7b9885178122259d4ee0aa6caec16535d070e28b
Author: Marc Parisi
Date: 2018-05-03T21:01:18Z
MINIFICPP-481: Update agent to exit gracefully with an invalid *repo dir
> Failed repository creation should not result in seg fault
> -
>
> Key: MINIFICPP-481
> URL: https://issues.apache.org/jira/browse/MINIFICPP-481
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> When a repository isn't created we should exit gracefully and print something
> to the command line about why we are exiting. A log is created but this isn't
> sufficient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
