[jira] [Commented] (MINIFICPP-502) Support required processor properties
[ https://issues.apache.org/jira/browse/MINIFICPP-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489456#comment-16489456 ] ASF GitHub Bot commented on MINIFICPP-502: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/334 > Support required processor properties > - > > Key: MINIFICPP-502 > URL: https://issues.apache.org/jira/browse/MINIFICPP-502 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Allow developers to specify properties as required, and validate this in the > configuration reader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-502) Support required processor properties
[ https://issues.apache.org/jira/browse/MINIFICPP-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484004#comment-16484004 ] ASF GitHub Bot commented on MINIFICPP-502: -- Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/334 Fixed the linter issue. > Support required processor properties > - > > Key: MINIFICPP-502 > URL: https://issues.apache.org/jira/browse/MINIFICPP-502 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Allow developers to specify properties as required, and validate this in the > configuration reader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-502) Support required processor properties
[
https://issues.apache.org/jira/browse/MINIFICPP-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484003#comment-16484003
]
ASF GitHub Bot commented on MINIFICPP-502:
--
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189913737
--- Diff: libminifi/include/core/Property.h ---
@@ -56,10 +56,15 @@ class Property {
/*!
* Create a new property
*/
- Property(const std::string name, const std::string description, const
std::string value, bool is_required)
--- End diff --
Yeah MINIFICPP-502 is to perform validation. MINIFICPP-501 is for
incorporating the validation metadata into the agent info.
> Support required processor properties
> -
>
> Key: MINIFICPP-502
> URL: https://issues.apache.org/jira/browse/MINIFICPP-502
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
>
> Allow developers to specify properties as required, and validate this in the
> configuration reader.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-502) Support required processor properties
[ https://issues.apache.org/jira/browse/MINIFICPP-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483254#comment-16483254 ] ASF GitHub Bot commented on MINIFICPP-502: -- Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/334 501 is a subset of 502. Is that correct? If so I'll review 502. The same comments apply here > Support required processor properties > - > > Key: MINIFICPP-502 > URL: https://issues.apache.org/jira/browse/MINIFICPP-502 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Allow developers to specify properties as required, and validate this in the > configuration reader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-502) Support required processor properties
[
https://issues.apache.org/jira/browse/MINIFICPP-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483246#comment-16483246
]
ASF GitHub Bot commented on MINIFICPP-502:
--
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189748104
--- Diff: libminifi/include/core/Property.h ---
@@ -56,10 +56,15 @@ class Property {
/*!
* Create a new property
*/
- Property(const std::string name, const std::string description, const
std::string value, bool is_required)
--- End diff --
What's the purpose of this ticket? is_required already existed...
> Support required processor properties
> -
>
> Key: MINIFICPP-502
> URL: https://issues.apache.org/jira/browse/MINIFICPP-502
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
>
> Allow developers to specify properties as required, and validate this in the
> configuration reader.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-502) Support required processor properties
[ https://issues.apache.org/jira/browse/MINIFICPP-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483244#comment-16483244 ] ASF GitHub Bot commented on MINIFICPP-502: -- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189747932 --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp --- @@ -666,10 +669,10 @@ void YamlConfiguration::parsePortYaml(YAML::Node *portNode, checkRequiredField(, "id", CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY, "The field 'id' is required for " - "the port named '" + nameStr + "' in the YAML Config. If this port " --- End diff -- There are linter failures. We have a formatter that can be used with intellij with a little work. May help avoid some of these issues. You're making changes that override our formatter. Would probably behoove us to apply formatters as a pre commit hook. > Support required processor properties > - > > Key: MINIFICPP-502 > URL: https://issues.apache.org/jira/browse/MINIFICPP-502 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > > Allow developers to specify properties as required, and validate this in the > configuration reader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
