[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646965#comment-16646965
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2994
  
Thanks for the PR @ekovacs! This looks good to me. I found a couple of 
minor typos but just fixed before pushing. Was able to test and verify behavior 
and code looks great. +1 merged to master.


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>Assignee: Endre Kovacs
>Priority: Major
> Fix For: 1.8.0
>
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646964#comment-16646964
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2994


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>Assignee: Endre Kovacs
>Priority: Major
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641675#comment-16641675
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user ekovacs commented on the issue:

https://github.com/apache/nifi/pull/2994
  
bringing in adjustments from sibling pull request (NIFI-3469) suggested by 
@ijokarumawak 


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>Assignee: Endre Kovacs
>Priority: Major
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635315#comment-16635315
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user ekovacs commented on the issue:

https://github.com/apache/nifi/pull/2994
  
@jtstorck @joewitt @mcgilman @YolandaMDavis could you please take a look?


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>Assignee: Endre Kovacs
>Priority: Major
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605997#comment-16605997
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user ekovacs commented on the issue:

https://github.com/apache/nifi/pull/2994
  
@jtstorck  @joewitt @mcgilman could any of you please take a look?


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>Assignee: Endre Kovacs
>Priority: Major
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605971#comment-16605971
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

GitHub user ekovacs opened a pull request:

https://github.com/apache/nifi/pull/2994

NIFI-1490: multipart/form-data support for ListenHTTP processor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekovacs/nifi NIFI-1490

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2994.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2994


commit b32dd8b98ed39c7f17a069b351c6710e16d82791
Author: Endre Zoltan Kovacs 
Date:   2018-09-06T15:33:33Z

NIFI-1490: multipart/form-data support for ListenHTTP processor




> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>Priority: Major
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296612#comment-16296612
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user pipern commented on the issue:

https://github.com/apache/nifi/pull/1795
  
Do you think it's worth it @joewitt , since maybe this PR should be 
rejected and someone works on ExtractMultiPartHttp instead? (I'd like to, but 
can't commit to it. Maybe over Christmas...)

The decision of ExtractMultiPartHttp vs. an extracting-ListenHTTP maybe 
comes down to how we want errors send back to the client. If we want to be able 
to tell the HTTP client that their MultiPart was not well-formed, we'd have to 
do it in ListenHTTP, right? (Which potentially invalidates my first paragraph.)


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286252#comment-16286252
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1795
  
@pipern Do you mind rebasing and pushing the latest ?

Apologies for this falling through the review cracks.  If anyone has time 
soon please do take a look/test.


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[Michael Moser (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145310#comment-16145310
 ] 

Michael Moser commented on NIFI-1490:
-

+1 to the separate processor to handle multipart/form-data, so that both 
ListenHTTP and HandleHttpRequest (see NIFI-3469) can be used to receive data.

> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022640#comment-16022640
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user pipern commented on the issue:

https://github.com/apache/nifi/pull/1795
  
Thanks for taking a look @joewitt .

The old behaviour is persisted if _Multipart part name pattern_ property is 
not set (and not set is the default.)

The current implementation in this PR does only grab the first matching 
Part. It's an obvious next step to grab all matching parts, and indeed, maybe 
it's better to wait and improve this before merging, so that the behaviour 
doesn't change later. The implementation in the PR meets our own need, so 
unsure if we'll get chance to revisit and make the improvement soon.

I can also imagine an implementation which puts some parts into content, 
and some parts into attributes. Maybe a step towards that is, building on the 
current PR, to:
* Rename _Multipart part name pattern_ as _Multipart file part name 
pattern_ (and then generate several flowfiles, one for each matching part)
* Add _Multipart attribute part name pattern_ (and then, for each otherwise 
generated flowfile, put these parts as attributes)

> ExtractMultiPartHttp for example could take as input the entire request 
body in a flowfile that came from ListenHTTP and this new processor could 
create child objects which are each of the parts.

This would also need the ContentType header to be kept by the ListenHTTP 
(which it can do.)


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[David Patterson (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022368#comment-16022368
 ] 

David Patterson commented on NIFI-1490:
---

Great to see this feature progressing. It would be helpful if you could name 
form fields to be  used as flow file attributes in the processor config. 

> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022280#comment-16022280
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1795
  
hello @pipern.  Thanks for contributing.  If i'm reading this right it 
looks like what this will do is grab the first matching section of a multi-part 
request.  The current behavior before the patch would be to, i believe, grab 
all of the request as the flow file content.  Given that, it seems like rather 
than altering this processor to grab just the first match we'd either want to 
alter it to grab each section as new flow files OR perhaps better yet have a 
different processor which understands how to extract out the specific parts 
into individual flowfiles.  ExtractMultiPartHttp for example could take as 
input the entire request body in a flowfile that came from ListenHTTP and this 
new processor could create child objects which are each of the parts.

What do you think about that?


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010031#comment-16010031
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

Github user pipern commented on the issue:

https://github.com/apache/nifi/pull/1795
  
Unfortunately appveyor test is failing - 
https://ci.appveyor.com/project/ApacheSoftwareFoundation/nifi/build/1.0.0-SNAPSHOT-5108

I don't think it appears related:
```

Running org.wali.TestMinimalLockingWriteAheadLog
Tests run: 12, Failures: 0, Errors: 1, Skipped: 2, Time elapsed: 2.828 sec 
<<< FAILURE! - in org.wali.TestMinimalLockingWriteAheadLog

testRecoverFileThatHasTrailingNULBytesAndTruncation(org.wali.TestMinimalLockingWriteAheadLog)
  Time elapsed: 0 sec  <<< ERROR!
java.nio.channels.OverlappingFileLockException: null
at sun.nio.ch.SharedFileLockTable.checkList(FileLockTable.java:255)
at sun.nio.ch.SharedFileLockTable.add(FileLockTable.java:152)
at sun.nio.ch.FileChannelImpl.lock(FileChannelImpl.java:1063)
at java.nio.channels.FileChannel.lock(FileChannel.java:1053)
at 
org.wali.MinimalLockingWriteAheadLog.(MinimalLockingWriteAheadLog.java:187)
at 
org.wali.MinimalLockingWriteAheadLog.(MinimalLockingWriteAheadLog.java:108)
at 
org.wali.TestMinimalLockingWriteAheadLog.testRecoverFileThatHasTrailingNULBytesAndTruncation(TestMinimalLockingWriteAheadLog.java:472)

```

but I also don't think it got as far as running the ListenHTTP test.


> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1490) Add multipart request support to ListenHTTP Processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009712#comment-16009712
 ] 

ASF GitHub Bot commented on NIFI-1490:
--

GitHub user pipern opened a pull request:

https://github.com/apache/nifi/pull/1795

NIFI-1490 Add multipart request support to ListenHTTP Processor


### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [X] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pipern/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1795


commit e7d4e3c5ed109c3287122c4fa4b2268e8fa4eed7
Author: Nick Piper 
Date:   2017-05-14T12:17:36Z

Assert that messages were transfered to ListenHTTP's relationship rather 
than ListenTCP (seems more semantically correct)

commit b0aace531ef1753bd296634da2f36932494d144e
Author: Nick Piper 
Date:   2017-05-14T12:18:31Z

NIFI-1490 Add multipart request support to ListenHTTP Processor




> Add multipart request support to ListenHTTP Processor
> -
>
> Key: NIFI-1490
> URL: https://issues.apache.org/jira/browse/NIFI-1490
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andrew Serff
>
> The current ListenHTTP processor does not seem to support multipart requests 
> that are encoded with multipart/form-data.  When a multipart request is 
> received, the ListenHTTPServlet just copies the Request InputStream to the 
> FlowFiles content which leaves the form encoding wrapper in the content and 
> in turn makes the file invalid. 
> Specifically, we want to be able to support file uploads in a multipart 
> request. 
> See this thread in the mailing list for more info: 
> http://mail-archives.apache.org/mod_mbox/nifi-users/201602.mbox/%3C6DE9CEEF-2A37-480F-8D3C-5028C590FD9E%40acesinc.net%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)