[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862403#comment-15862403 ] ASF subversion and git services commented on NIFI-1657: --- Commit 1e5570d9b09d80a47eab45a4901eca8c092a21a5 in nifi's branch refs/heads/master from Andre F de Miranda [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1e5570d ] NIFI-1657 - Configure travis-ci to run mvn verify in ja_JP, fr_FR, and pt_BR This closes #1480. > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862404#comment-15862404 ] ASF GitHub Bot commented on NIFI-1657: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1480 > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862402#comment-15862402 ] ASF GitHub Bot commented on NIFI-1657: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 Thanks a lot @trixpan, I know it has been a real nightmare to get things working with Travis... Will merge ;) > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862323#comment-15862323 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 - after a few hundred builds and options build seems to be having as expected: https://travis-ci.org/trixpan/nifi/builds/200568234 when environment is set to en_US or "default", build succeeds while the french build fails as expected. https://travis-ci.org/trixpan/nifi/jobs/200568237#L2899 > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860256#comment-15860256 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 - this seems to be working now > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859113#comment-15859113 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 by the way, good catch, I had faced this issue before but totally forgot about it. > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859111#comment-15859111 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 seems great. will do it and force push soon > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[
https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857678#comment-15857678
]
ASF GitHub Bot commented on NIFI-1657:
--
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1480
@trixpan I just wanted to check before getting this merged but I believe
setting the properties like you did does not change the locale settings for
surefire plugin (unit tests). The fact is I know there are some tests failing
with French locale although the travis build looks OK.
There is at least one in:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/
This is tracked with NIFI-2683.
So I just did some tests:
If I run
mvn clean install -Duser.language=fr -Duser.region=FR
In the above directory, the build is fine.
But if I change the parent pom.xml with what I suggested in the JIRA:
org.apache.maven.plugins
maven-surefire-plugin
2.18
**/*Test.class
**/Test*.class
**/*Spec.class
true
-Xmx1G
-Djava.net.preferIPv4Stack=true -Duser.language=fr -Duser.region=FR
org.apache.maven.surefire
surefire-junit4
2.18
and run
mvn clean install
then I have a test failure:
Failed tests:
StandardHttpResponseMapperSpec.MergeResponses: #responseEntities.size()
HTTP 200 #httpMethod responses for #requestUriPart:122 Condition not satisfied:
IIRC the arguments passed along the maven command are not used by surefire
plugin which uses its own environment to run unit tests.
So here is my proposition, in the parent pom, add an empty property like
this:
1.8
1.8
3.1.0
...
Then, in the plugin configuration, change the argLine with:
-Xmx1G -Djava.net.preferIPv4Stack=true
${maven.surefire.arguments}
This way, there is absolutely no change with the current behavior and the
default locale of the system will remain the one used when building. However
you can now specify the locale to use with:
mvn clean install -Dmaven.surefire.arguments="-Duser.language=fr
-Duser.region=FR"
And I confirm that the test is failing as "expected".
What do you think?
> Provide support for various locales in CI builds
>
>
> Key: NIFI-1657
> URL: https://issues.apache.org/jira/browse/NIFI-1657
> Project: Apache NiFi
> Issue Type: Task
> Components: Tools and Build
>Reporter: Aldrin Piri
>Assignee: Andre
>Priority: Minor
>
> There were issues stemming from locale and building on more than the default
> would help us catch similar issues moving forward.
> From https://github.com/apache/nifi/pull/292, this can be accomplished via
> something like:
> -Duser.language=fr -Duser.region=FR
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856980#comment-15856980 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 seems good to go. failures were caused by TCP processors > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856185#comment-15856185 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 Only if you commit to port NiFi to minitel. :rofl: ... Just kidding, done > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856182#comment-15856182 ] ASF GitHub Bot commented on NIFI-1657: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 I believe we need one more... I know what you are going to say: French people... what a pain ;) 123 456 fr_FR 345 987,246 fr_FR 123.456 pt_BR 345.987,246 pt_BR 123,456 ja_JP 345,987.246 ja_JP 123,456 en_US 345,987.246 en_US > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856098#comment-15856098 ] Andre commented on NIFI-1657: - following link has a good way of doing this cleanly https://github.com/travis-ci/docs-travis-ci-com/issues/647 > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856084#comment-15856084 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 by the way, just in case someone ever wonder the rationale behind the countries: basic English (Java's default env), a Latin and a "Asian" language with no official status at the UN. > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856079#comment-15856079 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 good catch! > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856073#comment-15856073 ] ASF GitHub Bot commented on NIFI-1657: -- Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1480#discussion_r99832100 --- Diff: .travis.yml --- @@ -15,6 +15,11 @@ language: java +env: + - USER_LANGUAGE=en USER_COUNTRY=US + - USER_LANGUAGE=pt USER_COUNTRY=BR + - USER_LANGUAGE=jp USER_COUNTRY=JP --- End diff -- ``USER_LANGUAGE=ja USER_COUNTRY=JP`` no? > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856062#comment-15856062 ] ASF GitHub Bot commented on NIFI-1657: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 I changed the commit a bit so to use envs (I think things should move faster this way) I reckon we should merge and use it to correct residual issues. This second attempt should hopefully create two independent builds (env in travis lingo) so we will still be able to figure out if the issue is widespread or related to locale. what do you think? > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856054#comment-15856054 ] ASF GitHub Bot commented on NIFI-1657: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 Thanks @trixpan, this will be useful! What do you think: should we get this merged now or wait to fix the tests known to fail with specific locales? (just to avoid a lot of build failures in the meantime) > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-1657) Provide support for various locales in CI builds
[ https://issues.apache.org/jira/browse/NIFI-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856042#comment-15856042 ] ASF GitHub Bot commented on NIFI-1657: -- GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1480 NIFI-1657 - Configure travis-ci to run mvn verify in jp and fr Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X] ~~Have you written or updated unit tests to verify your changes?~~ - [X] ~~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~~ - [X] ~~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~~ - [X] ~~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~~ - [X] ~~If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?~~ ### For documentation related changes: - [X] ~~Have you ensured that format looks appropriate for the output in which it is rendered?~~ ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-1657 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1480.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1480 > Provide support for various locales in CI builds > > > Key: NIFI-1657 > URL: https://issues.apache.org/jira/browse/NIFI-1657 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: Aldrin Piri >Assignee: Andre >Priority: Minor > > There were issues stemming from locale and building on more than the default > would help us catch similar issues moving forward. > From https://github.com/apache/nifi/pull/292, this can be accomplished via > something like: > -Duser.language=fr -Duser.region=FR -- This message was sent by Atlassian JIRA (v6.3.15#6346)
