[jira] [Commented] (NIFI-1792) User can create conditions or actions even when no rule exists to attach them to

2016-10-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551979#comment-15551979
 ] 

ASF GitHub Bot commented on NIFI-1792:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1099


> User can create conditions or actions even when no rule exists to attach them 
> to
> 
>
> Key: NIFI-1792
> URL: https://issues.apache.org/jira/browse/NIFI-1792
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.6.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: NIFI-1792_ruleBlank.png
>
>
> Steps to Reproduce:
> 1. Add a Processor to the canvas that has the Advanced button/functionality 
> on the Properties Tab  (UpdateAttribute processor for example)
> 2.  Select "Advanced"
> 3.  If the user attempts to add a condition or action, the UI will not allow 
> it and display the Configuration Error message of "No rule is selected"
> 4.  Select the "+" button to create a new Rule
> 5.  Add the Rule name and select "Add".  A rule is created.
> 6.  Now delete the rule by selecting the "x" next to it and then confirming 
> the deletion.
> 7.  The user can now add multiple conditions and actions at will.  However, 
> when attempting to Save them, the Error message displayed is "Rule name 
> cannot be blank."  But there is no way to add/edit the rule name.  (See 
> attached screenshot)  Any of the work done to add conditions/actions will be 
> lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-1792) User can create conditions or actions even when no rule exists to attach them to

2016-10-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551978#comment-15551978
 ] 

ASF subversion and git services commented on NIFI-1792:
---

Commit 8bd85e20853c44bbb33bcad2795bfb4ac8819e1a in nifi's branch 
refs/heads/master from [~scottyaslan]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8bd85e2 ]

[NIFI-1792] Clear the selected rule id when deleting the last rule in the list. 
Add scrollable styles when appropriate. Close popups when appropriate. This PR 
also adjusts the position of the table cell nfel and long text editors. This 
closes #1099.


> User can create conditions or actions even when no rule exists to attach them 
> to
> 
>
> Key: NIFI-1792
> URL: https://issues.apache.org/jira/browse/NIFI-1792
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.6.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: NIFI-1792_ruleBlank.png
>
>
> Steps to Reproduce:
> 1. Add a Processor to the canvas that has the Advanced button/functionality 
> on the Properties Tab  (UpdateAttribute processor for example)
> 2.  Select "Advanced"
> 3.  If the user attempts to add a condition or action, the UI will not allow 
> it and display the Configuration Error message of "No rule is selected"
> 4.  Select the "+" button to create a new Rule
> 5.  Add the Rule name and select "Add".  A rule is created.
> 6.  Now delete the rule by selecting the "x" next to it and then confirming 
> the deletion.
> 7.  The user can now add multiple conditions and actions at will.  However, 
> when attempting to Save them, the Error message displayed is "Rule name 
> cannot be blank."  But there is no way to add/edit the rule name.  (See 
> attached screenshot)  Any of the work done to add conditions/actions will be 
> lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-1792) User can create conditions or actions even when no rule exists to attach them to

2016-10-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551980#comment-15551980
 ] 

ASF GitHub Bot commented on NIFI-1792:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1099
  
Thanks @scottyaslan! This has been merged to master.


> User can create conditions or actions even when no rule exists to attach them 
> to
> 
>
> Key: NIFI-1792
> URL: https://issues.apache.org/jira/browse/NIFI-1792
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.6.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: NIFI-1792_ruleBlank.png
>
>
> Steps to Reproduce:
> 1. Add a Processor to the canvas that has the Advanced button/functionality 
> on the Properties Tab  (UpdateAttribute processor for example)
> 2.  Select "Advanced"
> 3.  If the user attempts to add a condition or action, the UI will not allow 
> it and display the Configuration Error message of "No rule is selected"
> 4.  Select the "+" button to create a new Rule
> 5.  Add the Rule name and select "Add".  A rule is created.
> 6.  Now delete the rule by selecting the "x" next to it and then confirming 
> the deletion.
> 7.  The user can now add multiple conditions and actions at will.  However, 
> when attempting to Save them, the Error message displayed is "Rule name 
> cannot be blank."  But there is no way to add/edit the rule name.  (See 
> attached screenshot)  Any of the work done to add conditions/actions will be 
> lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-1792) User can create conditions or actions even when no rule exists to attach them to

2016-10-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546773#comment-15546773
 ] 

ASF GitHub Bot commented on NIFI-1792:
--

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/1099
  
This PR also adjusts the position of the table cell nfel and long text 
editors.


> User can create conditions or actions even when no rule exists to attach them 
> to
> 
>
> Key: NIFI-1792
> URL: https://issues.apache.org/jira/browse/NIFI-1792
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.6.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Minor
> Attachments: NIFI-1792_ruleBlank.png
>
>
> Steps to Reproduce:
> 1. Add a Processor to the canvas that has the Advanced button/functionality 
> on the Properties Tab  (UpdateAttribute processor for example)
> 2.  Select "Advanced"
> 3.  If the user attempts to add a condition or action, the UI will not allow 
> it and display the Configuration Error message of "No rule is selected"
> 4.  Select the "+" button to create a new Rule
> 5.  Add the Rule name and select "Add".  A rule is created.
> 6.  Now delete the rule by selecting the "x" next to it and then confirming 
> the deletion.
> 7.  The user can now add multiple conditions and actions at will.  However, 
> when attempting to Save them, the Error message displayed is "Rule name 
> cannot be blank."  But there is no way to add/edit the rule name.  (See 
> attached screenshot)  Any of the work done to add conditions/actions will be 
> lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-1792) User can create conditions or actions even when no rule exists to attach them to

2016-10-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546766#comment-15546766
 ] 

ASF GitHub Bot commented on NIFI-1792:
--

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi/pull/1099

[NIFI-1792] Clear the selected rule id when deleting the last rule in…

… the list. Add scrollable styles when appropriate. Close popups when 
appropriate. Remove draggable on popups

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi NIFI-1792

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1099.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1099


commit 44b12fbdb979dbd7e64f1a87e93da4aec45f62ea
Author: Scott Aslan 
Date:   2016-10-04T21:46:37Z

[NIFI-1792] Clear the selected rule id when deleting the last rule in the 
list. Add scrollable styles when appropriate. Close popups when appropriate. 
Remove draggable on popups




> User can create conditions or actions even when no rule exists to attach them 
> to
> 
>
> Key: NIFI-1792
> URL: https://issues.apache.org/jira/browse/NIFI-1792
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.6.0
>Reporter: Andrew Lim
>Assignee: Scott Aslan
>Priority: Minor
> Attachments: NIFI-1792_ruleBlank.png
>
>
> Steps to Reproduce:
> 1. Add a Processor to the canvas that has the Advanced button/functionality 
> on the Properties Tab  (UpdateAttribute processor for example)
> 2.  Select "Advanced"
> 3.  If the user attempts to add a condition or action, the UI will not allow 
> it and display the Configuration Error message of "No rule is selected"
> 4.  Select the "+" button to create a new Rule
> 5.  Add the Rule name and select "Add".  A rule is created.
> 6.  Now delete the rule by selecting the "x" next to it and then confirming 
> the deletion.
> 7.  The user can now add multiple conditions and actions at will.  However, 
> when attempting to Save them, the Error message displayed is "Rule name 
> cannot be blank."  But there is no way to add/edit the rule name.  (See 
> attached screenshot)  Any of the work done to add conditions/actions will be 
> lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-1792) User can create conditions or actions even when no rule exists to attach them to

2016-09-28 Thread Andrew Lim (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530772#comment-15530772
 ] 

Andrew Lim commented on NIFI-1792:
--

Still occurs in 1.0.0.

> User can create conditions or actions even when no rule exists to attach them 
> to
> 
>
> Key: NIFI-1792
> URL: https://issues.apache.org/jira/browse/NIFI-1792
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0, 0.6.0
>Reporter: Andrew Lim
>Priority: Minor
> Attachments: NIFI-1792_ruleBlank.png
>
>
> Steps to Reproduce:
> 1. Add a Processor to the canvas that has the Advanced button/functionality 
> on the Properties Tab  (UpdateAttribute processor for example)
> 2.  Select "Advanced"
> 3.  If the user attempts to add a condition or action, the UI will not allow 
> it and display the Configuration Error message of "No rule is selected"
> 4.  Select the "+" button to create a new Rule
> 5.  Add the Rule name and select "Add".  A rule is created.
> 6.  Now delete the rule by selecting the "x" next to it and then confirming 
> the deletion.
> 7.  The user can now add multiple conditions and actions at will.  However, 
> when attempting to Save them, the Error message displayed is "Rule name 
> cannot be blank."  But there is no way to add/edit the rule name.  (See 
> attached screenshot)  Any of the work done to add conditions/actions will be 
> lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)