[jira] [Commented] (NIFI-2291) Site-to-Site Provenance Reporting Task showing wrong content URI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406434#comment-15406434
 ] 

ASF GitHub Bot commented on NIFI-2291:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/752
  
Excellent, thanks, @YolandaMDavis ! Congratulations of your first merge :)


> Site-to-Site Provenance Reporting Task showing wrong content URI
> 
>
> Key: NIFI-2291
> URL: https://issues.apache.org/jira/browse/NIFI-2291
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> I'm seeing the following JSON provided by the reporting task:
> {"eventId":"056aaf5c-476b-48fb-a252-55f9c6f42287",
> "eventOrdinal":113158283,
> "eventType":"ATTRIBUTES_MODIFIED",
> "timestampMillis":1468719367054,
> "timestamp":"2016-07-17T01:36:07.054Z",
> "durationMillis":-1,
> "lineageStart":146871866,
> "componentId":"f1550b29-5823-31c0-801d-d95770828ca9",
> "componentType":"UpdateAttribute",
> "componentName":"UpdateAttribute",
> "entityId":"14d23482-e2e6-4740-af6a-31059134feef",
> "entityType":"org.apache.nifi.flowfile.FlowFile",
> "entitySize":1431,
> "previousEntitySize":1431,
> "updatedAttributes":{},
> "previousAttributes":{"path":"./","execution.command":"python","filename":"5285482415879175","execution.command.args":"-m
>  
> json.tool","execution.status":"0","reporting.task.transaction.id":"a3528aa7-674b-4de1-a65c-61ff0b094eac","execution.error":"","uuid":"14d23482-e2e6-4740-af6a-31059134feef"},
> "actorHostname":"nifi-02",
> "contentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/output",
> "previousContentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/input",
> "parentIds":[],
> "childIds":[],
> "platform":"nifi",
> "application":"NiFi Flow"}
> It appears that the "/nifi" is getting removed from the content URI - I think 
> this has to do with the following block of code in the reporting task:
> `final String urlPrefix = nifiUrl.toString().replace(nifiUrl.getPath(), "");`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2291) Site-to-Site Provenance Reporting Task showing wrong content URI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406005#comment-15406005
 ] 

ASF GitHub Bot commented on NIFI-2291:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/752


> Site-to-Site Provenance Reporting Task showing wrong content URI
> 
>
> Key: NIFI-2291
> URL: https://issues.apache.org/jira/browse/NIFI-2291
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> I'm seeing the following JSON provided by the reporting task:
> {"eventId":"056aaf5c-476b-48fb-a252-55f9c6f42287",
> "eventOrdinal":113158283,
> "eventType":"ATTRIBUTES_MODIFIED",
> "timestampMillis":1468719367054,
> "timestamp":"2016-07-17T01:36:07.054Z",
> "durationMillis":-1,
> "lineageStart":146871866,
> "componentId":"f1550b29-5823-31c0-801d-d95770828ca9",
> "componentType":"UpdateAttribute",
> "componentName":"UpdateAttribute",
> "entityId":"14d23482-e2e6-4740-af6a-31059134feef",
> "entityType":"org.apache.nifi.flowfile.FlowFile",
> "entitySize":1431,
> "previousEntitySize":1431,
> "updatedAttributes":{},
> "previousAttributes":{"path":"./","execution.command":"python","filename":"5285482415879175","execution.command.args":"-m
>  
> json.tool","execution.status":"0","reporting.task.transaction.id":"a3528aa7-674b-4de1-a65c-61ff0b094eac","execution.error":"","uuid":"14d23482-e2e6-4740-af6a-31059134feef"},
> "actorHostname":"nifi-02",
> "contentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/output",
> "previousContentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/input",
> "parentIds":[],
> "childIds":[],
> "platform":"nifi",
> "application":"NiFi Flow"}
> It appears that the "/nifi" is getting removed from the content URI - I think 
> this has to do with the following block of code in the reporting task:
> `final String urlPrefix = nifiUrl.toString().replace(nifiUrl.getPath(), "");`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2291) Site-to-Site Provenance Reporting Task showing wrong content URI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406002#comment-15406002
 ] 

ASF subversion and git services commented on NIFI-2291:
---

Commit bc5237593e438405c33713602e78cf009f6614e9 in nifi's branch 
refs/heads/master from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=bc52375 ]

NIFI-2291: Correct the Content URI for 1.0.0 REST API; added cluster node 
identifier & whether or not clustered to ReportingContext so that the Reporting 
Task could make use of it

Signed-off-by: Yolanda M. Davis 

This closes #752


> Site-to-Site Provenance Reporting Task showing wrong content URI
> 
>
> Key: NIFI-2291
> URL: https://issues.apache.org/jira/browse/NIFI-2291
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> I'm seeing the following JSON provided by the reporting task:
> {"eventId":"056aaf5c-476b-48fb-a252-55f9c6f42287",
> "eventOrdinal":113158283,
> "eventType":"ATTRIBUTES_MODIFIED",
> "timestampMillis":1468719367054,
> "timestamp":"2016-07-17T01:36:07.054Z",
> "durationMillis":-1,
> "lineageStart":146871866,
> "componentId":"f1550b29-5823-31c0-801d-d95770828ca9",
> "componentType":"UpdateAttribute",
> "componentName":"UpdateAttribute",
> "entityId":"14d23482-e2e6-4740-af6a-31059134feef",
> "entityType":"org.apache.nifi.flowfile.FlowFile",
> "entitySize":1431,
> "previousEntitySize":1431,
> "updatedAttributes":{},
> "previousAttributes":{"path":"./","execution.command":"python","filename":"5285482415879175","execution.command.args":"-m
>  
> json.tool","execution.status":"0","reporting.task.transaction.id":"a3528aa7-674b-4de1-a65c-61ff0b094eac","execution.error":"","uuid":"14d23482-e2e6-4740-af6a-31059134feef"},
> "actorHostname":"nifi-02",
> "contentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/output",
> "previousContentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/input",
> "parentIds":[],
> "childIds":[],
> "platform":"nifi",
> "application":"NiFi Flow"}
> It appears that the "/nifi" is getting removed from the content URI - I think 
> this has to do with the following block of code in the reporting task:
> `final String urlPrefix = nifiUrl.toString().replace(nifiUrl.getPath(), "");`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2291) Site-to-Site Provenance Reporting Task showing wrong content URI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405941#comment-15405941
 ] 

ASF GitHub Bot commented on NIFI-2291:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/752
  
@markap14 all looks good, was able to test reporting task logging 
errors/warning without failing and reporting successfully with contentURI 
changes

+1

Will get this merged into master shortly (yay my first merge into Apache 
NiFi! :))


> Site-to-Site Provenance Reporting Task showing wrong content URI
> 
>
> Key: NIFI-2291
> URL: https://issues.apache.org/jira/browse/NIFI-2291
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> I'm seeing the following JSON provided by the reporting task:
> {"eventId":"056aaf5c-476b-48fb-a252-55f9c6f42287",
> "eventOrdinal":113158283,
> "eventType":"ATTRIBUTES_MODIFIED",
> "timestampMillis":1468719367054,
> "timestamp":"2016-07-17T01:36:07.054Z",
> "durationMillis":-1,
> "lineageStart":146871866,
> "componentId":"f1550b29-5823-31c0-801d-d95770828ca9",
> "componentType":"UpdateAttribute",
> "componentName":"UpdateAttribute",
> "entityId":"14d23482-e2e6-4740-af6a-31059134feef",
> "entityType":"org.apache.nifi.flowfile.FlowFile",
> "entitySize":1431,
> "previousEntitySize":1431,
> "updatedAttributes":{},
> "previousAttributes":{"path":"./","execution.command":"python","filename":"5285482415879175","execution.command.args":"-m
>  
> json.tool","execution.status":"0","reporting.task.transaction.id":"a3528aa7-674b-4de1-a65c-61ff0b094eac","execution.error":"","uuid":"14d23482-e2e6-4740-af6a-31059134feef"},
> "actorHostname":"nifi-02",
> "contentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/output",
> "previousContentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/input",
> "parentIds":[],
> "childIds":[],
> "platform":"nifi",
> "application":"NiFi Flow"}
> It appears that the "/nifi" is getting removed from the content URI - I think 
> this has to do with the following block of code in the reporting task:
> `final String urlPrefix = nifiUrl.toString().replace(nifiUrl.getPath(), "");`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2291) Site-to-Site Provenance Reporting Task showing wrong content URI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404791#comment-15404791
 ] 

ASF GitHub Bot commented on NIFI-2291:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/752
  
@YolandaMDavis wow that's a good catch and is very... odd. I think this is 
actually a JDK bug. I'm about 99% sure that the anonymous inner class *should* 
be able to access that method. And if it can't, it should be a compile-time 
error not a runtime error. In fact, the Javadocs for that error even explicitly 
say:

> Normally, this error is caught by the compiler; this error can only occur 
at run time if the definition of a class has incompatibly changed.

I'm quite certain that the definition of the class has not changed. In any 
event, I believe the proposed solution is a reasonable one, so I implemented it 
and pushed a new commit. I also addressed your other feedback by making the URI 
path a constant. Good call.

Thanks for taking the time to review this. Let me know if you run into 
anything else. Thanks!


> Site-to-Site Provenance Reporting Task showing wrong content URI
> 
>
> Key: NIFI-2291
> URL: https://issues.apache.org/jira/browse/NIFI-2291
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> I'm seeing the following JSON provided by the reporting task:
> {"eventId":"056aaf5c-476b-48fb-a252-55f9c6f42287",
> "eventOrdinal":113158283,
> "eventType":"ATTRIBUTES_MODIFIED",
> "timestampMillis":1468719367054,
> "timestamp":"2016-07-17T01:36:07.054Z",
> "durationMillis":-1,
> "lineageStart":146871866,
> "componentId":"f1550b29-5823-31c0-801d-d95770828ca9",
> "componentType":"UpdateAttribute",
> "componentName":"UpdateAttribute",
> "entityId":"14d23482-e2e6-4740-af6a-31059134feef",
> "entityType":"org.apache.nifi.flowfile.FlowFile",
> "entitySize":1431,
> "previousEntitySize":1431,
> "updatedAttributes":{},
> "previousAttributes":{"path":"./","execution.command":"python","filename":"5285482415879175","execution.command.args":"-m
>  
> json.tool","execution.status":"0","reporting.task.transaction.id":"a3528aa7-674b-4de1-a65c-61ff0b094eac","execution.error":"","uuid":"14d23482-e2e6-4740-af6a-31059134feef"},
> "actorHostname":"nifi-02",
> "contentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/output",
> "previousContentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/input",
> "parentIds":[],
> "childIds":[],
> "platform":"nifi",
> "application":"NiFi Flow"}
> It appears that the "/nifi" is getting removed from the content URI - I think 
> this has to do with the following block of code in the reporting task:
> `final String urlPrefix = nifiUrl.toString().replace(nifiUrl.getPath(), "");`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2291) Site-to-Site Provenance Reporting Task showing wrong content URI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403338#comment-15403338
 ] 

ASF GitHub Bot commented on NIFI-2291:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/752
  
@markap14 picking this up for review


> Site-to-Site Provenance Reporting Task showing wrong content URI
> 
>
> Key: NIFI-2291
> URL: https://issues.apache.org/jira/browse/NIFI-2291
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> I'm seeing the following JSON provided by the reporting task:
> {"eventId":"056aaf5c-476b-48fb-a252-55f9c6f42287",
> "eventOrdinal":113158283,
> "eventType":"ATTRIBUTES_MODIFIED",
> "timestampMillis":1468719367054,
> "timestamp":"2016-07-17T01:36:07.054Z",
> "durationMillis":-1,
> "lineageStart":146871866,
> "componentId":"f1550b29-5823-31c0-801d-d95770828ca9",
> "componentType":"UpdateAttribute",
> "componentName":"UpdateAttribute",
> "entityId":"14d23482-e2e6-4740-af6a-31059134feef",
> "entityType":"org.apache.nifi.flowfile.FlowFile",
> "entitySize":1431,
> "previousEntitySize":1431,
> "updatedAttributes":{},
> "previousAttributes":{"path":"./","execution.command":"python","filename":"5285482415879175","execution.command.args":"-m
>  
> json.tool","execution.status":"0","reporting.task.transaction.id":"a3528aa7-674b-4de1-a65c-61ff0b094eac","execution.error":"","uuid":"14d23482-e2e6-4740-af6a-31059134feef"},
> "actorHostname":"nifi-02",
> "contentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/output",
> "previousContentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/input",
> "parentIds":[],
> "childIds":[],
> "platform":"nifi",
> "application":"NiFi Flow"}
> It appears that the "/nifi" is getting removed from the content URI - I think 
> this has to do with the following block of code in the reporting task:
> `final String urlPrefix = nifiUrl.toString().replace(nifiUrl.getPath(), "");`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2291) Site-to-Site Provenance Reporting Task showing wrong content URI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400349#comment-15400349
 ] 

ASF GitHub Bot commented on NIFI-2291:
--

GitHub user markap14 opened a pull request:

https://github.com/apache/nifi/pull/752

NIFI-2291: Correct the Content URI for 1.0.0 REST API; added cluster …

…node identifier & whether or not clustered to ReportingContext so that the 
Reporting Task could make use of it

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markap14/nifi NIFI-2291

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/752.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #752


commit 998a5be3b1fef77f1cb189e9b88e158656433d11
Author: Mark Payne 
Date:   2016-07-30T01:17:47Z

NIFI-2291: Correct the Content URI for 1.0.0 REST API; added cluster node 
identifier & whether or not clustered to ReportingContext so that the Reporting 
Task could make use of it




> Site-to-Site Provenance Reporting Task showing wrong content URI
> 
>
> Key: NIFI-2291
> URL: https://issues.apache.org/jira/browse/NIFI-2291
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> I'm seeing the following JSON provided by the reporting task:
> {"eventId":"056aaf5c-476b-48fb-a252-55f9c6f42287",
> "eventOrdinal":113158283,
> "eventType":"ATTRIBUTES_MODIFIED",
> "timestampMillis":1468719367054,
> "timestamp":"2016-07-17T01:36:07.054Z",
> "durationMillis":-1,
> "lineageStart":146871866,
> "componentId":"f1550b29-5823-31c0-801d-d95770828ca9",
> "componentType":"UpdateAttribute",
> "componentName":"UpdateAttribute",
> "entityId":"14d23482-e2e6-4740-af6a-31059134feef",
> "entityType":"org.apache.nifi.flowfile.FlowFile",
> "entitySize":1431,
> "previousEntitySize":1431,
> "updatedAttributes":{},
> "previousAttributes":{"path":"./","execution.command":"python","filename":"5285482415879175","execution.command.args":"-m
>  
> json.tool","execution.status":"0","reporting.task.transaction.id":"a3528aa7-674b-4de1-a65c-61ff0b094eac","execution.error":"","uuid":"14d23482-e2e6-4740-af6a-31059134feef"},
> "actorHostname":"nifi-02",
> "contentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/output",
> "previousContentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/input",
> "parentIds":[],
> "childIds":[],
> "platform":"nifi",
> "application":"NiFi Flow"}
> It appears that the "/nifi" is getting removed from the content URI - I think 
> this has to do with the following block of code in the reporting task:
> `final String urlPrefix = nifiUrl.toString().replace(nifiUrl.getPath(), "");`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)