[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432011#comment-15432011
 ] 

ASF GitHub Bot commented on NIFI-2521:
--

Github user joewitt closed the pull request at:

https://github.com/apache/nifi/pull/816


> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414122#comment-15414122
 ] 

ASF GitHub Bot commented on NIFI-2521:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/815


> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414120#comment-15414120
 ] 

ASF subversion and git services commented on NIFI-2521:
---

Commit b2401522ead954c31004fa5877d51fc69d72e4da in nifi's branch 
refs/heads/master from [~joewitt]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b240152 ]

NIFI-2521 This closes #815. removed test classes with questionable origin and 
licensing.


> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414119#comment-15414119
 ] 

Joseph Witt commented on NIFI-2521:
---

sounds good - i am comfortable with this.  Will merge to master and 0.x then 
close this JIRA.  Please make a new JIRA for 1.1 and 0.x to address providing 
new clean tests.  Thanks

> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[Pierre Villard (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414114#comment-15414114
 ] 

Pierre Villard commented on NIFI-2521:
--

[~joewitt] it clearly seems that there is more digging required from me to 
ensure we are safe here. Besides there is a unit test failing time to time. At 
this point, with releases coming, the safest way to move forward is to remove 
the tests. I'll submit a new PR shortly to address the tests of this bundle. In 
the meantime, the PR you submitted LGTM. +1

> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Pierre Villard
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413787#comment-15413787
 ] 

Joseph Witt commented on NIFI-2521:
---

had an off-line discussion with Pierre to understand the origin of these 
classes.  He mentions it is sourced to SNMP4J but does agree the above cited 
item calls that into question.  The PR i've offered is a blunt instrument.  It 
kills off the questionable code but it leaves us with insufficient test 
coverage.  We could live with this for 1.0 but it would need to be corrected 
later.  Pierre mentions he will try to take a look at this evening.  Have given 
him the ticket.  If we get close to cutting the 1.0 release and this is not 
resolved then we can merge this PR as-is.  For now let's see if Pierre can 
provide alternative testing.  Thanks [~pvillard]

> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Pierre Villard
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413660#comment-15413660
 ] 

Joseph Witt commented on NIFI-2521:
---

Found this on github which appears strongly related:
  
https://github.com/jrask/snmp-blog/blob/master/src/main/java/com/jayway/snmpblogg/Agent.java

> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412929#comment-15412929
 ] 

ASF GitHub Bot commented on NIFI-2521:
--

GitHub user joewitt opened a pull request:

https://github.com/apache/nifi/pull/816

NIFI-2521 removed offending test classes and referencing items



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joewitt/incubator-nifi NIFI-2521-0.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/816.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #816


commit fbef84c8af7e88e472b9643f1bc145a5d85c60c6
Author: joewitt 
Date:   2016-08-09T04:51:04Z

NIFI-2521 removed offending test classes and referencing items




> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2521) License and Notice - TestSNMPAgent classes appear to be copied from external sources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412916#comment-15412916
 ] 

ASF GitHub Bot commented on NIFI-2521:
--

GitHub user joewitt opened a pull request:

https://github.com/apache/nifi/pull/815

NIFI-2521 removed test classes with questionable origin and licensing.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joewitt/incubator-nifi NIFI-2521

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/815.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #815


commit bfc61165d40eebde0ec89249d772aa5238a5aa16
Author: joewitt 
Date:   2016-08-09T04:33:45Z

NIFI-2521 removed test classes with questionable origin and licensing.




> License and Notice - TestSNMPAgent classes appear to be copied from external 
> sources
> 
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large 
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from  XYZ as found here 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)