[jira] [Commented] (NIFI-2913) Nifi processeror's input form & long text
[ https://issues.apache.org/jira/browse/NIFI-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586861#comment-15586861 ] ASF GitHub Bot commented on NIFI-2913: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1145 Ran `contrib-check`, all tests pass, verified this fixes the issue. +1, merging. > Nifi processeror's input form & long text > - > > Key: NIFI-2913 > URL: https://issues.apache.org/jira/browse/NIFI-2913 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.0.0 > Environment: Chrome 53 > Firefox 49.0.1 >Reporter: Yari Marchetti >Assignee: Scott Aslan >Priority: Minor > > Hello, > I need to configure several processors with some very long text and, even if > it's very easy to create them, I'm finding the UI for reading a little > "unhandy". The reason is that: > - As long as the text is only one line (even if very very long), there's no > problem: a scrolling bar is created but the resize handle available in all > major browser is visible so I can simply resize the text area to a suitable > dimension. Same is true horizontally (I think scroll bar kicks in after > something like 5 or 6) > > - But when the text exceed the max dimension both horizontally and > vertically, the resize handle vanish and there's no way to resize the text > are anymore. > - I'm not a CSS/JS expert but as far as I can see it's all due to this line: > > which, if removed, brings back the resize handle. > Could you please look into it? > Thanks, > Yari -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2913) Nifi processeror's input form & long text
[ https://issues.apache.org/jira/browse/NIFI-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586859#comment-15586859 ] ASF subversion and git services commented on NIFI-2913: --- Commit f287bc9119c2f0d018329f53c85fb502b5c96f18 in nifi's branch refs/heads/master from [~scottyaslan] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=f287bc9 ] [NIFI-2913] update z-index of codemirror resize handle to match the z-index of the codemirror vert. and horz. scrollbars This closes #1145. Signed-off-by: Andy LoPresto> Nifi processeror's input form & long text > - > > Key: NIFI-2913 > URL: https://issues.apache.org/jira/browse/NIFI-2913 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.0.0 > Environment: Chrome 53 > Firefox 49.0.1 >Reporter: Yari Marchetti >Assignee: Scott Aslan >Priority: Minor > > Hello, > I need to configure several processors with some very long text and, even if > it's very easy to create them, I'm finding the UI for reading a little > "unhandy". The reason is that: > - As long as the text is only one line (even if very very long), there's no > problem: a scrolling bar is created but the resize handle available in all > major browser is visible so I can simply resize the text area to a suitable > dimension. Same is true horizontally (I think scroll bar kicks in after > something like 5 or 6) > > - But when the text exceed the max dimension both horizontally and > vertically, the resize handle vanish and there's no way to resize the text > are anymore. > - I'm not a CSS/JS expert but as far as I can see it's all due to this line: > > which, if removed, brings back the resize handle. > Could you please look into it? > Thanks, > Yari -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2913) Nifi processeror's input form & long text
[ https://issues.apache.org/jira/browse/NIFI-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586800#comment-15586800 ] ASF GitHub Bot commented on NIFI-2913: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1145 @scottyaslan I built this and once I have entered text that extends past the boundaries to the right and the bottom, I can still use the resize handle, but I can only resize vertically. Is this intentional? > Nifi processeror's input form & long text > - > > Key: NIFI-2913 > URL: https://issues.apache.org/jira/browse/NIFI-2913 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.0.0 > Environment: Chrome 53 > Firefox 49.0.1 >Reporter: Yari Marchetti >Assignee: Scott Aslan >Priority: Minor > > Hello, > I need to configure several processors with some very long text and, even if > it's very easy to create them, I'm finding the UI for reading a little > "unhandy". The reason is that: > - As long as the text is only one line (even if very very long), there's no > problem: a scrolling bar is created but the resize handle available in all > major browser is visible so I can simply resize the text area to a suitable > dimension. Same is true horizontally (I think scroll bar kicks in after > something like 5 or 6) > > - But when the text exceed the max dimension both horizontally and > vertically, the resize handle vanish and there's no way to resize the text > are anymore. > - I'm not a CSS/JS expert but as far as I can see it's all due to this line: > > which, if removed, brings back the resize handle. > Could you please look into it? > Thanks, > Yari -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2913) Nifi processeror's input form & long text
[ https://issues.apache.org/jira/browse/NIFI-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586743#comment-15586743 ] ASF GitHub Bot commented on NIFI-2913: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1145 Reviewing... > Nifi processeror's input form & long text > - > > Key: NIFI-2913 > URL: https://issues.apache.org/jira/browse/NIFI-2913 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.0.0 > Environment: Chrome 53 > Firefox 49.0.1 >Reporter: Yari Marchetti >Assignee: Scott Aslan >Priority: Minor > > Hello, > I need to configure several processors with some very long text and, even if > it's very easy to create them, I'm finding the UI for reading a little > "unhandy". The reason is that: > - As long as the text is only one line (even if very very long), there's no > problem: a scrolling bar is created but the resize handle available in all > major browser is visible so I can simply resize the text area to a suitable > dimension. Same is true horizontally (I think scroll bar kicks in after > something like 5 or 6) > > - But when the text exceed the max dimension both horizontally and > vertically, the resize handle vanish and there's no way to resize the text > are anymore. > - I'm not a CSS/JS expert but as far as I can see it's all due to this line: > > which, if removed, brings back the resize handle. > Could you please look into it? > Thanks, > Yari -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2913) Nifi processeror's input form & long text
[ https://issues.apache.org/jira/browse/NIFI-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586299#comment-15586299 ] ASF GitHub Bot commented on NIFI-2913: -- GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1145 [NIFI-2913] update z-index of codemirror resize handle to match the z… Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. …-index of the codemirror vert. and horz. scrollbars You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi NIFI-2913 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1145.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1145 commit 6b3348cddae9c0c04d23bc9e6d47cbac7e213320 Author: Scott AslanDate: 2016-10-18T18:43:48Z [NIFI-2913] update z-index of codemirror resize handle to match the z-index of the codemirror vert. and horz. scrollbars > Nifi processeror's input form & long text > - > > Key: NIFI-2913 > URL: https://issues.apache.org/jira/browse/NIFI-2913 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.0.0 > Environment: Chrome 53 > Firefox 49.0.1 >Reporter: Yari Marchetti >Assignee: Scott Aslan >Priority: Minor > > Hello, > I need to configure several processors with some very long text and, even if > it's very easy to create them, I'm finding the UI for reading a little > "unhandy". The reason is that: > - As long as the text is only one line (even if very very long), there's no > problem: a scrolling bar is created but the resize handle available in all > major browser is visible so I can simply resize the text area to a suitable > dimension. Same is true horizontally (I think scroll bar kicks in after > something like 5 or 6) > > - But when the text exceed the max dimension both horizontally and > vertically, the resize handle vanish and there's no way to resize the text > are anymore. > - I'm not a CSS/JS expert but as far as I can see it's all due to this line: > > which, if removed, brings back the resize handle. > Could you please look into it? > Thanks, > Yari -- This message was sent by Atlassian JIRA (v6.3.4#6332)