[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715960#comment-15715960
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/1208
  
@ijokarumawak Thanks for the updates! All looks good to me now. I've tested 
and everything seems to work well. Reviewed code and things look good. +1 
merged to master!


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715956#comment-15715956
 ] 

ASF subversion and git services commented on NIFI-3026:
---

Commit 7c5bd876bdd49ec14482a24dd31a073757f06ed4 in nifi's branch 
refs/heads/master from [~ijokarumawak]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=7c5bd87 ]

NIFI-3026: Support multiple remote target URLs

- Added urls in addition to the existing url, to support multiple target
  URLs
- Backward compatibility is provided by returning the first url if
  multipe urls are specified, but component accessing the url doesn't
support multiple urls
- UI is not fully updated yet. Following UI components are planned to be updated
  by different commits
  - Search component: only the first URL is searchable and shown
  - Component status: RPG status shows only the first URL
  - Component action history: only the first URL is searchable and shown
  - Updated Search component to use URLs.

This closes #1208.


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715958#comment-15715958
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1208


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710638#comment-15710638
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1208
  
The last commit addresses Component Search to use URIs so that user can 
search RPG with any URI defined.


![image](https://cloud.githubusercontent.com/assets/1107620/20779807/3098a10e-b7ba-11e6-8a2f-d2ac205c8547.png)

I took a closer look on the remaining UI components, Component Status, 
Summary, and Action History described in the previous comment. I think there 
won't be much benefits by using URIs with these component despite of the amount 
of lines of code required to be changed.
So, I left these as it is.

I have finished changing code and testing.
@markap14 Please review and give any feedback. Thank you!


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708694#comment-15708694
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1208
  
Hi @markap14 @mcgilman 

I've updated the PR commit with the latest master.
Explicitly separated the URI and URIs. 

I've also updated these RPG UI components to use the plural URLs.
These display Name and URIs. It looked too verbose if URLs are used for 
both Name and URIs, so I used URI for the Name if Name is not specified:

https://cloud.githubusercontent.com/assets/1107620/20754872/3bfd7b88-b750-11e6-872f-b3ae814eeff3.png;>


Tried to update all UI components that I was aware of, but I didn't want to 
make this PR huge and rush to change following components, so that we can 
discuss more about the details with separated JIRAs.

## Known UI components those are not updated to use URLs

### Search component

RPGs can be searched by target URI. I haven't updated search related 
components to use plural URIs. So only the first URI is searchable, and shown 
in the UI right now.

https://cloud.githubusercontent.com/assets/1107620/20755069/fab5d430-b750-11e6-93cf-2d6957b537e2.png;>

### Component Status and Summary

https://cloud.githubusercontent.com/assets/1107620/20755188/6508fc68-b751-11e6-9ac4-79b55dd660b1.png;>

### Action History

When RPG is updated, audit event is stored. I think we should use URIs 
here. But in order to do so, we have to alter the REMOTE_PROCESS_GROUP_DETAILS 
table in database repository. I don't know what would be a proper migration 
process at this point, so didn't touch it within this PR.

https://cloud.githubusercontent.com/assets/1107620/20755303/c9db3084-b751-11e6-8a94-0b40e2e8e580.png;>

Hope this PR would be sufficient to provide the core support of multiple 
URIs for better connectivity with NiFi cluster via Site-to-Site. Thanks for 
reviewing!


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703626#comment-15703626
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1208
  
@markap14 @mcgilman Thank you for the comments. I will update the PR by 
adding getTargetUrist o make DTO and API consistent with other changes.


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703114#comment-15703114
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1208
  
I think what @markap14 outlined above would be fine. It would be consistent 
with the other changes in this PR. We can certainly address the UX in a 
subsequent JIRA however, we cannot go back if we start accepting a comma 
separate list in the target URI field of the RPG DTO.

Another option which I'm also fine with would be if we supported specifying 
either a single target URI **or** a listing. This would support backward 
compatibility while offering support for multiple going forward.


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703084#comment-15703084
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/1208
  
@ijokarumawak thanks for the update. The new commit perfectly addresses the 
concern that I had with the Builder. I do think we should update the 
RemoteProcessGroup & DTO as well. The DTO could still have a getTargetUri() 
that would return the first value entered, just as the builder does now, and 
then also have a getTargetUris() that returns all of them. Along those lines, 
it may make sense to not event deprecated the getUri() method and simply 
document that it returns the first one entered by the user and the getUris() 
method returns all of them. The DTO may also require having a setTargetUri() 
and setTargetUris(). I'm just very hesitant to return a comma-separated list of 
URI's when we have a method named getUri(), etc. This would also have the added 
benefit of keeping the UI clean, showing a single URI if we want to. @mcgilman 
do you have any thoughts on how the RPG DTO should change (or not)?


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15678709#comment-15678709
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1208
  
@markap14 I'm still not 100% sure if it addresses your concern.. but I've 
updated the code. 

RemoteProcessGroup has `getTargetUri` method that returns a String. I 
wondered if we should do the same thing with this, by adding `getTargetUris`, 
but I left it as it is. Because if we do, we may want to change 
RemoteProcessGroupDTO as well, it will change NiFi Web REST API data format..

Local contrib check has passed, and now I'm testing it with running NiFi 
environments. It will take a while to go through a variety of S2S tests. But I 
think it's ready for code review.

Would you take a look and give me feedback?


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676761#comment-15676761
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/1208
  
@ijokarumawak it was not the comment that concerns me. What concerns me is 
that we have a method named getUrl() (present in both SiteToSiteClientConfig 
and the SiteToSiteClient.Builder), and that method returns a String that is no 
longer a valid URL. Given that the method name is getUrl(), it is very 
reasonable to expect someone to write code like the following:

`final URL url = new URL(clientConfig.getUrl());`

And in fact we did something very similar in the client. This will now 
throw an Exception because getUrl() may not be returning a valid URL. There are 
many reasons that may be done - not just by someone implementing a client. 
Also, we can't assume that "the URL is what they configured by themselves." 
Certainly, code can be written to pass this object around. There's no telling 
where it came from.

We also must keep in mind that while Apache Flink, Storm and Spark 
integration may be safe, we have no idea what other projects may be using the 
client.

So my recommendation would be this: have a method named getUrls() that 
returns a comma-separated list of URL's, just like getUrl() does now in this 
PR. Then, add a getUrl() to maintain backward compatibility but make that 
method return the first URL available and mark it as deprecated with 
documentation as to why it's deprecated and why we now recommend use of 
getUrls() instead.

Does that seem reasonable?


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675359#comment-15675359
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1208
  
@markap14 I checked how Apache Flink uses SiteToSiteClient from 
[NiFiSink](https://github.com/apache/flink/blob/d7b59d761601baba6765bb4fc407bcd9fd6a9387/flink-streaming-connectors/flink-connector-nifi/src/test/java/org/apache/flink/streaming/connectors/nifi/examples/NiFiSinkTopologyExample.java).
 That is the same pattern Storm and Spark integration does.
I agree that third parties have been using SiteToSiteClient, but I don't 
think many of them re-implement SiteToSiteClient actual implementation, rather 
they just use the library. When they use it just to use SiteToSite protocol, 
the URL is what they configured by themselves. So it should be fine. It doesn't 
break anything.

For the case if a third party actually re-implementing a SiteToSiteClient 
to customize it at lower level, excuse me, the comment you concerned about was 
misleading. The interface hasn't been changed at all. What has changed by this 
PR is the behavior of one implementation of SiteToSiteClient, that is the NiFi 
default implementation, i.e. SocketClient and HttpClient. I didn't have to 
change the comment in the first place. It doesn't break any other 
SiteToSiteClient implementations written by third parties outside of NiFi 
codebase.

So, to address your concern, I just removed the comment from 
SiteToSiteClient.java. By doing so, the file becomes identical with the 
previous version. So I amended the commit to keep it intact.


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673773#comment-15673773
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1208#discussion_r88453728
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
 ---
@@ -560,7 +560,8 @@ public SiteToSiteClient build() {
 }
 
 /**
- * @return the configured URL for the remote NiFi instance
+ * @return the configured URL for the remote NiFi instance.
+ * The URL string possibly contains multiple URL entries in 
comma-separated format.
  */
 public String getUrl() {
--- End diff --

@ijokarumawak my concern is not code within the NiFi codebase, but rather 
code written by third parties. I believe there are others already who have code 
unrelated to NiFi, that actually depend on this client lib for 
sending/receiving data.


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662528#comment-15662528
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user ijokarumawak commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1208#discussion_r87730175
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
 ---
@@ -560,7 +560,8 @@ public SiteToSiteClient build() {
 }
 
 /**
- * @return the configured URL for the remote NiFi instance
+ * @return the configured URL for the remote NiFi instance.
+ * The URL string possibly contains multiple URL entries in 
comma-separated format.
  */
 public String getUrl() {
--- End diff --

SiteToSiteReportingTask has its own UI and it doesn't allow URL in a 
comma-separated format. We need to update the reporting task, too. However, 
since there're other features such as HTTP transport and Proxy support to add 
to the reporting task, I issued a separate JIRA 
[SiteToSiteProvenanceReportingTask to support Site-to-Site recently added 
features](https://issues.apache.org/jira/browse/NIFI-3030).


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657662#comment-15657662
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1208#discussion_r87630105
  
--- Diff: 
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
 ---
@@ -560,7 +560,8 @@ public SiteToSiteClient build() {
 }
 
 /**
- * @return the configured URL for the remote NiFi instance
+ * @return the configured URL for the remote NiFi instance.
+ * The URL string possibly contains multiple URL entries in 
comma-separated format.
  */
 public String getUrl() {
--- End diff --

This is concerning to me. This may be a breaking change for some, as it 
previously returned a String that was a valid URI or URL. It may not be 
anymore. I would rather see this return only the first URL, and have an 
additional method added: `List getUrls();`

Thoughts?


> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656964#comment-15656964
 ] 

ASF GitHub Bot commented on NIFI-3026:
--

GitHub user ijokarumawak opened a pull request:

https://github.com/apache/nifi/pull/1208

NIFI-3026: Support multiple remote target URLs

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijokarumawak/nifi nifi-3026

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1208


commit 8f09b9ca1db1e4ac2d722645304b5b4a682ccaa5
Author: Koji Kawamura 
Date:   2016-11-11T12:25:13Z

NIFI-3026: Support multiple remote target URLs




> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3026) S2S initial connection behavior enhancement

[Pierre Villard (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656478#comment-15656478
 ] 

Pierre Villard commented on NIFI-3026:
--

+1 thanks Koji, it'll be very useful!

> S2S initial connection behavior enhancement
> ---
>
> Key: NIFI-3026
> URL: https://issues.apache.org/jira/browse/NIFI-3026
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>
> s2s client behavior and initial connection improvement is needed.
> Current experience is this: I, as a client (e.g. minifi), connect to a nifi 
> cluster of e.g. 10 nodes. but i need to specify 1 node URL to establish this 
> connection. this node may not be available 100% and go down, in which case my 
> initial connection won't work.
> Once S2S makes the first connection, it then has a list of all nodes, and can 
> check their status. But first connection failure would be a concern if the 
> specified URL is somehow not working. Usually for these problems, the client 
> should be able to specify multiple urls (according to multiple target cluster 
> nodes), comma-separated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)