[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876583#comment-15876583
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1478
  
thanks peter.  i think this will be much easier and better aligned with the 
intent as the flow registry work progresses. 


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876569#comment-15876569
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user patricker closed the pull request at:

https://github.com/apache/nifi/pull/1478


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876570#comment-15876570
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user patricker commented on the issue:

https://github.com/apache/nifi/pull/1478
  
I'm going to just close it as unworkable right now. If someone wants to 
salvage this later feel free to use my code or start over.


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872287#comment-15872287
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user patricker commented on the issue:

https://github.com/apache/nifi/pull/1478
  
@joewitt @pvillard31 I made the changes and squashed the commits since 
about 50% of my changes were basically rolled back to the original code.

One issue... it doesn't work anymore. I'm looking for a little guidance on 
what I might have missed (of course since there is no functional change maybe 
it never worked and I was testing with an old build?). The error makes it sound 
like it's a standard, 'can't find your class' error. Since the code all lives 
in the same JAR I added a resource file to register the interface and class 
(it's in the commit), which made no difference.
Here is the stack trace I'm getting:

> Caused by: org.springframework.beans.factory.BeanCreationException: Error 
creating bean with name 'flowService': FactoryBean threw exception on object 
creation; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'flowController': FactoryBean threw exception on object creation; 
nested exception is java.lang.RuntimeException: Unable to create Flow 
Configuration DAO
at 
org.springframework.beans.factory.support.FactoryBeanRegistrySupport.doGetObjectFromFactoryBean(FactoryBeanRegistrySupport.java:175)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.beans.factory.support.FactoryBeanRegistrySupport.getObjectFromFactoryBean(FactoryBeanRegistrySupport.java:103)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.getObjectForBeanInstance(AbstractBeanFactory.java:1585)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:317)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1060)
 ~[spring-context-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.apache.nifi.web.contextlistener.ApplicationStartupContextListener.contextInitialized(ApplicationStartupContextListener.java:53)
 ~[na:na]
... 28 common frames omitted
Caused by: org.springframework.beans.factory.BeanCreationException: Error 
creating bean with name 'flowController': FactoryBean threw exception on object 
creation; nested exception is java.lang.RuntimeException: Unable to create Flow 
Configuration DAO
at 
org.springframework.beans.factory.support.FactoryBeanRegistrySupport.doGetObjectFromFactoryBean(FactoryBeanRegistrySupport.java:175)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.beans.factory.support.FactoryBeanRegistrySupport.getObjectFromFactoryBean(FactoryBeanRegistrySupport.java:103)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.getObjectForBeanInstance(AbstractBeanFactory.java:1585)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:317)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1060)
 ~[spring-context-4.2.4.RELEASE.jar:4.2.4.RELEASE]
at 
org.apache.nifi.spring.StandardFlowServiceFactoryBean.getObject(StandardFlowServiceFactoryBean.java:48)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.springframework.beans.factory.support.FactoryBeanRegistrySupport.doGetObjectFromFactoryBean(FactoryBeanRegistrySupport.java:168)
 ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE]
... 34 common frames omitted
Caused by: java.lang.RuntimeException: Unable to create Flow Configuration 
DAO
at 
org.apache.nifi.controller.FlowController.(FlowController.java:480) 
~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.controller.FlowController.createStandaloneInstance(FlowController.java:378)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.spring.FlowControllerFactoryBean.getObject(FlowControllerFactoryBean.java:74)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866193#comment-15866193
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user patricker commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1478#discussion_r101093314
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java
 ---
@@ -284,7 +251,7 @@ public boolean isRunning() {
 
 @Override
 public void start() throws LifeCycleStartException {
-writeLock.lock();
+   dao.writeProtectFlow();
--- End diff --

Thanks @joewitt, I'll move responsibility back over to the caller, along 
with your other feedback, and push an update.


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865040#comment-15865040
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1478#discussion_r100959147
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/persistence/FlowConfigurationDAO.java
 ---
@@ -25,11 +25,41 @@
 import org.apache.nifi.controller.UninheritableFlowException;
 import org.apache.nifi.controller.serialization.FlowSerializationException;
 import 
org.apache.nifi.controller.serialization.FlowSynchronizationException;
+import org.apache.nifi.encrypt.StringEncryptor;
+import org.apache.nifi.util.NiFiProperties;
 
 /**
  * Interface to define service methods for FlowController configuration.
  */
 public interface FlowConfigurationDAO {
+/**
+ * Performs any initialization needed. This should be called only by 
the
+ * framework.
+ * @param encryptor protected property encryptor/decryptor
+ * @param nifiProperties collection of NiFi properties
+ * @throws IOException thrown if Flow Configuration fails to initialize
+ */
+void initialize(StringEncryptor encryptor, NiFiProperties 
nifiProperties) throws IOException;
+
+/**
+ * Locks the Flow to prevent cross-thread Writeing
+ */
+void writeProtectFlow();
+
+/**
+ * Unlocks a Write locked flow
+ */
+void unWriteProtectFlow();
+
+/**
+ * Locks the Flow to prevent cross-thread Writeing
+ */
+void readProtectFlow();
--- End diff --

copy/paste error on the read/unread protection javadocs.


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865043#comment-15865043
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1478#discussion_r100958448
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java
 ---
@@ -225,33 +208,17 @@ private StandardFlowService(
 
 @Override
 public void saveFlowChanges() throws IOException {
-writeLock.lock();
-try {
-dao.save(controller);
-} finally {
-writeLock.unlock();
-}
+dao.save(controller);
--- End diff --

this no longer appears to have write lock protection


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865038#comment-15865038
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1478#discussion_r100958624
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java
 ---
@@ -284,7 +251,7 @@ public boolean isRunning() {
 
 @Override
 public void start() throws LifeCycleStartException {
-writeLock.lock();
+   dao.writeProtectFlow();
--- End diff --

this is leaking responsibilities.  The 'dao' should either be said to be 
thread safe or not.  The previous approach was not thread safe and thus we had 
locking around it as was in the previous implementation.  Here we have some 
cases guarded and some not but we're actually invoking a lock within the 
non-thread safe class now.  This approach is harder to reason over in my 
opinion.  We should either make the class thread safe and the caller does not 
need to do anything special or it should be not thread safe and the calling 
class should protect it (as it was).  Though this method shows we need to have 
some of that logic external so it makes sense to keep the locking as it was 
(controlled by the caller with the callee/dao being not thread safe by design)


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865039#comment-15865039
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1478#discussion_r100958475
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java
 ---
@@ -225,33 +208,17 @@ private StandardFlowService(
 
 @Override
 public void saveFlowChanges() throws IOException {
-writeLock.lock();
-try {
-dao.save(controller);
-} finally {
-writeLock.unlock();
-}
+dao.save(controller);
 }
 
 @Override
 public void saveFlowChanges(final OutputStream outStream) throws 
IOException {
-writeLock.lock();
-try {
-dao.save(controller, outStream);
-} finally {
-writeLock.unlock();
-}
+dao.save(controller, outStream);
 }
 
 @Override
 public void overwriteFlow(final InputStream is) throws IOException {
-writeLock.lock();
-try (final OutputStream output = Files.newOutputStream(flowXml, 
StandardOpenOption.WRITE, StandardOpenOption.CREATE);
-final OutputStream gzipOut = new 
GZIPOutputStream(output);) {
-FileUtils.copy(is, gzipOut);
-} finally {
-writeLock.unlock();
-}
+dao.overwriteFlow(is);
--- End diff --

this no longer has write lock protection


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865041#comment-15865041
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1478#discussion_r100959126
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/persistence/FlowConfigurationDAO.java
 ---
@@ -25,11 +25,41 @@
 import org.apache.nifi.controller.UninheritableFlowException;
 import org.apache.nifi.controller.serialization.FlowSerializationException;
 import 
org.apache.nifi.controller.serialization.FlowSynchronizationException;
+import org.apache.nifi.encrypt.StringEncryptor;
+import org.apache.nifi.util.NiFiProperties;
 
 /**
  * Interface to define service methods for FlowController configuration.
  */
 public interface FlowConfigurationDAO {
+/**
+ * Performs any initialization needed. This should be called only by 
the
+ * framework.
+ * @param encryptor protected property encryptor/decryptor
+ * @param nifiProperties collection of NiFi properties
+ * @throws IOException thrown if Flow Configuration fails to initialize
+ */
+void initialize(StringEncryptor encryptor, NiFiProperties 
nifiProperties) throws IOException;
+
+/**
+ * Locks the Flow to prevent cross-thread Writeing
+ */
+void writeProtectFlow();
--- End diff --

i mentioned it in a previous comment but the need to make locking calls 
available by callers into this class indicates something a bit awkward 
happening.  See previous comments.


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865042#comment-15865042
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user joewitt commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1478#discussion_r100958463
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java
 ---
@@ -225,33 +208,17 @@ private StandardFlowService(
 
 @Override
 public void saveFlowChanges() throws IOException {
-writeLock.lock();
-try {
-dao.save(controller);
-} finally {
-writeLock.unlock();
-}
+dao.save(controller);
 }
 
 @Override
 public void saveFlowChanges(final OutputStream outStream) throws 
IOException {
-writeLock.lock();
-try {
-dao.save(controller, outStream);
-} finally {
-writeLock.unlock();
-}
+dao.save(controller, outStream);
--- End diff --

this no longer has write lock protection


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862418#comment-15862418
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1478#discussion_r100668964
  
--- Diff: 
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
 ---
@@ -48,6 +48,7 @@
 
 // core properties
 public static final String PROPERTIES_FILE_PATH = 
"nifi.properties.file.path";
+public static final String FLOW_CONFIGURATION_IMPLEMENTATION = 
"nifi.flow.configuration.implementation";
--- End diff --

This needs to be added in nifi.properties file in nifi-resources.


> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3446) Make FlowConfigurationDAO Pluggable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855326#comment-15855326
 ] 

ASF GitHub Bot commented on NIFI-3446:
--

GitHub user patricker opened a pull request:

https://github.com/apache/nifi/pull/1478

NIFI-3446 FlowConfigurationDAO Changes

Allows for Flow Configuration (flow.xml.gz) to be pluggable. There should 
be no "functional" changes as a result of this code change.

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/patricker/nifi NIFI-3446

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1478


commit e346336161c6c5220661d2ae31e91391c40c54d3
Author: patricker 
Date:   2017-02-07T03:49:28Z

FlowConfigurationDAO Changes




> Make FlowConfigurationDAO Pluggable
> ---
>
> Key: NIFI-3446
> URL: https://issues.apache.org/jira/browse/NIFI-3446
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
> Fix For: 1.2.0
>
>
> FlowConfigurationDAO should be pluggable so that an alternate Flow 
> Configuration storage layer can be used.
> This may be a multistep process, this ticket does the first step by moving 
> more of the functionality into FlowConfigurationDAO, allows users to override 
> (optional) properties in nifi.properties.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)