[jira] [Commented] (NIFI-3455) GenerateTableFetch fails for very large row counts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866290#comment-15866290
 ] 

ASF GitHub Bot commented on NIFI-3455:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1499


> GenerateTableFetch fails for very large row counts
> --
>
> Key: NIFI-3455
> URL: https://issues.apache.org/jira/browse/NIFI-3455
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> When retrieving the row count for the total number of rows to page over 
> GenerateTableFetch gets the row count as an integer. In some cases the value 
> returned is greater then the maximum value of Int32 causing a looping of the 
> value, resulting in a negative number.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3455) GenerateTableFetch fails for very large row counts

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866287#comment-15866287
 ] 

ASF subversion and git services commented on NIFI-3455:
---

Commit 9cfc13423dd1a18dd4f4554eb0fb0d5b300c3e6e in nifi's branch 
refs/heads/master from patricker
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9cfc134 ]

NIFI-3455 Large row count paging

This closes #1499.


> GenerateTableFetch fails for very large row counts
> --
>
> Key: NIFI-3455
> URL: https://issues.apache.org/jira/browse/NIFI-3455
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> When retrieving the row count for the total number of rows to page over 
> GenerateTableFetch gets the row count as an integer. In some cases the value 
> returned is greater then the maximum value of Int32 causing a looping of the 
> value, resulting in a negative number.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3455) GenerateTableFetch fails for very large row counts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866280#comment-15866280
 ] 

ASF GitHub Bot commented on NIFI-3455:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1499
  
 merging, thanks @patricker 


> GenerateTableFetch fails for very large row counts
> --
>
> Key: NIFI-3455
> URL: https://issues.apache.org/jira/browse/NIFI-3455
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> When retrieving the row count for the total number of rows to page over 
> GenerateTableFetch gets the row count as an integer. In some cases the value 
> returned is greater then the maximum value of Int32 causing a looping of the 
> value, resulting in a negative number.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3455) GenerateTableFetch fails for very large row counts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863934#comment-15863934
 ] 

ASF GitHub Bot commented on NIFI-3455:
--

Github user patricker commented on the issue:

https://github.com/apache/nifi/pull/1499
  
@pvillard31 Thanks for the review. Ever since the last IntelliJ update my 
CheckStyle plugin has been acting up.  Should all be fixed now.


> GenerateTableFetch fails for very large row counts
> --
>
> Key: NIFI-3455
> URL: https://issues.apache.org/jira/browse/NIFI-3455
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> When retrieving the row count for the total number of rows to page over 
> GenerateTableFetch gets the row count as an integer. In some cases the value 
> returned is greater then the maximum value of Int32 causing a looping of the 
> value, resulting in a negative number.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3455) GenerateTableFetch fails for very large row counts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862401#comment-15862401
 ] 

ASF GitHub Bot commented on NIFI-3455:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1499
  
Hey @patricker,

It looks good to me, thanks for the PR. Could you fix the checkstyle 
violations?


[WARNING] 
src/test/java/org/apache/nifi/processors/standard/TestGenerateTableFetch.java[40:8]
 (imports) UnusedImports: Unused import - java.sql.JDBCType.
[WARNING] 
src/test/java/org/apache/nifi/processors/standard/TestGenerateTableFetch.java[41:8]
 (imports) UnusedImports: Unused import - java.sql.PreparedStatement.
[WARNING] 
src/test/java/org/apache/nifi/processors/standard/TestGenerateTableFetch.java[57]
 (imports) AvoidStarImport: Using the '.*' form of import should be avoided - 
org.mockito.Mockito.*.


Thanks.


> GenerateTableFetch fails for very large row counts
> --
>
> Key: NIFI-3455
> URL: https://issues.apache.org/jira/browse/NIFI-3455
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> When retrieving the row count for the total number of rows to page over 
> GenerateTableFetch gets the row count as an integer. In some cases the value 
> returned is greater then the maximum value of Int32 causing a looping of the 
> value, resulting in a negative number.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3455) GenerateTableFetch fails for very large row counts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861464#comment-15861464
 ] 

ASF GitHub Bot commented on NIFI-3455:
--

GitHub user patricker opened a pull request:

https://github.com/apache/nifi/pull/1499

NIFI-3455 Large row count paging

NIFI-3455 Fetch Table Adapter fails without error for very large row counts.

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/patricker/nifi NIFI-3455

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1499


commit 01e2038cc23ac4527e22d39034affeb63eef4fd4
Author: patricker 
Date:   2017-02-09T17:45:01Z

NIFI-3455 Large row count paging




> GenerateTableFetch fails for very large row counts
> --
>
> Key: NIFI-3455
> URL: https://issues.apache.org/jira/browse/NIFI-3455
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> When retrieving the row count for the total number of rows to page over 
> GenerateTableFetch gets the row count as an integer. In some cases the value 
> returned is greater then the maximum value of Int32 causing a looping of the 
> value, resulting in a negative number.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)