[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958221#comment-15958221
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1586


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958220#comment-15958220
 ] 

ASF subversion and git services commented on NIFI-3586:
---

Commit 3386839ebc4a16029fc40a1b2702017b1ab39fa3 in nifi's branch 
refs/heads/master from [~puspendu.baner...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=3386839 ]

NIFI-3586: Fix for retrieving ProcessID for NiFi under windows.

This closes #1586

Signed-off-by: Tony Kurc 


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958042#comment-15958042
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@trkurc Done


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956289#comment-15956289
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@trkurc Seems I missed it. 
Apache uses a variety of Util and Utils, although mostly Utils:
- org.apache.commons.modeler.util.DomUtil
- org.apache.commons.modeler.util.IntrospectionUtils
- org.apache.commons.io.FileSystemUtils
- org.apache.lucene.wordnet.AnalyzerUtil
- org.apache.lucene.util.ArrayUtil
- org.apache.lucene.xmlparser.DOMUtils
and as in NiFi we are using Utils, let me make the change from OSUtil to 
OSUtils.
I shall do that tomorrow before I start to work on issue 3593 and let you 
know.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956278#comment-15956278
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@PuspenduBanerjee  - Did you see my comment on thinking about renaming to 
OSUtils. Had you considered that?

Other than that, it looks good.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956142#comment-15956142
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@trkurc Fixed and travis Build is working fine


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956096#comment-15956096
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@trkurc yes saw that, but it was too late lastnight, fixing now.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956094#comment-15956094
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on the issue:

https://github.com/apache/nifi/pull/1586
  
The content of the LICENSE and NOTICE look good. Did you see my comment on 
thinking about renaming to OSUtils. Had you considered that?

Building with the contrib-check profile does not complete (you should be 
able to replicate with `mvn clean install -Pcontrib-check -pl nifi-bootstrap`). 
The javadoc params are missing descriptions, and there are a couple trailing 
whitespaces. 

```
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[32] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[33] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[35] 
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[60] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[61] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[63] 
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[88] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[89] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[91] 
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
```


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954565#comment-15954565
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109578440
  
--- Diff: nifi-assembly/NOTICE ---
@@ -373,6 +373,11 @@ The following binary components are provided under the 
Apache Software License v
 The following NOTICE information applies:
   Apache Commons Math
   Copyright 2001-2012 The Apache Software Foundation
+  
+  (ASLv2) Java Native Access Platform
+The following NOTICE information applies:
+  Java Native Access Platform
+  Copyright 2013 Timothy Wall, Matthias Bläsing
--- End diff --

@trkurc Review needed for "Copyright 2013 Timothy Wall, Matthias Bläsing" 
part.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954439#comment-15954439
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109559111
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.bootstrap.util;
+
+import java.lang.reflect.Field;
+
+import org.slf4j.Logger;
+import com.sun.jna.Pointer;
+import com.sun.jna.platform.win32.Kernel32;
+import com.sun.jna.platform.win32.WinNT;
+
+/**
+ * OS specific utilities with generic method interfaces
+ */
+public final class OSUtil {
--- End diff --

If I am reading the JNA license correctly, it looks like versions after 4.0 
are ASLv2, and possibly dual licensed (lgpl and ASLv2). Per 
https://www.apache.org/legal/resolved#mutually-exclusive , it would appear just 
ASLv2 would need to be noted. And since libffi is included in JNA, and is MIT 
style, I would expect it would need to be called out as well. If you look at 
nifi-assembly, there are already many dependencies called out and listed if you 
want examples to reference


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954421#comment-15954421
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109557567
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.bootstrap.util;
+
+import java.lang.reflect.Field;
+
+import org.slf4j.Logger;
+import com.sun.jna.Pointer;
+import com.sun.jna.platform.win32.Kernel32;
+import com.sun.jna.platform.win32.WinNT;
+
+/**
+ * OS specific utilities with generic method interfaces
+ */
+public final class OSUtil {
--- End diff --

So, net net, I am seeing 3 Licences in play:

- ASLv2
- LGPL v2.1
- MIT [ for libffi, OpenJDK and Cassandra is already using this]
So, please enlighten me, if I really need to add any License/Notice in 
assembly.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954399#comment-15954399
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109555028
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.bootstrap.util;
+
+import java.lang.reflect.Field;
+
+import org.slf4j.Logger;
+import com.sun.jna.Pointer;
+import com.sun.jna.platform.win32.Kernel32;
+import com.sun.jna.platform.win32.WinNT;
+
+/**
+ * OS specific utilities with generic method interfaces
+ */
+public final class OSUtil {
--- End diff --

@trkurc From what I can tell you are correct. A quick dive into 
java-native-access shows an MIT style license. Top level POM includes the 
native module, which runs an ant build ( maven-antrun-plugin in the target 
compile-native) which builds the subtree, libff -- where @trkurc saw the MIT 
license. Ant will build the native libraries through the make files, but that 
still appears bundled.  

To further verify this you can look at the jar from Maven central, which 
shows the packaged shared objects.




> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954317#comment-15954317
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on the issue:

https://github.com/apache/nifi/pull/1586
  
Sorry for the delay on this one has been a bit challenging, I have been 
looking into the licensing of the JNA and some of its dependencies. 


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954315#comment-15954315
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109320752
  
--- Diff: nifi-bootstrap/pom.xml ---
@@ -47,5 +47,10 @@ language governing permissions and limitations under the 
License. -->
 org.apache.nifi
 nifi-properties-loader
 
+
+net.java.dev.jna
+   jna-platform
+   4.3.0
--- End diff --

I'm also a little concerned about the licensing of this one, I've had to 
dig in a bit into how it builds and brings into its packages. I'll keep going 
and see what I find.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954316#comment-15954316
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109320816
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.bootstrap.util;
+
+import java.lang.reflect.Field;
+
+import org.slf4j.Logger;
+import com.sun.jna.Pointer;
+import com.sun.jna.platform.win32.Kernel32;
+import com.sun.jna.platform.win32.WinNT;
+
+/**
+ * OS specific utilities with generic method interfaces
+ */
+public final class OSUtil {
--- End diff --

Very minor comment - other utility classes in NiFi have been suffixed with 
Utils versus "Util"


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954314#comment-15954314
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109322091
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.bootstrap.util;
+
+import java.lang.reflect.Field;
+
+import org.slf4j.Logger;
+import com.sun.jna.Pointer;
+import com.sun.jna.platform.win32.Kernel32;
+import com.sun.jna.platform.win32.WinNT;
+
+/**
+ * OS specific utilities with generic method interfaces
+ */
+public final class OSUtil {
+
+private static Long getUnicesPid(final Process process, final Logger 
logger) {
+try {
+final Class procClass = process.getClass();
+final Field pidField = procClass.getDeclaredField("pid");
+pidField.setAccessible(true);
+final Object pidObject = pidField.get(process);
+
+logger.debug("PID Object = {}", pidObject);
+
+if (pidObject instanceof Number) {
+return ((Number) pidObject).longValue();
+}
+return null;
+} catch (final IllegalAccessException | NoSuchFieldException nsfe) 
{
+logger.debug("Could not find PID for child process due to {}", 
nsfe);
+return null;
+}
+}
+
+private static Long getWindowsProcessId(final Process process, final 
Logger logger) {
+/* determine the pid on windows plattforms */
+try {
+Field f = process.getClass().getDeclaredField("handle");
+f.setAccessible(true);
+long handl = f.getLong(process);
+
+Kernel32 kernel = Kernel32.INSTANCE;
+WinNT.HANDLE handle = new WinNT.HANDLE();
+handle.setPointer(Pointer.createConstant(handl));
+int ret = kernel.GetProcessId(handle);
+logger.debug("Detected pid: {}", ret);
+return Long.valueOf(ret);
+} catch (final IllegalAccessException | NoSuchFieldException nsfe) 
{
+logger.debug("Could not find PID for child process due to {}", 
nsfe);
+}
+return null;
+}
+
+public static Long getProcessId(final Process process, final Logger 
logger) {
--- End diff --

@PuspenduBanerjee - With this dependency, we'll have to put something in 
the LICENSE and NOTICE for the nifi-assembly, as it will pull this in and some 
transitive dependencies. It is ASLv2 license, but it appears it may pull in 
libffi which is a MIT style license 
(https://github.com/java-native-access/jna/tree/4.3.0/native/libffi). How they 
are building their native libs that are in their jars are not a bit challenging 
without diving in deeper than I'd like to. @phrocker may have seen a build 
process like that here: 
https://github.com/java-native-access/jna/tree/4.3.0/native and may be able to 
confirm that it is bundled in


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954313#comment-15954313
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109320713
  
--- Diff: nifi-bootstrap/pom.xml ---
@@ -47,5 +47,10 @@ language governing permissions and limitations under the 
License. -->
 org.apache.nifi
 nifi-properties-loader
 
+
+net.java.dev.jna
+   jna-platform
+   4.3.0
--- End diff --

There is a new version of this, '4.4.0', it didn't look like it changed the 
methods you used, but it may be worth bumping it up.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952859#comment-15952859
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r109320687
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.bootstrap.util;
+
+import java.lang.reflect.Field;
+
+import org.slf4j.Logger;
+import com.sun.jna.Pointer;
+import com.sun.jna.platform.win32.Kernel32;
+import com.sun.jna.platform.win32.WinNT;
+
+/**
+ * OS specific utilities with generic method interfaces
+ */
+public final class OSUtil {
+
+private static Long getUnicesPid(final Process process, final Logger 
logger) {
+try {
+final Class procClass = process.getClass();
+final Field pidField = procClass.getDeclaredField("pid");
+pidField.setAccessible(true);
+final Object pidObject = pidField.get(process);
+
+logger.debug("PID Object = {}", pidObject);
+
+if (pidObject instanceof Number) {
+return ((Number) pidObject).longValue();
+}
+return null;
+} catch (final IllegalAccessException | NoSuchFieldException nsfe) 
{
+logger.debug("Could not find PID for child process due to {}", 
nsfe);
+return null;
+}
+}
+
+private static Long getWindowsProcessId(final Process process, final 
Logger logger) {
+/* determine the pid on windows plattforms */
+try {
+Field f = process.getClass().getDeclaredField("handle");
+f.setAccessible(true);
+long handl = f.getLong(process);
+
+Kernel32 kernel = Kernel32.INSTANCE;
+WinNT.HANDLE handle = new WinNT.HANDLE();
+handle.setPointer(Pointer.createConstant(handl));
+int ret = kernel.GetProcessId(handle);
+logger.debug("Detected pid: {}", ret);
+return Long.valueOf(ret);
+} catch (final IllegalAccessException | NoSuchFieldException nsfe) 
{
+logger.debug("Could not find PID for child process due to {}", 
nsfe);
+}
+return null;
+}
+
+public static Long getProcessId(final Process process, final Logger 
logger) {
--- End diff --

I know it wasn't there before when this was a private method before, but 
I'd LOVE to see a javadoc comment to describe the contract for this method. I 
think returning null is a bit counter-intuitive


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948169#comment-15948169
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@trkurc You and Aldrin are tagged in most of my PRs. Sometimes we miss 
things due to long working day :)


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948165#comment-15948165
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user trkurc commented on the issue:

https://github.com/apache/nifi/pull/1586
  
I somehow missed being tagged on this. I can review

On Mar 29, 2017 8:19 PM, "Puspendu Banerjee" 
wrote:

> @alopresto  / @joewitt
>  could it be merged?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 

> .
>



> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948145#comment-15948145
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@alopresto / @joewitt  could it be merged?


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924737#comment-15924737
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@mosermw here goes one more Windows specific issue.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907922#comment-15907922
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
tagging @trkurc & @apiri for checking in.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906011#comment-15906011
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r105522726
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1131,9 +1131,9 @@ public boolean accept(final File dir, final String 
filename) {
 process = builder.start();
 handleLogging(process);
 
-pid = getPid(process, defaultLogger);
+pid = OSUtil.getProcessId(process, defaultLogger);
 if (pid == null) {
-cmdLogger.info("Launched Apache NiFi but could not 
obtain the Process ID");
+cmdLogger.error("Launched Apache NiFi but could 
not obtain the Process ID");
--- End diff --

Hi @alopresto , it should be warn. good catch. I shall change in-place.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906000#comment-15906000
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r105521647
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1131,9 +1131,9 @@ public boolean accept(final File dir, final String 
filename) {
 process = builder.start();
 handleLogging(process);
 
-pid = getPid(process, defaultLogger);
+pid = OSUtil.getProcessId(process, defaultLogger);
 if (pid == null) {
-cmdLogger.info("Launched Apache NiFi but could not 
obtain the Process ID");
+cmdLogger.error("Launched Apache NiFi but could 
not obtain the Process ID");
--- End diff --

Why is this at `error` level when the same message above is at `warn`?


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905737#comment-15905737
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@joewitt Another easy-fix before doing something more complex.
I am not sure why do we need travis build for BR, FR, JP.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905728#comment-15905728
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

GitHub user PuspenduBanerjee opened a pull request:

https://github.com/apache/nifi/pull/1586

NIFI-3586: Fix for retrieving ProcessID for NiFi under windows.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [X] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PuspenduBanerjee/nifi NIFI-3586

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1586


commit 5bb912e111bb476fec9ccc19abb100881cf6b747
Author: Puspendu Banerjee 
Date:   2017-03-10T21:09:49Z

NIFI-3586: Fix for retrieving ProcessID for NiFi under windows.




> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)