[jira] [Commented] (NIFI-3925) Add Template list with long template name
[ https://issues.apache.org/jira/browse/NIFI-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023617#comment-16023617 ] ASF GitHub Bot commented on NIFI-3925: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1848 Thanks @scottyaslan. This has been merged to master. > Add Template list with long template name > - > > Key: NIFI-3925 > URL: https://issues.apache.org/jira/browse/NIFI-3925 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: Mark Bean >Assignee: Scott Aslan >Priority: Minor > > If a template has a very long name (roughly 40 characters or more), the > dropdown list of templates in "Add Template" does not display properly. The > "?" rollover which displays the template description is shown on the next > line. In effect, the long-named template line has no "?" rollover, and the > next template line has two adjacent "?" rollovers (one corresponding to the > previous, long-named template and one corresponding to itself.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3925) Add Template list with long template name
[ https://issues.apache.org/jira/browse/NIFI-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023612#comment-16023612 ] ASF GitHub Bot commented on NIFI-3925: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1848 > Add Template list with long template name > - > > Key: NIFI-3925 > URL: https://issues.apache.org/jira/browse/NIFI-3925 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: Mark Bean >Assignee: Scott Aslan >Priority: Minor > > If a template has a very long name (roughly 40 characters or more), the > dropdown list of templates in "Add Template" does not display properly. The > "?" rollover which displays the template description is shown on the next > line. In effect, the long-named template line has no "?" rollover, and the > next template line has two adjacent "?" rollovers (one corresponding to the > previous, long-named template and one corresponding to itself.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3925) Add Template list with long template name
[ https://issues.apache.org/jira/browse/NIFI-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023609#comment-16023609 ] ASF subversion and git services commented on NIFI-3925: --- Commit 86728bac7ef091dba79cd3ffd3219c80f4fca8ba in nifi's branch refs/heads/master from [~scottyaslan] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=86728ba ] [NIFI-3925] for the jquery.combo plugin: update the calculation of the width of the combo box options overlay and also updated the plugins styles to now leverage the css calc() to determine the exact width of .combotext and .combo-option-text elements. This closes #1848 > Add Template list with long template name > - > > Key: NIFI-3925 > URL: https://issues.apache.org/jira/browse/NIFI-3925 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: Mark Bean >Assignee: Scott Aslan >Priority: Minor > > If a template has a very long name (roughly 40 characters or more), the > dropdown list of templates in "Add Template" does not display properly. The > "?" rollover which displays the template description is shown on the next > line. In effect, the long-named template line has no "?" rollover, and the > next template line has two adjacent "?" rollovers (one corresponding to the > previous, long-named template and one corresponding to itself.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3925) Add Template list with long template name
[ https://issues.apache.org/jira/browse/NIFI-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022910#comment-16022910 ] ASF GitHub Bot commented on NIFI-3925: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1848 @scottyaslan Would it be possible to update this PR to not take a percentage based approach? The component(s) selected by the combo plugin can have any width. Taking a percentage based approach may unnecessarily limit the text width. We should be able to update the corresponding JS file to set an appropriate width based on the incoming element. We are already doing this when we set the width of the container element for the combo options [1]. When setting the width of the option text element we'll need to update the width accordingly based on whether there is a description or not. [1] https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/combo/jquery.combo.js#L165 > Add Template list with long template name > - > > Key: NIFI-3925 > URL: https://issues.apache.org/jira/browse/NIFI-3925 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: Mark Bean >Assignee: Scott Aslan >Priority: Minor > > If a template has a very long name (roughly 40 characters or more), the > dropdown list of templates in "Add Template" does not display properly. The > "?" rollover which displays the template description is shown on the next > line. In effect, the long-named template line has no "?" rollover, and the > next template line has two adjacent "?" rollovers (one corresponding to the > previous, long-named template and one corresponding to itself.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3925) Add Template list with long template name
[ https://issues.apache.org/jira/browse/NIFI-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022840#comment-16022840 ] ASF GitHub Bot commented on NIFI-3925: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1848 Will review... > Add Template list with long template name > - > > Key: NIFI-3925 > URL: https://issues.apache.org/jira/browse/NIFI-3925 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: Mark Bean >Assignee: Scott Aslan >Priority: Minor > > If a template has a very long name (roughly 40 characters or more), the > dropdown list of templates in "Add Template" does not display properly. The > "?" rollover which displays the template description is shown on the next > line. In effect, the long-named template line has no "?" rollover, and the > next template line has two adjacent "?" rollovers (one corresponding to the > previous, long-named template and one corresponding to itself.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3925) Add Template list with long template name
[ https://issues.apache.org/jira/browse/NIFI-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021943#comment-16021943 ] ASF GitHub Bot commented on NIFI-3925: -- GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1848 [NIFI-3925] bound width of combo options drop down text Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi NIFI-3925 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1848.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1848 commit dd73254c0b8280670e70ff98d1646f56c47f739e Author: Scott Aslan Date: 2017-05-23T21:54:40Z [NIFI-3925] bound width of combo options drop down text > Add Template list with long template name > - > > Key: NIFI-3925 > URL: https://issues.apache.org/jira/browse/NIFI-3925 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: Mark Bean >Assignee: Scott Aslan >Priority: Minor > > If a template has a very long name (roughly 40 characters or more), the > dropdown list of templates in "Add Template" does not display properly. The > "?" rollover which displays the template description is shown on the next > line. In effect, the long-named template line has no "?" rollover, and the > next template line has two adjacent "?" rollovers (one corresponding to the > previous, long-named template and one corresponding to itself.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
