[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139034#comment-16139034
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/2065
  
thank you @jtstorck !


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138944#comment-16138944
 ] 

ASF subversion and git services commented on NIFI-4255:
---

Commit acee2627ca562a4dc94adfe9836ecd32a4666902 in nifi's branch 
refs/heads/master from [~YolandaMDavis]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=acee262 ]

NIFI-4255 - Added flag to allow migration of existing (source) acls to 
destination, update to documentation
Added build-helper-maven-plugin to nifi-toolkit-zookeeper-migrator pom to build 
groovy test code
Moved spock spec from src/test/java to src/test/groovy
Minor code formatting updates to ZooKeeperMigrator.java

This closes #2065


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138945#comment-16138945
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2065


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138936#comment-16138936
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user jtstorck commented on the issue:

https://github.com/apache/nifi/pull/2065
  
+1 LGTM

Made a few minor formatting changes, and moved the spock spec from 
src/test/java to src/test/groovy.

To test this, I ran a KDC and ZK server in a docker container with two 
principals.  I created a node using principal1 that was sasl-secured via 
principal1, and used the zk migrator to export it to a json file.  Then, I 
manually modified the json file to change the ACL on the node I created to set 
the owner to principal2.  I then used the zk migrator to send the updated json 
to ZK, using the --ignore-source and --use-existing-acl options.  After 
attempting to access the node as principal1 (which failed as expected), I was 
able to access the node as princopal2 (as expected).


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136871#comment-16136871
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user YolandaMDavis commented on the issue:

https://github.com/apache/nifi/pull/2065
  
spoke with @jtstorck offline and we discussed refactoring a bit to ensure 
that the logic for determining acls are externalized and staged within the 
CompletableFuture chain.  Committing those changes shortly


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125771#comment-16125771
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user YolandaMDavis commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2065#discussion_r132969031
  
--- Diff: 
nifi-toolkit/nifi-toolkit-zookeeper-migrator/src/main/java/org/apache/nifi/toolkit/zkmigrator/ZooKeeperMigrator.java
 ---
@@ -269,15 +269,23 @@ private String ensureNodeExists(ZooKeeper zooKeeper, 
String path, CreateMode cre
 }
 }
 
-private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode) {
-// For the NiFi use case, all nodes will be migrated to 
CREATOR_ALL_ACL
+private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL) {
+// If useExistingACL is false, for the NiFi use cases, all nodes 
will be migrated to CREATOR_ALL_ACL
 final DataStatAclNode migratedNode = new 
DataStatAclNode(node.getPath(), node.getData(), node.getStat(),
-destinationAuthMode.equals(AuthMode.OPEN) ? 
ZooDefs.Ids.OPEN_ACL_UNSAFE : ZooDefs.Ids.CREATOR_ALL_ACL,
+determineNodeACL(node,destinationAuthMode,useExistingACL),
 node.getEphemeralOwner());
 LOGGER.info("transformed original node {} to {}", node, 
migratedNode);
 return migratedNode;
 }
 
+private List determineNodeACL(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL){
--- End diff --

@jtstorck Rather than have a separate stage I ended up combining this with 
the previous method.  Didn't really see the value of me having it separated out 
in the first place . 


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124635#comment-16124635
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user YolandaMDavis commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2065#discussion_r132821753
  
--- Diff: 
nifi-toolkit/nifi-toolkit-zookeeper-migrator/src/main/java/org/apache/nifi/toolkit/zkmigrator/ZooKeeperMigrator.java
 ---
@@ -269,15 +269,23 @@ private String ensureNodeExists(ZooKeeper zooKeeper, 
String path, CreateMode cre
 }
 }
 
-private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode) {
-// For the NiFi use case, all nodes will be migrated to 
CREATOR_ALL_ACL
+private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL) {
+// If useExistingACL is false, for the NiFi use cases, all nodes 
will be migrated to CREATOR_ALL_ACL
 final DataStatAclNode migratedNode = new 
DataStatAclNode(node.getPath(), node.getData(), node.getStat(),
-destinationAuthMode.equals(AuthMode.OPEN) ? 
ZooDefs.Ids.OPEN_ACL_UNSAFE : ZooDefs.Ids.CREATOR_ALL_ACL,
+determineNodeACL(node,destinationAuthMode,useExistingACL),
 node.getEphemeralOwner());
 LOGGER.info("transformed original node {} to {}", node, 
migratedNode);
 return migratedNode;
 }
 
+private List determineNodeACL(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL){
--- End diff --

Sure no problem


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124582#comment-16124582
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user jtstorck commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2065#discussion_r132818810
  
--- Diff: 
nifi-toolkit/nifi-toolkit-zookeeper-migrator/src/main/java/org/apache/nifi/toolkit/zkmigrator/ZooKeeperMigrator.java
 ---
@@ -269,15 +269,23 @@ private String ensureNodeExists(ZooKeeper zooKeeper, 
String path, CreateMode cre
 }
 }
 
-private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode) {
-// For the NiFi use case, all nodes will be migrated to 
CREATOR_ALL_ACL
+private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL) {
+// If useExistingACL is false, for the NiFi use cases, all nodes 
will be migrated to CREATOR_ALL_ACL
 final DataStatAclNode migratedNode = new 
DataStatAclNode(node.getPath(), node.getData(), node.getStat(),
-destinationAuthMode.equals(AuthMode.OPEN) ? 
ZooDefs.Ids.OPEN_ACL_UNSAFE : ZooDefs.Ids.CREATOR_ALL_ACL,
+determineNodeACL(node,destinationAuthMode,useExistingACL),
 node.getEphemeralOwner());
 LOGGER.info("transformed original node {} to {}", node, 
migratedNode);
 return migratedNode;
 }
 
+private List determineNodeACL(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL){
--- End diff --

Rather than having this method get invoked from transformNode, can you do 
this as a stage in the completable future before transformNode is invoked?  I'd 
like to keep all the method coordination controlled by the CompletableFuture 
stages rather than having methods invoke each other.


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120043#comment-16120043
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user jtstorck commented on the issue:

https://github.com/apache/nifi/pull/2065
  
Reviewing...


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117831#comment-16117831
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

GitHub user YolandaMDavis opened a pull request:

https://github.com/apache/nifi/pull/2065

NIFI-4255 - added flag to allow migration of existing (source) acls

Testing Recommendations:

Using a secured Zookeeper instance with predefined paths/znodes use the ZK 
Migrator to first export a json file containing nodes information.  Then that 
json file can be edited to alter or add acls to existing paths.  The file can 
then be reapplied to the source ZK server using the following example command:

`./zk-migrator.sh -s -z :2181/nifi -f 
 -k  --ignore-source 
--use-existing-acl`

Confirm that acls are applied as expected using the zkCli.sh (or some other 
ZK Client tool)

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ x] Does your PR title start with NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YolandaMDavis/nifi NIFI-4255

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2065.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2065


commit d4f4c78d669d6d2ab30692af15de7606191da545
Author: Yolanda M. Davis 
Date:   2017-08-08T04:03:42Z

NIFI-4255 - added flag to allow migration of existing (source) acls to 
destination
NIFI-4255 - update to documentation




> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)