[jira] [Commented] (NIFI-4278) ValidateXml - add validation error as an attribute of invalid flow files
[ https://issues.apache.org/jira/browse/NIFI-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121040#comment-16121040 ] ASF GitHub Bot commented on NIFI-4278: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2069 > ValidateXml - add validation error as an attribute of invalid flow files > > > Key: NIFI-4278 > URL: https://issues.apache.org/jira/browse/NIFI-4278 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > > The idea is to have an attribute containing the validation error message for > flow files routed to the invalid relationship. > I initially added a specific property allowing the user to decide if this > attribute should be added or not... but in the end I removed it as I think > this is a desired behaviour in any situation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4278) ValidateXml - add validation error as an attribute of invalid flow files
[ https://issues.apache.org/jira/browse/NIFI-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121039#comment-16121039 ] ASF subversion and git services commented on NIFI-4278: --- Commit 6ff8321cf71fb07a5d961a30b035e31c48829c91 in nifi's branch refs/heads/master from [~pvillard] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=6ff8321 ] NIFI-4278 - add error message to invalid FFs in ValidateXml This closes #2069. Signed-off-by: Andy LoPresto > ValidateXml - add validation error as an attribute of invalid flow files > > > Key: NIFI-4278 > URL: https://issues.apache.org/jira/browse/NIFI-4278 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > > The idea is to have an attribute containing the validation error message for > flow files routed to the invalid relationship. > I initially added a specific property allowing the user to decide if this > attribute should be added or not... but in the end I removed it as I think > this is a desired behaviour in any situation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4278) ValidateXml - add validation error as an attribute of invalid flow files
[ https://issues.apache.org/jira/browse/NIFI-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121038#comment-16121038 ] ASF GitHub Bot commented on NIFI-4278: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2069 I ran this with a simple `GenFF/ValidateXML/LogAttr` flow and it looks great. Ran `contrib-check` and all tests pass. +1, merging. ``` -- Standard FlowFile Attributes Key: 'entryDate' Value: 'Wed Aug 09 21:04:20 PDT 2017' Key: 'lineageStartDate' Value: 'Wed Aug 09 21:04:20 PDT 2017' Key: 'fileSize' Value: '24' FlowFile Attribute Map Content Key: 'filename' Value: '204498845083507' Key: 'path' Value: './' Key: 'uuid' Value: 'de5ad824-cea7-442e-8f01-ca01b9aa6e06' Key: 'validatexml.invalid.error' Value: 'cvc-elt.1: Cannot find the declaration of element 'this'.' -- is not valid ``` > ValidateXml - add validation error as an attribute of invalid flow files > > > Key: NIFI-4278 > URL: https://issues.apache.org/jira/browse/NIFI-4278 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > > The idea is to have an attribute containing the validation error message for > flow files routed to the invalid relationship. > I initially added a specific property allowing the user to decide if this > attribute should be added or not... but in the end I removed it as I think > this is a desired behaviour in any situation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4278) ValidateXml - add validation error as an attribute of invalid flow files
[ https://issues.apache.org/jira/browse/NIFI-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121016#comment-16121016 ] ASF GitHub Bot commented on NIFI-4278: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2069 Reviewing... > ValidateXml - add validation error as an attribute of invalid flow files > > > Key: NIFI-4278 > URL: https://issues.apache.org/jira/browse/NIFI-4278 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > > The idea is to have an attribute containing the validation error message for > flow files routed to the invalid relationship. > I initially added a specific property allowing the user to decide if this > attribute should be added or not... but in the end I removed it as I think > this is a desired behaviour in any situation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4278) ValidateXml - add validation error as an attribute of invalid flow files
[ https://issues.apache.org/jira/browse/NIFI-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119692#comment-16119692 ] ASF GitHub Bot commented on NIFI-4278: -- GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2069 NIFI-4278 - add error message to invalid FFs in ValidateXml Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-4278 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2069.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2069 commit 9762c8813c188b9c0714aa47867cc8f1cff9de8c Author: Pierre Villard Date: 2017-08-09T10:34:24Z NIFI-4278 - add error message to invalid FFs in ValidateXml > ValidateXml - add validation error as an attribute of invalid flow files > > > Key: NIFI-4278 > URL: https://issues.apache.org/jira/browse/NIFI-4278 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > > The idea is to have an attribute containing the validation error message for > flow files routed to the invalid relationship. > I initially added a specific property allowing the user to decide if this > attribute should be added or not... but in the end I removed it as I think > this is a desired behaviour in any situation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)