[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308281#comment-16308281 ] ASF GitHub Bot commented on NIFI-: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2358 Thanks @alopresto! Closing... > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Matt Gilman >Assignee: Matt Gilman > Fix For: 1.5.0 > > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308282#comment-16308282 ] ASF GitHub Bot commented on NIFI-: -- Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/2358 > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Matt Gilman >Assignee: Matt Gilman > Fix For: 1.5.0 > > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308178#comment-16308178 ] ASF GitHub Bot commented on NIFI-: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2358 @mcgilman there was a space in the magic incantation to close this PR. Please close it at your convenience. The merge commit is [10755e2](https://github.com/apache/nifi/commit/b7c9c88f9f786f9a84b0c1dc34026194010755e2). > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Matt Gilman >Assignee: Matt Gilman > Fix For: 1.5.0 > > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308174#comment-16308174 ] ASF subversion and git services commented on NIFI-: --- Commit b7c9c88f9f786f9a84b0c1dc34026194010755e2 in nifi's branch refs/heads/master from [~mcgilman] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b7c9c88 ] NIFI-: - Ensure the /nifi-api/controller redirection filter executes before matching. This closes # 2358. Signed-off-by: Andy LoPresto > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Matt Gilman >Assignee: Matt Gilman > Fix For: 1.5.0 > > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[
https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308172#comment-16308172
]
ASF GitHub Bot commented on NIFI-:
--
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2358
Tested by visiting http://localhost:8080/nifi-api/controller without the
patch applied -- error "The specified resource could not be found". With the
patch applied -- returns expected JSON:
`{"controller":{"id":"b76231af-0160-1000-11f3-3e937575391f","runningCount":0,"stoppedCount":0,"invalidCount":0,"disabledCount":0,"inputPortCount":0,"outputPortCount":0,"siteToSiteSecure":false,"instanceId":"b76231b1-0160-1000-9062-ebe2c82af742","inputPorts":[],"outputPorts":[]}}`
Ran `contrib-check` and all tests pass. +1, merging.
> Upgrade Jersey Versions
> ---
>
> Key: NIFI-
> URL: https://issues.apache.org/jira/browse/NIFI-
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.5.0
>
> Attachments: NIFI-.xml
>
>
> Need to upgrade to a newer version of Jersey. The primary motivation is to
> upgrade the version used within NiFi itself. However, there are a number of
> extensions that also leverage it. Of those extensions, some utilize the older
> version defined in dependencyManagement while others override explicitly
> within their own bundle dependencyManagement. For this JIRA I propose
> removing the Jersey artifacts from the root pom and allow the version to be
> specified on a bundle by bundle basis.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308091#comment-16308091 ] ASF GitHub Bot commented on NIFI-: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2358 Reviewing... > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Matt Gilman >Assignee: Matt Gilman > Fix For: 1.5.0 > > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300500#comment-16300500 ] ASF GitHub Bot commented on NIFI-: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2358 NIFI-: Ensuring the /nifi-api/controller redirection filter runs NIFI-: - Ensure the /nifi-api/controller redirection filter executes before matching. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI- Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2358.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2358 commit 230420507a2403d62c15c623762e92d95194ec7a Author: Matt Gilman Date: 2017-12-21T19:54:09Z NIFI-: - Ensure the /nifi-api/controller redirection filter executes before matching. > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Matt Gilman >Assignee: Matt Gilman > Fix For: 1.5.0 > > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204000#comment-16204000 ] ASF GitHub Bot commented on NIFI-: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2206 > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Matt Gilman >Assignee: Matt Gilman > Fix For: 1.5.0 > > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202316#comment-16202316 ] ASF GitHub Bot commented on NIFI-: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2206 I discovered some issues with the admin toolkit and will be opening a Jira to resolve that. In the meantime, I validated everything except the toolkit behavior for this PR, but that was confirmed by @bbende and @mcgilman . Ran `contrib-check` and all tests pass. +1, merging. > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201304#comment-16201304 ] ASF GitHub Bot commented on NIFI-: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2206 I had some trouble getting the cluster configured successfully due to Zookeeper port conflicts (will be filing a Jira to improve the error messaging there). I got it working and the flow operates successfully on both branches. I can't get the toolkit to work, however. Both `notify.sh` and `node-manager.sh` are reporting errors parsing the `-b` option for the existing `bootstrap.conf` file, so I will keep playing with that. Meanwhile, the unit tests and contrib-check all pass on the latest commit. > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200912#comment-16200912 ] ASF GitHub Bot commented on NIFI-: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2206 Thanks @bbende. I've pushed another commit that addresses the checkstyle issues. > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200902#comment-16200902 ] ASF GitHub Bot commented on NIFI-: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2206 Reviewing... > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200845#comment-16200845 ] ASF GitHub Bot commented on NIFI-: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2206 Also some unused imports in the Yandex bundle > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200816#comment-16200816 ] ASF GitHub Bot commented on NIFI-: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2206 There is a minor check style violation in RedirectResourceFilter for the @return java doc. > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman > Attachments: NIFI-.xml > > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200746#comment-16200746 ] ASF GitHub Bot commented on NIFI-: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2206 This PR upgrades Jersey throughout NiFi where it is used directly. Most transitive Jersey dependencies are left intact. The most significant changes are centered in the clustering framework, UpdateAttribute custom UI, JoltTransform custom UI, and the toolkit groovy scripts. To most easily evaluate these changes try the template attached in the JIRA in clustered mode and run the node manager toolkit utility. > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4444) Upgrade Jersey Versions
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200733#comment-16200733 ] ASF GitHub Bot commented on NIFI-: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2206 NIFI-: Upgrade to Jersey 2.x NIFI-: - Upgrading to Jersey 2.x. - Updating NOTICE files where necessary. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI- Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2206 commit cb28bb5daa582117f7057ff819df4588e1c8cda1 Author: Matt Gilman Date: 2017-10-02T21:01:31Z NIFI-: - Upgrading to Jersey 2.x. - Updating NOTICE files where necessary. > Upgrade Jersey Versions > --- > > Key: NIFI- > URL: https://issues.apache.org/jira/browse/NIFI- > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matt Gilman >Assignee: Matt Gilman > > Need to upgrade to a newer version of Jersey. The primary motivation is to > upgrade the version used within NiFi itself. However, there are a number of > extensions that also leverage it. Of those extensions, some utilize the older > version defined in dependencyManagement while others override explicitly > within their own bundle dependencyManagement. For this JIRA I propose > removing the Jersey artifacts from the root pom and allow the version to be > specified on a bundle by bundle basis. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
