[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2020-12-14 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249209#comment-17249209
 ] 

David Handermann commented on NIFI-4558:


This feature would be useful, but instead of defaulting to JKS, it seems better 
to use the KeyStore.getDefaultType() method to match the JVM runtime 
configuration.  This would result in JKS on Java 8 and PKCS12 on Java 9 and 
greater.  If that is too confusing, recommend defaulting to PKCS12 as that is 
the standard for current versions of Java.

> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-10-20 Thread Jeff Storck (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658006#comment-16658006
 ] 

Jeff Storck commented on NIFI-4558:
---

Removed fix version of 1.8.0, with the changes for this JIRA having been 
reverted in master.

> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-10-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658005#comment-16658005
 ] 

ASF GitHub Bot commented on NIFI-4558:
--

Github user jtstorck commented on the issue:

https://github.com/apache/nifi/pull/3097
  
+1, merged to master.

I verified that the changes have been reverted, and that the full build 
with tests and contrib-check is successful.


> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
> Fix For: 1.8.0
>
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-10-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658004#comment-16658004
 ] 

ASF GitHub Bot commented on NIFI-4558:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/3097


> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
> Fix For: 1.8.0
>
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-10-20 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658003#comment-16658003
 ] 

ASF subversion and git services commented on NIFI-4558:
---

Commit 08c54bc48d14d559ce38970ecde0b9583ecc96a5 in nifi's branch 
refs/heads/master from thenatog
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=08c54bc ]

Revert "NIFI-4558 - Set JKS as the default keystore type and truststore type."

This reverts commit 2b9fdf8415eb2b033bfc63a6c5254bba3e69ecdd.

This closes #3097.


> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
> Fix For: 1.8.0
>
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-10-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657379#comment-16657379
 ] 

ASF GitHub Bot commented on NIFI-4558:
--

GitHub user thenatog opened a pull request:

https://github.com/apache/nifi/pull/3097

Revert "NIFI-4558 - Set JKS as the default keystore type and truststo…

…re type."

This reverts commit 2b9fdf8415eb2b033bfc63a6c5254bba3e69ecdd.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thenatog/nifi NIFI-4558-rebased

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/3097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3097


commit ddc4e28967c55ebe3522c16dc1e0bd642936e534
Author: thenatog 
Date:   2018-10-19T19:46:12Z

Revert "NIFI-4558 - Set JKS as the default keystore type and truststore 
type."

This reverts commit 2b9fdf8415eb2b033bfc63a6c5254bba3e69ecdd.




> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
> Fix For: 1.8.0
>
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-08-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599070#comment-16599070
 ] 

ASF subversion and git services commented on NIFI-4558:
---

Commit 97e0f6a6a700e425bf9fd39711da78dda74b87c9 in nifi's branch 
refs/heads/master from thenatog
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=97e0f6a ]

NIFI-4558 - Set JKS as the default keystore type and truststore type.

This closes #2982.

Signed-off-by: Andy LoPresto 


> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-08-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599067#comment-16599067
 ] 

ASF GitHub Bot commented on NIFI-4558:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/2982
  
Verified that this sets the defaults to "JKS" for both keystore and 
truststore on `StandardSSLContextService` and 
`StandardRestrictedSSLContextService`. 

Ran `contrib-check` and all tests pass. +1, merging. 


> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-08-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598980#comment-16598980
 ] 

ASF GitHub Bot commented on NIFI-4558:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/2982
  
Reviewing...


> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Assignee: Nathan Gough
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-4558) Populate default keystore/truststore types in SSLContextService

2018-08-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598790#comment-16598790
 ] 

ASF GitHub Bot commented on NIFI-4558:
--

GitHub user thenatog opened a pull request:

https://github.com/apache/nifi/pull/2982

NIFI-4558 - Set JKS as the default keystore type and truststore type.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thenatog/nifi NIFI-4558

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2982.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2982


commit 2b9fdf8415eb2b033bfc63a6c5254bba3e69ecdd
Author: thenatog 
Date:   2018-08-31T14:17:28Z

NIFI-4558 - Set JKS as the default keystore type and truststore type.




> Populate default keystore/truststore types in SSLContextService
> ---
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Andy LoPresto
>Priority: Trivial
>  Labels: controller_services, jks, keystore, pkcs12, security, 
> ssl, tls, truststore, ux
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12 
> when creating SSL controller services. Both {{StandardSSLContextService}} and 
> {{StandardRestrictedSSLContextService}} should have those fields 
> autopopulated to JKS, saving 2-4 clicks per instantiation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)