[jira] [Commented] (NIFI-4816) Changes to ReportingTask name are not available to the ReportingTask

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371495#comment-16371495
 ] 

ASF GitHub Bot commented on NIFI-4816:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2452


> Changes to ReportingTask name are not available to the ReportingTask
> 
>
> Key: NIFI-4816
> URL: https://issues.apache.org/jira/browse/NIFI-4816
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> The Reporting Task name is only set on the ReportingTask itself during 
> initialize(), which is only called the first time the ReportingTask is 
> instantiated. This means if you change the name of the ReportingTask and 
> restart it, The ReportingTask has its original name and the current name is 
> inaccessible via the ConfigurationContext it is passed later. If you restart 
> NiFi, the new name is set and stays that way.
> Rather than calling initialize() more than once, it is proposed to make the 
> current name (and any other appropriate properties) available perhaps via 
> ConfigurationContext which is passed to methods annotated with OnScheduled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4816) Changes to ReportingTask name are not available to the ReportingTask

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371471#comment-16371471
 ] 

ASF GitHub Bot commented on NIFI-4816:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2452
  
@mattyb149 this looks good to me now! Thanks for updating. I'm not in a 
position to merge right now, but I will give it a +1 if you want to merge 
yourself. Otherwise I will merge when I get my local branch squared away. 
Thanks!


> Changes to ReportingTask name are not available to the ReportingTask
> 
>
> Key: NIFI-4816
> URL: https://issues.apache.org/jira/browse/NIFI-4816
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> The Reporting Task name is only set on the ReportingTask itself during 
> initialize(), which is only called the first time the ReportingTask is 
> instantiated. This means if you change the name of the ReportingTask and 
> restart it, The ReportingTask has its original name and the current name is 
> inaccessible via the ConfigurationContext it is passed later. If you restart 
> NiFi, the new name is set and stays that way.
> Rather than calling initialize() more than once, it is proposed to make the 
> current name (and any other appropriate properties) available perhaps via 
> ConfigurationContext which is passed to methods annotated with OnScheduled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4816) Changes to ReportingTask name are not available to the ReportingTask

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354555#comment-16354555
 ] 

ASF GitHub Bot commented on NIFI-4816:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2452
  
The idea for storing off the name for all reporting tasks is to support 
#2431 , in fact that's where this behavior was discovered.

I like the @OnScheduled setName() idea, I may call it something more 
specific (rather than a bean method) since it will take a context. Will make 
the change, thanks!


> Changes to ReportingTask name are not available to the ReportingTask
> 
>
> Key: NIFI-4816
> URL: https://issues.apache.org/jira/browse/NIFI-4816
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> The Reporting Task name is only set on the ReportingTask itself during 
> initialize(), which is only called the first time the ReportingTask is 
> instantiated. This means if you change the name of the ReportingTask and 
> restart it, The ReportingTask has its original name and the current name is 
> inaccessible via the ConfigurationContext it is passed later. If you restart 
> NiFi, the new name is set and stays that way.
> Rather than calling initialize() more than once, it is proposed to make the 
> current name (and any other appropriate properties) available perhaps via 
> ConfigurationContext which is passed to methods annotated with OnScheduled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4816) Changes to ReportingTask name are not available to the ReportingTask

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354314#comment-16354314
 ] 

ASF GitHub Bot commented on NIFI-4816:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2452
  
@mattyb149 thanks for the update. This is definitely something that I think 
we should have added at the start. I'm curious about why the update to all of 
the reporting tasks, though. None of them make use of the name, as far as I can 
tell, so why both storing it off? Moreover, if we do want to store it off, then 
why not just have the setName() method have an @OnScheduled annotation and take 
in the ConfigurationContext. Then the abstract impl will automatically have the 
name set. It would not necessarily be available if being called from other 
@OnScheduled methods, but I think that's okay as long as it is documented - in 
such a case, you should call the method on the ReportingContext itself.


> Changes to ReportingTask name are not available to the ReportingTask
> 
>
> Key: NIFI-4816
> URL: https://issues.apache.org/jira/browse/NIFI-4816
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> The Reporting Task name is only set on the ReportingTask itself during 
> initialize(), which is only called the first time the ReportingTask is 
> instantiated. This means if you change the name of the ReportingTask and 
> restart it, The ReportingTask has its original name and the current name is 
> inaccessible via the ConfigurationContext it is passed later. If you restart 
> NiFi, the new name is set and stays that way.
> Rather than calling initialize() more than once, it is proposed to make the 
> current name (and any other appropriate properties) available perhaps via 
> ConfigurationContext which is passed to methods annotated with OnScheduled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4816) Changes to ReportingTask name are not available to the ReportingTask

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354204#comment-16354204
 ] 

ASF GitHub Bot commented on NIFI-4816:
--

GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/2452

NIFI-4816: Allow name to be updated for ReportingTasks

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-4816

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2452


commit 32d8069a053e2468bd8d6bf7232954572732e391
Author: Matthew Burgess 
Date:   2018-02-06T17:11:45Z

NIFI-4816: Allow name to be updated for ReportingTasks




> Changes to ReportingTask name are not available to the ReportingTask
> 
>
> Key: NIFI-4816
> URL: https://issues.apache.org/jira/browse/NIFI-4816
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> The Reporting Task name is only set on the ReportingTask itself during 
> initialize(), which is only called the first time the ReportingTask is 
> instantiated. This means if you change the name of the ReportingTask and 
> restart it, The ReportingTask has its original name and the current name is 
> inaccessible via the ConfigurationContext it is passed later. If you restart 
> NiFi, the new name is set and stays that way.
> Rather than calling initialize() more than once, it is proposed to make the 
> current name (and any other appropriate properties) available perhaps via 
> ConfigurationContext which is passed to methods annotated with OnScheduled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)