[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380595#comment-16380595 ] ASF subversion and git services commented on NIFI-4839: --- Commit fe71c18ec58c1b4b2971d32b8184dd0d2dbba402 in nifi's branch refs/heads/master from [~aperepel] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=fe71c18 ] NIFI-4839 - Support both public URLs and local files as inputs for import actions. - The handling of empty canvas got lost in the merge, causing errors with a new NiFi instance. - Broaden support for input, now supportes both local files _and_ any public URL with a schema recognized by Java runtime. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380604#comment-16380604 ] ASF subversion and git services commented on NIFI-4839: --- Commit 2fd24b78e6883b9c52ca53a626db17957a066276 in nifi's branch refs/heads/master from [~aperepel] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=2fd24b7 ] NIFI-4839 - The "Disabled" column had incorrect size and skewed the header > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.6.0 > > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380600#comment-16380600 ] ASF subversion and git services commented on NIFI-4839: --- Commit b68eebd4293bc921148d933ad94d890c388ce4d0 in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b68eebd ] NIFI-4839 - Added abbreviation in simple output for name, description, and comments - Refactored so that commands produce a result which can then be written or used - Added support for back-referencing results, initially prototyped by Andrew Grande - Fixed dynamic table layout when writing simple results - Added a new command group called 'demo' with a new 'quick-import' command - Fixes/improvements after previous refactoring - Created a reusable TableWriter and updating a few result classes to use it > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.6.0 > > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380597#comment-16380597 ] ASF subversion and git services commented on NIFI-4839: --- Commit 69367ff0bf9321c498973e64103e2a1477037383 in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=69367ff ] NIFI-4839 - Updating README and cleaning up descriptions and comments - Making registryClientId optional and auto selecting when only one is available - Added delete-bucket command - Added delete-flow command for registry > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.6.0 > > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380608#comment-16380608 ] ASF GitHub Bot commented on NIFI-4839: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2477 > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.6.0 > > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380601#comment-16380601 ] ASF subversion and git services commented on NIFI-4839: --- Commit d1027879ebd606f8781b5024b1ca2ce3f4f54068 in nifi's branch refs/heads/master from [~aperepel] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d102787 ] NIFI-4839 - Fixed handling of a connection object position - it doesn't have one and just returns null (calculated by the UI dynamically) > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.6.0 > > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380603#comment-16380603 ] ASF subversion and git services commented on NIFI-4839: --- Commit 1911635a3a39ca0ee3e4c7163a0aa6d14c0b401f in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1911635 ] NIFI-4839 - Switching standalone mode to default to simple output - Added pg-status command and improved output of pg-list - Setting up back-refs for pg-list and using table layout for pg-get-vars and pg-get-version - Only print usage on errors related to missing/incorrect options > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.6.0 > > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380605#comment-16380605 ] ASF subversion and git services commented on NIFI-4839: --- Commit 5041bea773c47b0b16b0a0e713d13c16f0cd66b6 in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=5041bea ] NIFI-4839 Improving back-ref support so that ReferenceResolver is passed the option being resolved - Adding ResolvedReference to encapsulate the results of resolving a back-reference. - Update README.md - Added OkResult for delete commands - Added sync-flow-versions and transfer-flow-version to registry commands - Returning appropriate status code when exiting standalone mode - Adding security section to README Signed-off-by: Pierre Villard This closes #2477. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.6.0 > > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380598#comment-16380598 ] ASF subversion and git services commented on NIFI-4839: --- Commit cc3c1b17142ef7767d429481008b2643e890f875 in nifi's branch refs/heads/master from [~aperepel] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=cc3c1b1 ] NIFI-4839 - Implemented nice dynamic table output for all list-XXX commands (in simple mode) - Better output formatting for 'registry list-buckets' - Implemented dynamic table formatting for 'registry list-XXX' commands - Implemented dynamic table formatting for 'nifi list-registry-clients' command - Implemented dynamic table formatting for 'nifi list-registry-clients' command - Better handling of non-null, but empty descriptions and commit messages > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.6.0 > > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380594#comment-16380594 ] ASF subversion and git services commented on NIFI-4839: --- Commit c1c808002c32008f31ec80664046c1857782e5a9 in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c1c8080 ] NIFI-4839 - Modified how the process group box is calculated - Adding command to get the id of a registry client by name - Refactoring how results are written to support option of simple or json output - Added pg-set-var command - Added pg-list command - Added getDescription to every command and prints when asking for help on a command - Adding verbose out to help command to print description for every command > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380593#comment-16380593 ] ASF subversion and git services commented on NIFI-4839: --- Commit e3cc7bee057e7cbc3c7c852f170d5fa34749cdb5 in nifi's branch refs/heads/master from [~aperepel] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=e3cc7be ] NIFI-4839 - Implemented auto-layout when importing the PG. Will find an available spot on a canvas which doesn't overlap with other components and is as close to the canvas center as possible. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380558#comment-16380558 ] ASF GitHub Bot commented on NIFI-4839: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2477 +1. Just a remark: the version of commons-io does not need to be specified in the toolkit-cli pom file as it's already defined in the root pom. Will take care of it while merging. Thanks for the amazing job. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380119#comment-16380119 ] ASF GitHub Bot commented on NIFI-4839: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2477 Will have a final review today. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377543#comment-16377543 ] ASF GitHub Bot commented on NIFI-4839: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2477 @pvillard31 since you tested this out a bit, would you be able to give a final review & merge? > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377253#comment-16377253 ] ASF GitHub Bot commented on NIFI-4839: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2477 Fixed the issue with returning the appropriate exit code in standalone mode. An example of testing this would be running a script like the following: ``` #!/bin/sh CMD_OUT=`./bin/cli.sh registry xyz` STATUS_CODE=$? if [ $STATUS_CODE -eq 0 ]; then echo "SUCCESS" else echo "FAILURE" fi ``` This should print FAILURE since xyz is not a valid command, editing the script to replace xyz with list-buckets should print SUCCESS. Also added a security section to the README. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371675#comment-16371675 ] ASF GitHub Bot commented on NIFI-4839: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2477 @bbende agree with your points: we can keep things as-is for now and have a larger effort for documentation with follow-up JIRAs. @aperepel I *really* believe that online documentation provides a much better exposure. A lot of people I discuss with completely ignore the existence of the toolkit binaries. And we've a lot of interesting stuff in it. I think that providing a mechanism with annotations in the code and automatic generation of the documentation can answer both the online documentation and the information in the command's output. That would be the best approach IMO. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371457#comment-16371457 ] ASF GitHub Bot commented on NIFI-4839: -- Github user aperepel commented on the issue: https://github.com/apache/nifi/pull/2477 @pvillard31 we were discussing a modular design for commands with dynamic discovery/loading (e.g. via Java's ServiceLoader mechanism). This is to support the idea that we should try to incorporate as much reference documentation as possible into command's output, and only add doc pages focusing on the workflow, typical use cases and best practices instead. My $.02 > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371324#comment-16371324 ] ASF GitHub Bot commented on NIFI-4839: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2477 @pvillard31 thanks for the feedback! Regarding the docs... Long-term I do agree that our admin guide has become quite lengthy and hard to find information, and we should probably spin-off a "Toolkit Guide", but I think this would be a bigger effort that could follow on later. Even if we do that though, I want to avoid having a manually maintained list of commands and there usage. It would likely always be out of date as people add new commands and have no idea there is a doc somewhere else, kind of like if you added a processor to NiFi and had to remember to manually update docs somewhere else. The interactive shell should give all the help via "help", "help -v", and "command help". So whatever docs we write should focus more on scenarios/tasks that can be accomplished. For now I would say either.. A) Leave the README and maybe add a little bit more information B) Move the README contents to a section in the admin guide Then later we can figure out the Toolkit Guide idea, and could consider fancy things like auto-generating docs for the CLI using annotations like processors have :) Thoughts? > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371090#comment-16371090 ] ASF GitHub Bot commented on NIFI-4839: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2477 Played a bit with the cli and it's really cool. Amazing job @bbende & @aperepel! Can we consider adding an online documentation for it (in addition to the README)? I think @andrewmlim is working on a registry doc and it could be added there but it could also be a dedicated page in our docs (https://nifi.apache.org/docs/nifi-docs/). I think it'd make sense to have a "Toolkit" part with a page for each element of the toolkit package. The documentation for this cli would contain the exhaustive list of the commands we can execute and maybe some common scenarios one will certainly execute (kind of cheatsheet). Thoughts? > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369715#comment-16369715 ] ASF GitHub Bot commented on NIFI-4839: -- Github user fcntl commented on the issue: https://github.com/apache/nifi/pull/2477 +1 this is a very useful module to automate things like Nifi integration with the Registry. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367590#comment-16367590 ] ASF GitHub Bot commented on NIFI-4839: -- GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2477 NIFI-4839 Adding CLI to nifi-toolkit For whoever reviews this, I'd like to preserve the commit history to retain the contributions for each individual. I've already squashed down to the minimum set of commits. There is a quite a lot of code in this PR, but it is all under nifi-toolkit for adding a new CLI module. I would expect the review to focus more on the functional aspects, as I realize it would be a bit much to go through all of the code. The README file under nifi-toolkit/nifi-toolkit-cli should provide a good overview of the CLI and how to get started using it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi nifi-registry-toolkit Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2477 commit 066eb798e0909b2dc6f08ffdb32e6910fe421824 Author: Bryan Bende Date: 2018-01-22T15:31:15Z NIFI-4839 Creating nifi-toolkit-cli to provide a CLI for interacting with NiFi and NiFi Registry commit 41846a7e0b5685a51b59df2e1a468acf5a2ad393 Author: Andrew Grande Date: 2018-02-05T16:42:31Z NIFI-4839 - Rename the registry group to `registry` for better UX commit 34f8555cde8d1a80b0d15a8529691b391c786dc1 Author: Bryan Bende Date: 2018-02-05T16:48:33Z NIFI-4839 - Fixing completer unit test - Added pg-get-version, pg-get-all-versions, pg-change-version - Added info the Context to know if we are in interactive mode commit ea0f22e760ea594f1b3cdba44f19f3ad3393c888 Author: Andrew Grande Date: 2018-02-05T22:33:28Z NIFI-4839 - Implemented auto-layout when importing the PG. Will find an available spot on a canvas which doesn't overlap with other components and is as close to the canvas center as possible. commit 8c82c2cc46047c1d51845f391530dddc11e4ce08 Author: Bryan Bende Date: 2018-02-07T14:42:20Z NIFI-4839 - Modified how the process group box is calculated - Adding command to get the id of a registry client by name - Refactoring how results are written to support option of simple or json output - Added pg-set-var command - Added pg-list command - Added getDescription to every command and prints when asking for help on a command - Adding verbose out to help command to print description for every command commit b50ca0c762374d954d8cdeddd367ade0d26a663d Author: Andrew Grande Date: 2018-02-11T14:53:05Z NIFI-4839 - Support both public URLs and local files as inputs for import actions. - The handling of empty canvas got lost in the merge, causing errors with a new NiFi instance. - Broaden support for input, now supportes both local files _and_ any public URL with a schema recognized by Java runtime. commit 5aac940d248cdaceceb943ac5309f9be57b4fdf4 Author: Bryan Bende Date: 2018-02-11T16:13:18Z NIFI-4839 - Updating README and cleaning up descriptions and comments - Making registryClientId optional and auto selecting when only one is available - Added delete-bucket command - Added delete-flow command for registry commit e57a14ca83d5ea6e050c7ae3e6624225aaec2809 Author: Andrew Grande Date: 2018-02-12T17:18:14Z NIFI-4839 - Implemented nice dynamic table output for all list-XXX commands (in simple mode) - Better output formatting for 'registry list-buckets' - Implemented dynamic table formatting for 'registry list-XXX' commands - Implemented dynamic table formatting for 'nifi list-registry-clients' command - Implemented dynamic table formatting for 'nifi list-registry-clients' command - Better handling of non-null, but empty descriptions and commit messages commit 97765bb28f68f13f8ee3210736b6b91d3a210494 Author: Bryan Bende Date: 2018-02-12T19:19:12Z NIFI-4839 - Added abbreviation in simple output for name, description, and comments - Refactored so that commands produce a result which can then be written or used - Added support for back-referencing results, initially prototyped by Andrew Grande - Fixed dynamic table layout when writing simple results - Added a new command group called 'demo' with a new 'quick-import' command - Fixes/improvements after previous refactoring - Created a reusable TableWriter and updating a few result classes to use it commit e8e61b09d70e06ec72e314c0e89e3a355c427dc7 Author: Andrew Grande Date: 2018-02-14T20:25:55Z NIFI-4839 - Fixed handling of a connection objec
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364977#comment-16364977 ] Bryan Bende commented on NIFI-4839: --- Just clone my NiFi github repo and make sure you are on the nifi-registry-toolkit branch, then run a full build from the root: mvn clean install -DskipTests Once it is done, grab nifi-toolkit/nifi-toolkit-assembly/target/nifi-toolkit-1.6.0-SNAPSHOT-bin.tar.gz Extract that somewhere and run ./bin/cli.sh to enter the interactive shell. I would recommend reading the README first: https://github.com/bbende/nifi/blob/nifi-registry-toolkit/nifi-toolkit/nifi-toolkit-cli/README.md > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364844#comment-16364844 ] Daniel Oakley commented on NIFI-4839: - [~bende] OK thanks, are there any specific build instructions or can I just check out the github and "mvn build"? > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[
https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364183#comment-16364183
]
Bryan Bende commented on NIFI-4839:
---
[~spotty] yes I believe all of those case are already covered, but feel free to
try it out on my branch above.
Here is a list of the commands as of right now, but things are subject to
change until this is merged to master:
{code:java}
#> help
commands:
demo quick-import
nifi current-user
nifi get-root-id
nifi list-reg-clients
nifi create-reg-client
nifi update-reg-client
nifi get-reg-client-id
nifi pg-import
nifi pg-start
nifi pg-stop
nifi pg-get-vars
nifi pg-set-var
nifi pg-get-version
nifi pg-change-version
nifi pg-get-all-versions
nifi pg-list
registry current-user
registry list-buckets
registry create-bucket
registry delete-bucket
registry list-flows
registry create-flow
registry delete-flow
registry list-flow-versions
registry export-flow-version
registry import-flow-version
session keys
session show
session get
session set
session remove
session clear
exit
help{code}
> Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
>
>
> Key: NIFI-4839
> URL: https://issues.apache.org/jira/browse/NIFI-4839
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>
> Now that we have NiFi Registry and the ability to import/upgrade flows in
> NiFi, we should offer a command-line tool to interact with these REST
> end-points. This could part of NiFi Toolkit and would help people potentially
> automate some of these operations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363231#comment-16363231 ] Daniel Oakley commented on NIFI-4839: - I had some questions about the intended capabilities of this script: 1) Can it be used to configure a fresh Nifi instance to integrate with a nifi-registry? 2) Can it tell Nifi to add a flow from the registry to the base flow? 3) Can it stop/start the base flow and everything in it? I require the above capabilities in order to automate the deployment of a fresh Nifi docker instance and have it load and start a given flow from the registry. Currently I embed the flow.xml.gz in the Docker image but it would be nice to be able to externalize it through the registry. > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351516#comment-16351516 ] Bryan Bende commented on NIFI-4839: --- Work-in-progress here: https://github.com/bbende/nifi/tree/nifi-registry-toolkit/nifi-toolkit/nifi-toolkit-cli > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows > > > Key: NIFI-4839 > URL: https://issues.apache.org/jira/browse/NIFI-4839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > Now that we have NiFi Registry and the ability to import/upgrade flows in > NiFi, we should offer a command-line tool to interact with these REST > end-points. This could part of NiFi Toolkit and would help people potentially > automate some of these operations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
