[jira] [Commented] (NIFI-4894) nf-canvas-utils#queryBulletins does not account for possible proxy path
[ https://issues.apache.org/jira/browse/NIFI-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370141#comment-16370141 ] ASF GitHub Bot commented on NIFI-4894: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2482 NIFI-4894: Ensuring that any proxy paths are retained when querying for bulletins NIFI-4894: - Ensuring that any proxy paths are retained when querying for bulletins. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-4894 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2482.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2482 commit c463f78b12f569a6954ce66e79b709e4805986f5 Author: Matt Gilman Date: 2018-02-20T15:28:50Z NIFI-4894: - Ensuring that any proxy paths are retained when querying for bulletins. > nf-canvas-utils#queryBulletins does not account for possible proxy path > --- > > Key: NIFI-4894 > URL: https://issues.apache.org/jira/browse/NIFI-4894 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > > The queryBulletins function in nf-canvas-utils does not account for possible > proxy paths when querying for bulletins. We cannot, unfortunately, use > relative paths here since we need to know the full URL (to know it's length) > in order to break the query into multiple requests if necessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4894) nf-canvas-utils#queryBulletins does not account for possible proxy path
[ https://issues.apache.org/jira/browse/NIFI-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370220#comment-16370220 ] ASF GitHub Bot commented on NIFI-4894: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2482 Reviewing... > nf-canvas-utils#queryBulletins does not account for possible proxy path > --- > > Key: NIFI-4894 > URL: https://issues.apache.org/jira/browse/NIFI-4894 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > > The queryBulletins function in nf-canvas-utils does not account for possible > proxy paths when querying for bulletins. We cannot, unfortunately, use > relative paths here since we need to know the full URL (to know it's length) > in order to break the query into multiple requests if necessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4894) nf-canvas-utils#queryBulletins does not account for possible proxy path
[ https://issues.apache.org/jira/browse/NIFI-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371585#comment-16371585 ] ASF GitHub Bot commented on NIFI-4894: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2482 @mcgilman I have reviewed and built these changes and all looks good. > nf-canvas-utils#queryBulletins does not account for possible proxy path > --- > > Key: NIFI-4894 > URL: https://issues.apache.org/jira/browse/NIFI-4894 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > > The queryBulletins function in nf-canvas-utils does not account for possible > proxy paths when querying for bulletins. We cannot, unfortunately, use > relative paths here since we need to know the full URL (to know it's length) > in order to break the query into multiple requests if necessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4894) nf-canvas-utils#queryBulletins does not account for possible proxy path
[ https://issues.apache.org/jira/browse/NIFI-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371772#comment-16371772 ] ASF GitHub Bot commented on NIFI-4894: -- Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2482 @mcgilman @scottyaslan I was able to reproduce the bug in master while proxying with Knox by creating a HandleHttpRequest processor with a StandardHttpContextMap controller service. Attempting to enable the service through the UI resulted in the 404. After applying the PR to master and restarting, I was able to go through the same steps and successfully enable the StandardHttpContextMap controller service. +1 LGTM! > nf-canvas-utils#queryBulletins does not account for possible proxy path > --- > > Key: NIFI-4894 > URL: https://issues.apache.org/jira/browse/NIFI-4894 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > > The queryBulletins function in nf-canvas-utils does not account for possible > proxy paths when querying for bulletins. We cannot, unfortunately, use > relative paths here since we need to know the full URL (to know it's length) > in order to break the query into multiple requests if necessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4894) nf-canvas-utils#queryBulletins does not account for possible proxy path
[ https://issues.apache.org/jira/browse/NIFI-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371778#comment-16371778 ] ASF GitHub Bot commented on NIFI-4894: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2482 > nf-canvas-utils#queryBulletins does not account for possible proxy path > --- > > Key: NIFI-4894 > URL: https://issues.apache.org/jira/browse/NIFI-4894 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Fix For: 1.6.0 > > > The queryBulletins function in nf-canvas-utils does not account for possible > proxy paths when querying for bulletins. We cannot, unfortunately, use > relative paths here since we need to know the full URL (to know it's length) > in order to break the query into multiple requests if necessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4894) nf-canvas-utils#queryBulletins does not account for possible proxy path
[ https://issues.apache.org/jira/browse/NIFI-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371788#comment-16371788 ] ASF GitHub Bot commented on NIFI-4894: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2482 Thanks @jtstorck! Thanks @mcgilman this has been merged to master. > nf-canvas-utils#queryBulletins does not account for possible proxy path > --- > > Key: NIFI-4894 > URL: https://issues.apache.org/jira/browse/NIFI-4894 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Fix For: 1.6.0 > > > The queryBulletins function in nf-canvas-utils does not account for possible > proxy paths when querying for bulletins. We cannot, unfortunately, use > relative paths here since we need to know the full URL (to know it's length) > in order to break the query into multiple requests if necessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
