[jira] [Commented] (NIFI-4955) ValidateRecord does not preserve columns ordering with CSV
[ https://issues.apache.org/jira/browse/NIFI-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397653#comment-16397653 ] ASF GitHub Bot commented on NIFI-4955: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2528 > ValidateRecord does not preserve columns ordering with CSV > -- > > Key: NIFI-4955 > URL: https://issues.apache.org/jira/browse/NIFI-4955 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.6.0 > > > If using ValidateRecord with a CSV Reader and a CSV Writer, the CSV reader > creating the schema from the header, and the writer inheriting the schema > from the records, then columns ordering is not preserved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4955) ValidateRecord does not preserve columns ordering with CSV
[ https://issues.apache.org/jira/browse/NIFI-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397651#comment-16397651 ] ASF subversion and git services commented on NIFI-4955: --- Commit 11a7d5c09fb4fa965e7b240080f9a8b6b5730c62 in nifi's branch refs/heads/master from [~pvillard] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=11a7d5c ] NIFI-4955 - Preserve columns ordering with CSV and ValidateRecord Signed-off-by: Matthew Burgess This closes #2528 > ValidateRecord does not preserve columns ordering with CSV > -- > > Key: NIFI-4955 > URL: https://issues.apache.org/jira/browse/NIFI-4955 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.6.0 > > > If using ValidateRecord with a CSV Reader and a CSV Writer, the CSV reader > creating the schema from the header, and the writer inheriting the schema > from the records, then columns ordering is not preserved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4955) ValidateRecord does not preserve columns ordering with CSV
[ https://issues.apache.org/jira/browse/NIFI-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397650#comment-16397650 ] ASF GitHub Bot commented on NIFI-4955: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2528 +1 LGTM, reviewed the code, ran the unit tests, verified the expected behavior. Thanks for the fix! Merging to master > ValidateRecord does not preserve columns ordering with CSV > -- > > Key: NIFI-4955 > URL: https://issues.apache.org/jira/browse/NIFI-4955 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.6.0 > > > If using ValidateRecord with a CSV Reader and a CSV Writer, the CSV reader > creating the schema from the header, and the writer inheriting the schema > from the records, then columns ordering is not preserved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4955) ValidateRecord does not preserve columns ordering with CSV
[ https://issues.apache.org/jira/browse/NIFI-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393276#comment-16393276 ] ASF GitHub Bot commented on NIFI-4955: -- GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2528 NIFI-4955 - Preserve columns ordering with CSV and ValidateRecord Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-4955 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2528.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2528 commit cb4c89cc3528ffa54f4ec25dd61a74328c1e7560 Author: Pierre Villard Date: 2018-03-09T17:49:27Z NIFI-4955 - Preserve columns ordering with CSV and ValidateRecord > ValidateRecord does not preserve columns ordering with CSV > -- > > Key: NIFI-4955 > URL: https://issues.apache.org/jira/browse/NIFI-4955 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > > If using ValidateRecord with a CSV Reader and a CSV Writer, the CSV reader > creating the schema from the header, and the writer inheriting the schema > from the records, then columns ordering is not preserved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)