[jira] [Commented] (NIFI-4966) JacksonCSVRecordReader - NPE with some CSV formats

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397639#comment-16397639
 ] 

ASF GitHub Bot commented on NIFI-4966:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2535


> JacksonCSVRecordReader - NPE with some CSV formats
> --
>
> Key: NIFI-4966
> URL: https://issues.apache.org/jira/browse/NIFI-4966
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 1.6.0
>
>
> With some CSV formats (not the default one), we can get the following:
> {noformat}
> 2018-03-12 22:49:49,460 ERROR [Timer-Driven Process Thread-7] 
> o.a.nifi.processors.standard.QueryRecord 
> QueryRecord[id=4428e3a1-cf73-377f-150d-98d404785786] Failed to determine 
> Record Schema from 
> StandardFlowFileRecord[uuid=c5f428f0-0fa8-4660-b0df-6974bbd82f47,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1520889888555-181, 
> container=default, section=181], offset=604078, 
> length=37421],offset=0,name=865467214336135,size=37421]; routing to failure: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
>     at 
> com.fasterxml.jackson.databind.DeserializationConfig.withFeatures(DeserializationConfig.java:520)
>     at 
> com.fasterxml.jackson.databind.ObjectReader.withFeatures(ObjectReader.java:501)
>     at 
> org.apache.nifi.csv.JacksonCSVRecordReader.(JacksonCSVRecordReader.java:117)
>     at 
> org.apache.nifi.csv.CSVReader.createRecordReader(CSVReader.java:136)
>     at sun.reflect.GeneratedMethodAccessor520.invoke(Unknown Source)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:89)
>     at com.sun.proxy.$Proxy206.createRecordReader(Unknown Source)
>     at 
> org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:265)
>     at 
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
>     at 
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1123)
>     at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147)
>     at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
>     at 
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128)
>     at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>     at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
>     at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
>     at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>     at java.lang.Thread.run(Thread.java:745){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4966) JacksonCSVRecordReader - NPE with some CSV formats

2018-03-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397630#comment-16397630
 ] 

ASF subversion and git services commented on NIFI-4966:
---

Commit c75604a564c4abf5c4d26b512b4c6d7639fa592b in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c75604a ]

NIFI-4966 - JacksonCSVRecordReader - NPE with some CSV formats

Signed-off-by: Matthew Burgess 

This closes #2535


> JacksonCSVRecordReader - NPE with some CSV formats
> --
>
> Key: NIFI-4966
> URL: https://issues.apache.org/jira/browse/NIFI-4966
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> With some CSV formats (not the default one), we can get the following:
> {noformat}
> 2018-03-12 22:49:49,460 ERROR [Timer-Driven Process Thread-7] 
> o.a.nifi.processors.standard.QueryRecord 
> QueryRecord[id=4428e3a1-cf73-377f-150d-98d404785786] Failed to determine 
> Record Schema from 
> StandardFlowFileRecord[uuid=c5f428f0-0fa8-4660-b0df-6974bbd82f47,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1520889888555-181, 
> container=default, section=181], offset=604078, 
> length=37421],offset=0,name=865467214336135,size=37421]; routing to failure: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
>     at 
> com.fasterxml.jackson.databind.DeserializationConfig.withFeatures(DeserializationConfig.java:520)
>     at 
> com.fasterxml.jackson.databind.ObjectReader.withFeatures(ObjectReader.java:501)
>     at 
> org.apache.nifi.csv.JacksonCSVRecordReader.(JacksonCSVRecordReader.java:117)
>     at 
> org.apache.nifi.csv.CSVReader.createRecordReader(CSVReader.java:136)
>     at sun.reflect.GeneratedMethodAccessor520.invoke(Unknown Source)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:89)
>     at com.sun.proxy.$Proxy206.createRecordReader(Unknown Source)
>     at 
> org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:265)
>     at 
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
>     at 
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1123)
>     at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147)
>     at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
>     at 
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128)
>     at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>     at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
>     at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
>     at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>     at java.lang.Thread.run(Thread.java:745){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4966) JacksonCSVRecordReader - NPE with some CSV formats

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397629#comment-16397629
 ] 

ASF GitHub Bot commented on NIFI-4966:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2535
  
+1 LGTM, reviewed the code, ran the unit tests, verified the expected 
behavior. Thanks for the fix! Merging to master


> JacksonCSVRecordReader - NPE with some CSV formats
> --
>
> Key: NIFI-4966
> URL: https://issues.apache.org/jira/browse/NIFI-4966
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> With some CSV formats (not the default one), we can get the following:
> {noformat}
> 2018-03-12 22:49:49,460 ERROR [Timer-Driven Process Thread-7] 
> o.a.nifi.processors.standard.QueryRecord 
> QueryRecord[id=4428e3a1-cf73-377f-150d-98d404785786] Failed to determine 
> Record Schema from 
> StandardFlowFileRecord[uuid=c5f428f0-0fa8-4660-b0df-6974bbd82f47,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1520889888555-181, 
> container=default, section=181], offset=604078, 
> length=37421],offset=0,name=865467214336135,size=37421]; routing to failure: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
>     at 
> com.fasterxml.jackson.databind.DeserializationConfig.withFeatures(DeserializationConfig.java:520)
>     at 
> com.fasterxml.jackson.databind.ObjectReader.withFeatures(ObjectReader.java:501)
>     at 
> org.apache.nifi.csv.JacksonCSVRecordReader.(JacksonCSVRecordReader.java:117)
>     at 
> org.apache.nifi.csv.CSVReader.createRecordReader(CSVReader.java:136)
>     at sun.reflect.GeneratedMethodAccessor520.invoke(Unknown Source)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:89)
>     at com.sun.proxy.$Proxy206.createRecordReader(Unknown Source)
>     at 
> org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:265)
>     at 
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
>     at 
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1123)
>     at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147)
>     at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
>     at 
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128)
>     at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>     at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
>     at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
>     at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>     at java.lang.Thread.run(Thread.java:745){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4966) JacksonCSVRecordReader - NPE with some CSV formats

2018-03-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396162#comment-16396162
 ] 

ASF GitHub Bot commented on NIFI-4966:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/2535

NIFI-4966 - JacksonCSVRecordReader - NPE with some CSV formats

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-4966

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2535


commit f12dcf9cdaf834487eb1051545d1e21a6fbb6cd1
Author: Pierre Villard 
Date:   2018-03-12T22:20:07Z

NIFI-4966 - JacksonCSVRecordReader - NPE with some CSV formats




> JacksonCSVRecordReader - NPE with some CSV formats
> --
>
> Key: NIFI-4966
> URL: https://issues.apache.org/jira/browse/NIFI-4966
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> With some CSV formats (not the default one), we can get the following:
> {noformat}
> 2018-03-12 22:49:49,460 ERROR [Timer-Driven Process Thread-7] 
> o.a.nifi.processors.standard.QueryRecord 
> QueryRecord[id=4428e3a1-cf73-377f-150d-98d404785786] Failed to determine 
> Record Schema from 
> StandardFlowFileRecord[uuid=c5f428f0-0fa8-4660-b0df-6974bbd82f47,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1520889888555-181, 
> container=default, section=181], offset=604078, 
> length=37421],offset=0,name=865467214336135,size=37421]; routing to failure: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
>     at 
> com.fasterxml.jackson.databind.DeserializationConfig.withFeatures(DeserializationConfig.java:520)
>     at 
> com.fasterxml.jackson.databind.ObjectReader.withFeatures(ObjectReader.java:501)
>     at 
> org.apache.nifi.csv.JacksonCSVRecordReader.(JacksonCSVRecordReader.java:117)
>     at 
> org.apache.nifi.csv.CSVReader.createRecordReader(CSVReader.java:136)
>     at sun.reflect.GeneratedMethodAccessor520.invoke(Unknown Source)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:89)
>     at com.sun.proxy.$Proxy206.createRecordReader(Unknown Source)
>     at 
> org.apache.nifi.processors.standard.QueryRecord.onTrigger(QueryRecord.java:265)
>     at 
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
>     at 
>