[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490862#comment-16490862 ] ASF GitHub Bot commented on NIFI-5066: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2739 > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > Fix For: 1.7.0 > > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490861#comment-16490861 ] ASF GitHub Bot commented on NIFI-5066: -- Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2739 @mcgilman all looks good now, thanks! Have merged to master. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > Fix For: 1.7.0 > > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490860#comment-16490860 ] ASF subversion and git services commented on NIFI-5066: --- Commit dbef69040fe18ad9408937c78eb469ec5872eddc in nifi's branch refs/heads/master from [~mcgilman] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=dbef690 ] NIFI-5066: - Fixing predicate for finding all processors/ports that can be disabled. This closes #2739. Signed-off-by: Mark Payne > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > Fix For: 1.7.0 > > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490859#comment-16490859 ] ASF subversion and git services commented on NIFI-5066: --- Commit 18ec3861509193ab1affd196c01b315db6b98919 in nifi's branch refs/heads/master from [~mcgilman] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=18ec386 ] NIFI-5066: - Ensuring we verify we can enable/disable when appropriate. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > Fix For: 1.7.0 > > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490622#comment-16490622 ] ASF GitHub Bot commented on NIFI-5066: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2739 Thanks @markap14. I've pushed another commit that should address what you're seeing. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > Fix For: 1.7.0 > > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489783#comment-16489783 ] ASF GitHub Bot commented on NIFI-5066: -- Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2739 @mcgilman I tried testing this. Created a Process Group with 2 processors. One was STOPPED, the other DISABLED. Clicked on canvas to clear the selection. Then clicked "Disable" in the Operate palette. Got back an error: "92e58351-0163-1000-ab38-7947aeead66e is not stopped". > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > Fix For: 1.7.0 > > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489709#comment-16489709 ] ASF GitHub Bot commented on NIFI-5066: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2739 NIFI-5066: Fixing enable/disable verification NIFI-5066: - Ensuring we verify we can enable/disable when appropriate. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-5066 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2739.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2739 commit d1f43d0278f43f5570d9fae221717d062a204e4d Author: Matt Gilman Date: 2018-05-24T20:12:02Z NIFI-5066: - Ensuring we verify we can enable/disable when appropriate. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > Fix For: 1.7.0 > > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452894#comment-16452894 ] ASF GitHub Bot commented on NIFI-5066: -- Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2633 @mcgilman many thanks for adding this improvement. Code looks good. Was able to verify functionality and everything worked exactly as I expected. +1 merged to master. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452893#comment-16452893 ] ASF GitHub Bot commented on NIFI-5066: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2633 > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452892#comment-16452892 ] ASF subversion and git services commented on NIFI-5066: --- Commit 6938e58c81d857f5d56a694a6fef8cf94e60bce2 in nifi's branch refs/heads/master from [~mcgilman] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=6938e58 ] NIFI-5066: - Allowing the enable/disable buttons to be active under the same conditions as the start/stop buttons. This closes #2633. Signed-off-by: Mark Payne > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440874#comment-16440874 ] ASF GitHub Bot commented on NIFI-5066: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2633 @andrewmlim When no components are selected both enable/disable and start/stop should be allowed as the request will be applied to all eligible components in the current process group. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440864#comment-16440864 ] ASF GitHub Bot commented on NIFI-5066: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/2633 +1 for the UI code. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439708#comment-16439708 ] ASF GitHub Bot commented on NIFI-5066: -- Github user andrewmlim commented on the issue: https://github.com/apache/nifi/pull/2633 Changes look good. Enable/disable and start/stop buttons behave consistently. This is minor, but it would be nice if all of these buttons were greyed out (or unavailable in the context menu) when there were no components available i.e. when the process group is empty. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5066) Support enable and disable component action when multiple components selected or when selecting a process group.
[ https://issues.apache.org/jira/browse/NIFI-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436222#comment-16436222 ] ASF GitHub Bot commented on NIFI-5066: -- GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2633 NIFI-5066: Allow global enable/disable component requests NIFI-5066: - Allowing the enable/disable buttons to be active under the same conditions as the start/stop buttons. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-5066 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2633.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2633 commit 9acae47868823d5b0a45fb03f2639e9b16d7 Author: Matt Gilman Date: 2018-04-12T18:12:01Z NIFI-5066: - Allowing the enable/disable buttons to be active under the same conditions as the start/stop buttons. > Support enable and disable component action when multiple components selected > or when selecting a process group. > > > Key: NIFI-5066 > URL: https://issues.apache.org/jira/browse/NIFI-5066 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 >Reporter: Matthew Clarke >Assignee: Matt Gilman >Priority: Major > > Currently NiFi validates all processors that are in a STOPPED state. To > reduce impact when flows contain very large numbers of STOPPED processors, > users should be disabling these STOPPED processors. NiFi's "Enable" and > "Disable" buttons do not support being used when more then one processor is > selected. When needing to enable or disable large numbers of processors, > this is less then ideal. The Enable and Disable buttons should work similar > to how the Start and Stop buttons work. > Have multiple components selected or a process group selected. Select > "Enable" or "Disabled" button. Any eligible component (those that are not > running) should be either enabled or disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
