[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476221#comment-16476221 ] ASF GitHub Bot commented on NIFI-5077: -- Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2698 Thanks for the review guys > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Fix For: 1.7.0 > > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476220#comment-16476220 ] Otto Fowler commented on NIFI-5077: --- [~ramondg] you should be all set if you take the master build until 1.7.0 release! > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Fix For: 1.7.0 > > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476216#comment-16476216 ] ASF subversion and git services commented on NIFI-5077: --- Commit ccedc71c8b89e1792d79197f399b37b1ac541e3f in nifi's branch refs/heads/master from [~ottobackwards] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ccedc71 ] NIFI-5077 ExtractGrok support for `keep empty captures` Support for the new option to keep empty captures. I did not add to the GrokReader because I am not sure of the effect on the schema extraction. Signed-off-by: Pierre VillardThis closes #2698. > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Fix For: 1.7.0 > > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476217#comment-16476217 ] ASF GitHub Bot commented on NIFI-5077: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2698 > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Fix For: 1.7.0 > > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476212#comment-16476212 ] ASF GitHub Bot commented on NIFI-5077: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2698 Thanks @ottobackwards, merging to master > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476103#comment-16476103 ] ASF GitHub Bot commented on NIFI-5077: -- Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188355616 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java --- @@ -102,6 +103,15 @@ .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR) .build(); +public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new PropertyDescriptor.Builder() +.name("Keep Empty Captures") +.description("If true, then empty capture values will be included in the returned capture map.") +.required(false) --- End diff -- done > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476104#comment-16476104 ] ASF GitHub Bot commented on NIFI-5077: -- Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188355650 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java --- @@ -234,6 +247,11 @@ public void onStopped() { @OnScheduled public void onScheduled(final ProcessContext context) throws GrokException, IOException { + +if (context.getProperty(KEEP_EMPTY_CAPTURES).isSet()) { --- End diff -- done > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476099#comment-16476099 ] ASF GitHub Bot commented on NIFI-5077: -- Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188354997 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java --- @@ -102,6 +103,15 @@ .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR) .build(); +public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new PropertyDescriptor.Builder() +.name("Keep Empty Captures") +.description("If true, then empty capture values will be included in the returned capture map.") +.required(false) +.defaultValue("true") --- End diff -- No, currently the empties are returned, this maintains that > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476066#comment-16476066 ] ASF GitHub Bot commented on NIFI-5077: -- Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188345184 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java --- @@ -102,6 +103,15 @@ .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR) .build(); +public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new PropertyDescriptor.Builder() +.name("Keep Empty Captures") +.description("If true, then empty capture values will be included in the returned capture map.") +.required(false) +.defaultValue("true") --- End diff -- isn't defaulting to true a change of the current behavior? > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476064#comment-16476064 ] ASF GitHub Bot commented on NIFI-5077: -- Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188345339 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java --- @@ -234,6 +247,11 @@ public void onStopped() { @OnScheduled public void onScheduled(final ProcessContext context) throws GrokException, IOException { + +if (context.getProperty(KEEP_EMPTY_CAPTURES).isSet()) { --- End diff -- with required=true, you would not need to check if the property is set anymore > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476065#comment-16476065 ] ASF GitHub Bot commented on NIFI-5077: -- Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188344570 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java --- @@ -102,6 +103,15 @@ .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR) .build(); +public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new PropertyDescriptor.Builder() +.name("Keep Empty Captures") +.description("If true, then empty capture values will be included in the returned capture map.") +.required(false) --- End diff -- since it's an "allowable values"-type of property, we usually set required=true > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474233#comment-16474233 ] Otto Fowler commented on NIFI-5077: --- The PR is up, [~ramondg] please take a look > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474232#comment-16474232 ] ASF GitHub Bot commented on NIFI-5077: -- GitHub user ottobackwards opened a pull request: https://github.com/apache/nifi/pull/2698 NIFI-5077 ExtractGrok support for `keep empty captures` Support for the new option to keep empty captures. I did not add to the GrokReader because I am not sure of the effect on the schema extraction. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [-] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [-] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? I did not, in keeping with the current file ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ottobackwards/nifi grok-empty-captures Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2698.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2698 commit c5d44d56767effdbddeb66cc5c0ca89db670c6a1 Author: Otto FowlerDate: 2018-05-14T13:35:23Z NIFI-5077 ExtractGrok support for `keep empty captures` Support for the new option to keep empty captures. I did not add to the GrokReader because I am not sure of the effect on the schema extraction. > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474033#comment-16474033 ] Otto Fowler commented on NIFI-5077: --- Now that NIFI-5170 is in, I'll add support for this > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467436#comment-16467436 ] Otto Fowler commented on NIFI-5077: --- I'm working on NIFI-5170 first, then this will follow. Maybe you can help test and review the prs > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5077) Grok support for Empty Captures
[ https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467434#comment-16467434 ] Ramon de Graaff commented on NIFI-5077: --- Thanks a lot! > Grok support for Empty Captures > --- > > Key: NIFI-5077 > URL: https://issues.apache.org/jira/browse/NIFI-5077 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.6.0 > Environment: CentOS 7 >Reporter: Ramon de Graaff >Assignee: Otto Fowler >Priority: Major > Attachments: grok.xml > > Original Estimate: 24h > Remaining Estimate: 24h > > Pattern matches but also attaches null values. > grok-pattern: > {{TEST %\{A}|%\{B}}} > {{A %\{INT:test}}} > {{B %\{INT:test}}} > {{INT (?:[+-]?(?:[0-9]+))}} > flowfile-content: > {{1}} > Flow file attributes after match: > {{grok.A}} > {{1}} > {{grok.TEST}} > {{1}} > {{grok.test}} > {{[1, null]}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)